Passing values between forms.

MBK

Another problem,

I have 2 scripts - the first one is called common.php which contains a function used to display a registration form that has the current SESSION value assigned to all it's fields.
i.e company is the current users company name, gained from a query done when the user logs in, other than that the field is empty so new users can register.

The second form -edit.php - is used to allow the user to change their registration info. I have now worked out how to assign commands after the submit button is clicked, but now I have the following problem -

I can't seem to keep the new values anywhere!
Does this make any sense, or would it be better if I posted my code?

MrAlaska

If it is a registration form, how can the user be logged in and how can it already be populated?

The new values you would put where the old values were, just overwrite them. If you want to hang onto the old values for historical reasons, you would copy them into another table or file before overwriting them.

MBK

The form can be populated, because the user is logged in and is editing their current 'profile'.

Here is the code - as always all suggestions are welcome....

// common.php
<?

function show_form(){

echo"
<html>
<head>
<script>

//function checkrequired(which){
//var pass=true
//if (document.images){
//for (i=0;i<which.length;i++){
//var tempobj=which.elements[i]
//if (((tempobj.type=='text'||tempobj.type=='password')&&tempobj.value=='')||(tempobj.type.toString().charAt(0)=='s'&&tempobj.selectedIndex==-1)){
//pass=false
//break

//}
//}
//}
//if (!pass){
//alert('You have not completed all the required information.\\r\\nPlease complete your entry and then re-submit.')
//return false
//}
//else
//return true
//}
//</script>

</Head>

<title>Welcome! Enter your registration details.</title>
<font face='Arial' size='2'>
<h3><b>Enter your company information.<b></h3>
<body>
<form method='post'action=$PHP_SELF>

<table width='50%' border='0' cellspacing='0' cellpadding='0'>

   <div align='left'><font face='Arial' size='2'>
     <tr><td>Company Name:</td> <td>
	<input type='text' name='company' size=35 value='$_SESSION[company]'><br></td></tr>
     <tr><td>Address:</td> <td> 
	<input type='text' name='address' size=35 value='$_SESSION[address]'><br></td></tr>
     <tr><td></td><td>
	<input type'text' name='address2' size=35 value='$_SESSION[address2]'><br></td></tr>
     <tr><td>County:</td> <td> 
	<select name=county><option selected>$_SESSION[county]
	<option value=Aberdeenshire>Aberdeenshire</option><option value=Anglesey>Anglesey</option><option value=Angus>Angus</option>
<option value=Argyllshire>Argyllshire</option><option value=Avon>Avon</option><option value=Ayrshire>Ayrshire</option>
<option value=Banffshire>Banffshire</option><option value=Bedfordshire>Bedfordshire</option><option value=Berkshire>Berkshire</option>
<option value=Berwickshire>Berwickshire</option><option value=Breconshire>Breconshire</option><option value=Buckinghamshire>Buckinghamshire</option>
<option value=Buteshire>Buteshire</option><option value=Caernarvonshire>Caernarvonshire</option><option value=Cambridgeshire>Cambridgeshire</option>
<option value=Cardiganshire>Cardiganshire</option><option value=Carmarthenshire>Carmarthenshire</option><option value=Cheshire>Cheshire</option>
<option value=Clackmannanshire>Clackmannanshire</option><option value=Cleveland>Cleveland</option><option value=Cornwall>Cornwall</option>
<option value=Cumbria>Cumbria</option><option value=Denbighshire>Denbighshire</option><option value=Derbyshire>Derbyshire</option>
<option value=Devon>Devon</option><option value=Dorset>Dorset</option><option value=Durham>Durham</option>
<option value=East Sussex>East Sussex</option><option value=Essex>Essex</option><option value=Fifeshire>Fifeshire</option>
<option value=Flintshire>Flintshire</option><option value=Glamorganshire>Glamorganshire</option><option value=Gloucestershire>Gloucestershire</option>
<option value=Hampshire>Hampshire</option><option value=Herefordshire>Herefordshire</option><option value=Hertfordshire>Hertfordshire</option>
<option value=Humbershire>Humbershire</option><option value=Inverness-shire>Inverness-shire</option><option value=Isle Of Man>Isle Of Man</option>
<option value=Kent>Kent</option><option value=Kincardine>Kincardine</option><option value=Kinross>Kinross</option><option value=Kirkcudbrightshire>Kirkcudbrightshire</option>
<option value=Lanarkshire>Lanarkshire</option><option value=Lancashire>Lancashire</option><option value=Leicestershire>Leicestershire</option>
<option value=Lincolnshire>Lincolnshire</option><option value=Manchester>Manchester</option><option value=Merionethshire>Merionethshire</option>
<option value=Merseyside>Merseyside</option><option value=Middlesex>Middlesex</option><option value=Midlands>Midlands</option>
<option value=Midlothian>Midlothian</option><option value=Montgomeryshire>Montgomeryshire</option><option value=Morayshire>Morayshire</option>
<option value=Norfolk>Norfolk</option><option value=North Yorkshire>North Yorkshire</option><option value=Northamptonshire>Northamptonshire</option>
<option value=Northumberland>Northumberland</option><option value=Nottinghamshire>Nottinghamshire</option><option value=Orkney Islands>Orkney Islands</option>
<option value=Oxfordshire>Oxfordshire</option><option value=Peeblesshire>Peeblesshire</option><option value=Pembrokeshire>Pembrokeshire</option>
<option value=Perthshire>Perthshire</option><option value=Radnorshire>Radnorshire</option><option value=Renfrewshire>Renfrewshire</option>
<option value=Ross and Cromarty>Ross and Cromarty</option><option value=Roxburghshire>Roxburghshire</option><option value=Selkirkshire>Selkirkshire</option>
<option value=Shetland Islands>Shetland Islands</option><option value=Shropshire>Shropshire</option><option value=Somerset>Somerset</option>
<option value=South Yorkshire>South Yorkshire</option><option value=Staffordshire>Staffordshire</option><option value=Stirlingshire>Stirlingshire</option>
<option value=Suffolk>Suffolk</option><option value=Surrey>Surrey</option><option value=Sussex>Sussex</option>
<option value=Sutherlandshire>Sutherlandshire</option><option value=Tyne & Wear>Tyne & Wear</option><option value=Warwickshire>Warwickshire</option>
<option value=West Lothian>West Lothian</option><option value=West Sussex>West Sussex</option><option value=West Yorkshire>West Yorkshire</option>
<option value=West Midlands>West Midlands</option><option value=Wigtownshire>Wigtownshire</option><option value=Wiltshire>Wiltshire</option>
<option value=Worcestershire>Worcestershire</option><option value=Yorkshire>Yorkshire</option>

</tr>
     <tr><td>Post Code:</td> <td> 
	<input type='text' name='postcode' size=9 value='$_SESSION[postcode]'><br></td></tr>
     <tr><td>Phone No.:</td> <td> 
	<input type='text' name='tel' size=15 value='$_SESSION[tel]'><br></td></tr>
     <tr><td>Fax No.:</td> <td> 
	<input type='text' name='fax' size=15 value='$_SESSION[fax]'><br></td></tr>
     <tr><td>Web Site:</td> <td> 
	<input type='text' name='web' size=25 value='$_SESSION[web]'><br></td></tr>

</table>
<hr>


<font size='4'><b>Enter your contact information.</b></font>
<table width='50%' border='0' cellspacing='0' cellpadding='0'>
   <div align='left'><font face='Arial' size='2'>

<tr><td>First Name: </td> <td><input type='text' name='first' size=19 value='$_SESSION[first]'><br></td></tr>
<tr><td>Surname: </td> <td><input type='text' name='surname' size=19 value='$_SESSION[surname]'><br></td></tr>
<tr><td>Position: </td> <td><input type='text' name='position' size=20 value='$_SESSION[position]'><br></td></tr>
<tr><td>Phone No.: </td> <td><input type='text' name='phone' size=15 value='$_SESSION[phone]'><br></td></tr>
<tr><td>Email: </td> <td><input type='text' name='email' size=25 value='$_SESSION[email]'><br></td></tr><br>
</table>
<hr>

<table width='31.5%' border='0' cellspacing='0' cellpadding='0'>
   <div align='left'><font face='Arial' size='2'>
<tr><td>User Name: </td> <td><input type='text' name='user' size=19 value='$_SESSION[user]'><br></td></tr>
<tr><td>Password: </td> <td><input type='password' name='pass'  size=19 value='$_SESSION[pass]'><br></td></tr>
<tr><td>Confirm Password: </td> <td><input type='password' name='passconf' size=19 value='$_SESSION[pass]'><br></td></tr><br>
</table><hr>


</form>


</body>
</html>";}
?>

And this is for the edit.php

<?
session_start();

if (!session_is_registered("SESSION"))
{
header("Location: /error.php");
exit();
}
if ($HTTP_GET_VARS['submit']!="submit"){

$user=$HTTP_SESSION_VARS['SESSION_UNAME']; //define the username from the session name.

$connection=mysql_connect('localhost','root');//connect to the database
mysql_select_db('reseller');//select the database to use

  $userdata=mysql_fetch_assoc(mysql_query("select * from user where user ='$user'")); //select the user details from db.

   $pass=$userdata['pass'];
   $email=$userdata['email'];
   $company=$userdata['company'];

  $contactdata=mysql_fetch_assoc(mysql_query("select * from contact where email ='$email'"));
   $first=$contactdata['first'];
   $surname=$contactdata['surname'];
   $position=$contactdata['position'];
   $phone=$contactdata['phone'];

  $companydata=mysql_fetch_assoc(mysql_query("select * from company where company='$company'"));
   mysql_close();
   $address=$companydata['address'];
   $address2=$companydata['address2'];
   $county=$companydata['county'];
   $postcode=$companydata['postcode'];
   $tel=$companydata['tel'];
   $fax=$companydata['fax'];
   $web=$companydata['web'];

  $_SESSION["pass"]=$pass;
  $_SESSION["email"]=$email;
  $_SESSION["company"]=$company;
  $_SESSION["first"]=$first;
  $_SESSION["surname"]=$surname;
  $_SESSION["position"]=$position;
  $_SESSION["phone"]=$phone;
  $_SESSION["address"]=$address;
  $_SESSION["address2"]=$address2;
  $_SESSION["county"]=$county;
  $_SESSION["postcode"]=$postcode;
  $_SESSION["tel"]=$tel;
  $_SESSION["fax"]=$fax;
  $_SESSION["web"]=$web;





require("signup.php");
show_form();
echo"<html><form action=$PHP_SELF>
<input type=submit name=submit value=submit></form></html>";
}
else

if ($HTTP_GET_VARS["submit"]=="submit")
{
$_SESSION["company"]=$company;
echo"<html><script>
alert (\"$_SESSION["company"]\")
</script></html>";}
?>

If u view this, then I need the user to be able to change the current info held in the db about them, and then by clicking the submit button in edit.php, the database to be updated.

How can I do this, can someone help pls?

MBK

Can anyone help me this at all, or offer an alternative??

Pls..

MrAlaska

My screen isn't big enough to absorb ALL your code, so I might have missed something 😃 Your entire first page (confirm.php) is a function to show the form, which you call in the second page but you do not include confirm.php there so you should get an undefined function error, unless there is code missing or something. You will need to include 'confirm.php' in 'edit.php'.

I do seem to see a bit if redundand code in the part you need to finish. You appear to have an else that does nothing, then you check for the value of the submit button which was already checked. At the very end:

THIS:

else
if ($HTTP_GET_VARS["submit"]=="submit")
{
$_SESSION["company"]=$company;
echo"<html><script>
alert (\"$_SESSION["company"]\")
</script></html>";}
?>

Change to:

else{

//they have submitted the form
//this is the part you need to go to work on
//first do any validation, make sure the form is filled out, etc

//then update the database
$sql="UPDATE table_name 
	SET 
	column_name1='$_POST[corresponding_value1]',
	column_name2='$_POST[corresponding_value2]',
	.... and so on....
	WHERE 
	unique_key='$corresponding_value'";
mysql_query($sql);
// repeat for each table you need to update
}
?>

MBK

Thanks,

I am OK with the coding to update my db, you have clarified it thanks.

I am having a bit of trouble though knowing which field I will be using to update the db, I was trying to just output to the screen to verify that the change was happening.

if you look at confirm.php, then all my input boxes have values based on the current session.
when the user views edit.php the values for the text boxes are entered according to their user id etc.

If the user changes the value of an input box and then clicks submit, where does that value get stored, if at all because that is the value I need to update.

Thanks for the help so far, all help appreciated.

MBK

MrAlaska

Since the form is already populated with existing values, the simplest solution is to update ALL the fields when they submit the form whether they have been changed or not. It would be possible to store all the values in an array and compare them to the submitted values looking for a change, but it hardly seems worth the trouble.

You still need to validate all the fields, though, and only update if all the fields pass validation. If something fails do not do the update but display an error message and call showform() again.

MBK

that as may be, which value do I use?

Will it be the session value or will it be the textbox value?

MrAlaska

For updating the database, you would use the texbox values which you are submitting through the form. You would then need to update the session variables to echo the new information.

It brings up some other issues, though. Since you are populating the form with session variables instead of post variables, it means the form would get reset to the original values after a failed update attempt, which could be irritating to your users. You don't want to change their session variables until they have passed validation, so you might want to use the post variables to re-populate the form when they are availabe which would mean some additonal conditional coding. I would also not set the session variables as part of the edit page. Those should be set when the user first logs in, or make that a separate function and call it when you need it, for instance after an update. You also have some HTML issues that need to be fixed, but these are all side issues. Get it functional first, then streamline and fix it.

MBK

OK, the POST variables instead, I am using this script that jmcneese submitted.

print "<form action=\"$PHP_SELF\" method=\"POST\">
<input type=\"text\" name=\"test\" value=\"". 
if (isset($_POST['test']) && !empty($_POST['test'])) { 
    echo $_POST['test']; 
} ."\">
<input type=\"submit\" value=\"submit\">
</form>";

I am getting an error message though, saying unexpected T_IF.
What does this mean?
Is this because the IF is in a table or something??

MrAlaska

You can't run a conditional statement inside of a print line. Try this:

<?php
print "<form action=\"$PHP_SELF\" method=\"POST\">
<input type=\"text\" name=\"test\" value=\"";
if (isset($_POST['test']) && !empty($_POST['test'])) {
    echo $_POST['test'];
}
print "\">
<input type=\"submit\" value=\"submit\">
</form>";
?>

MBK

That works fine MrAlaska,
Thanks very much.