Bug/problem with PHP 4.2.2 or other error??

jwinberg

I'm having trouble with the newest version of PHP (4.2.2).
For example in a page I'm using the following code:
if ($_GET['action'] == "logout") {
//do something
}

But I'm getting an error message that says:
...log_message reports: PHP Notice: Undefined index: action in....

Ealier (other versions of PHP) I have succesfully used the above code, but do
I now have to rewrite the code like this:
if (isset($GET['action']) AND $GET['action'] == "logout") {
//do something
}

Or am I totally wrong?
This was just one example when I'm getting the message "Undefined index" or "
Undefined variable" etc. A lot of code which has previously worked is now
giving me loads of headache since I have to rewrite everything.

Please, I need some help.

roger20

Your new installation may have a different level of error reporting.

See the manual for the function error_reporting()

In any case you need to show all the errors whilst developing so faults in coding like yours become apparent i.e. checking the contents of a variable that doesn't exist.

bealers

yep, that's not an error, NOTICES are warning you about sloppy coding practice usually.

As roger20 says, it's best to be showing these on Dev box anyway

jwinberg

But can these "notices" actually cause the whole PHP engine to crash?? There's a a whole lot of "notices" coming to the log. I was thinking if the system crashes because there are too many "notices". The code I'm using has worked flawlessly on previous versions of PHP and also on the 4.2.2, the web pages do work for a few days just as they should (and then the PHP engine crashes).

What do you think about this, at least I find it a bit weird that the following code:

7: if (!isset($GET['page'])) $page = "startpage";
8: else $page = $GET['page'];

...Gives this error message:

[04/Sep/2002:08:25:41] info ( 6615): for host xxx.xxx.xx.xx trying to GET /2002/index.php, PHP_log_message reports: PHP Notice: Undefined index: page in /www/docs/yyy.yyy.yy/2002/index.php on line 7

Any ideas? Is the code written wrong or is there a problem on the server that has noting to do with PHP, that causes the PHP engine to crash?

roger20

On your development system, make sure php.ini is set with

display_errors = On

Errors and notices (and warnings) will be displayed on screen and it's easier to see errors in your code.

Your example code should not generate a Notice...

if (!isset($_GET['page']))
    $page = "startpage"; 
else
    $page = $_GET['page'];

--
R