Forms and error messages

[tiki]

OK guys. This is probably really simple, but I'm new.
I want to have a form that has reauired fields. If the fields are not filled out a small graphic appears next to the field. Easy stuff right? Ugh. I think I'm way off, but here is my code:

<?php
$form_block="
<form mehtod=post action=$php_self>
<br>
Enter name
<input type=text name=firstName vaule=$firstName>
<br>
Enter email
<input type=text name=email value=$email>
<br>
Enter phone number
<input type=text name=phone value=$phone>
<br>
<input type=hidden name=op value=ds>
<input type=submit value=Submit name=send>
</form>
";
if ($op != "ds") {
echo "$form_block";
} else if ($op == "ds"){
if (($firstName == "")or( $email == "")or( $phone == ""))
{
$Err = "
<form mehtod=post action=$php_self>
Please complete fields with <img src=reddot.gif>
<br>
Enter name
$nameErr = <img src=reddot.gif><input type=text name=firstName vaule=$firstName>
<br>
Enter email
$mailErr = <img src=reddot.gif><input type=text name=email value=$email>
<br>
Enter phone number
$phoneErr = <img src=reddot.gif><input type=text name=phone value=$phone>
<br>
<input type=hidden name=op value=ds>
<input type=submit value=Submit name=send>
</form>
";
$send = "no";
}

if ($send != "no"){
echo "<p>All fields submitted</p>";
} else if ($send == "no") {
	echo "$Err";
	if ($firstName == "") {
	echo "$nameErr";}
	if ($email == "") {
	echo "$emailErr";}
	if ($phone == ""){
	echo "$phoneErr";}
	}
}
?>

[swallace]

Hi tiki,

you seem to have a couple of problems with your code...

1st - <form mehtod=post action=$php_self>
should be method
😉

You have several more spelling mistakes that doesn't help the browser - vaule

You seem to be making things complicated for yourself with if/else statements checking for things that must happen...

eg
if ($op != "ds") {
echo "$form_block";
} else if ($op == "ds"){

If it's not 'ds' then you don't need to check that it is in the else part.

Fix these things then give it a go...

good luck

[br__ken]

n/m , change $php_self to $PHP_SELF.. im not sure if its case sensitive

the error is most likely from the $op var, run

this:
if(!isset($op)){
echo $form_block;
}else{
that other code;
}

instead of:
if($op!="ds")

reason: if $op isnt there (and on first load it wouldnt be since its a form element, then it will give you some error saying it isnt there(or set)

[tiki]

OK. Tried all your suggestions.
The spelling errors solved a minor problem I was having. Duh, thanks!

The form works fine as I had it, but the !isset helped simplify things.

My main problem is that if two fields are blank and one is filled out, it returns with the error message on all of the fields...

To see it in action: www.tikihosting.com/temp/testform2.php

[tiki]

OK. Here's what I ended up with.
If someone wouldn't mind testing it out...I keep getting a stray 1 at the bottom of the error page...driving me nuts I tells ya!

 
<?php
$form_block="
<form method=post action=$PHP_SELF>
<br>
Enter name
 <input type=text name=firstName value=$firstName>
 <br>
 Enter email
 <input type=text name=email value=$email>
 <br>
  Enter phone number
 <input type=text name=phone value=$phone>
 <br>
 <input type=hidden name=op value=ds>
 <input type=submit value=Submit name=send>
 </form>
 ";
 if ($op != "ds") {
 	echo "$form_block";
} else if ($op == "ds"){
	if (($firstName == "")or( $email == "")or( $phone == ""))
	 {
		$Err = 
print "<form method=post action=$PHP_SELF>";
print "Please complete fields with <img src=reddot.gif>";
print "<br>";
print "Enter name";
if ($firstName == "") {
print " <input type=text name=firstName value=$firstName><img src=reddot.gif>";
} else {
print " <input type=text name=firstName value=$firstName>";
};
 print "<br>";
 print "Enter email";
if ($email == "") {
 print " <input type=text name=email value=$email><img src=reddot.gif>";
 } else {
 print " <input type=text name=email value=$email>";
 };
 print "<br>";
 print "Enter phone number";
if ($phone == "") {
 print " <input type=text name=phone value=$phone><img src=reddot.gif>";
 } else {
 print " <input type=text name=phone value=$phone>";
 };
 print "<br>";
 print "<input type=hidden name=op value=ds>";
 print "<input type=submit value=Submit name=send>";
print "</form>";
$send = "no";
};



if ($send != "no"){
echo "<p>Correct</p>";
} else if ($send == "no") {
	echo "$Err";
	echo "$nameErr";
	echo "$emailErr";
	echo "$phoneErr";
	}
}
?>