class error - help!

[gtol_de]

i tried to write a class for easy mysql db access, but something is going wrong and i can't figure out what. so any help would be nice.

the code:

class myMySQL {

var $connection;

function myMySQL () {
    $this->connection = mysql_connect (
        MYSQL_SERVER,
        MYSQL_USER,
        MYSQL_PASSWORD
    ) || die 'fehler';
    return true;
}

function query ($_query) {
    if ($_query != '') {
        $_return = mysql_db_query (
            MYSQL_DB,
            $_query,
            $this->connection
        ) || die 'fehler';
    }
    return $_return;
}

}

that's the class (all constants are defined earlier). now when i try to do the following, an error occurs:

$mysqltest = new myMySQL ();
$return = $mysqltest->query ("SELECT * FROM table_name");
$temp = mysql_fetch_array ($return);

output:

Warning: Supplied argument is not a valid MySQL-Link resource in e:\server\Projects\gtol_classes\mymysql.class.php on line 31

Warning: Supplied argument is not a valid MySQL result resource in e:\server\projects\gtol\test.php on line 16

(the first file contains the class definition, the second is the calling script).

if anyone know what's wrong, please let me know,
thank you

[Frag]

Hmm.. I'm guessing you arn't selecting your database

mysql_select_db("db_name");

Your code doesn't show that you do.

Frag

[gtol_de]

no,

mysql_db_query (MYSQL_DB, $_query, $this->connection)

should use the database specified by the constant MYSQL_DB (as i said, defined earlier in another file).
$_query is a parameter of the function query and $this->connection should be correctly set by the constructor.

i always use this syntax in scripts (without using the class myMySQL) and it works fine.

[tomhath]

Try moving the mysql_connect out of the constructor into a separate method. I've had problems with constructors.

[br__ken]

i dont see anything wrong, except maybe that i didnt see you define MYSQL_SERVER, etc..etc., try this class and see if it works:

class db
{
 var host="host";
 var user="user";
 var pass="pass";
 var db="db";

 function db()
 {
   @mysql_connect($this->host,$this->user,$this->pass);
   @mysql_select_db($this->db);
  }

  function query($qstr)
  {
    return mysql_query($qstr);
   }

}// class end

[gtol_de]

thank you all, but it was another mistake i made:

i forgot () in
($this->connection = mysql_connect (...)) || die "fehler";

(same in the query function)

without ():
$this->connection = mysql_connect (...) || die "fehler";
$this->connection will always be true and not the connection ressource, i think. sorry, it was late yesterday.