Simple insert not working

[kagg]

Hello,

Like all others I am also not able to add records to mysql database. My code is :

<?php
include("required.php");
echo "$id";
$query = "INSERT INTO '$tablename' ('id','product','comment') VALUES ('$id','$product','$comment')";

$connection = mysql_connect($ip, $user, $password);
if (!$connection)
{
	die("Connection with MySQL could not be established");
	return;
           }

else { 
                         echo "connected<br>";
                        $dconnection = mysql_select_db($dataname, $connection);
	$queryres = mysql_query($query);
                        echo "right<br>";
	if ($queryres) 
                             echo "Record added<br><a href='add.htm'>Add More Records</a>";
                       else echo mysql_error();
                          mysql_close($connection);
                         }
?>

Fields in table are: id: varchar(8), product: varchar(50), comment: varchar(50)

I am trying to connect to mysql on remote sever through IP address. I acn connect as I am echoing some alerts after each operation. But not success and can not add records.. it's giving me error page... as

101SKconnected
right
You have an error in your SQL syntax near ''product-list' (id,product,comment) VALUES ('101SK','CP','good')' at line 1

Where am I wrong...😕

[hand]

$query = "INSERT INTO $tablename (id,product,comment) VALUES ('$id','$product','$comment')";

[kagg]

Still can not add records removing single quotes around tablename is giving error like this :

You have an error in your SQL syntax near ''-list' (id,product,comment) VALUES ('101SK','CP','good')' at line 1

my table name is however product-list.

😕

[hand]

It is not allowed to use '-' for a tablename. (I know that this circumstance is described anywhere on mysql.com page, but I can't find it 🙁 )

Why it was possible to create this table, I don't know. Pleas rename it instead of '-' take a '_'

See my test create.

mysql> create table product-list(y char(19));
ERROR 1064: You have an error in your SQL syntax near '-list(y char(19))' at line 1

mysql> create table product_list(y char(19));
Query OK, 0 rows affected (0.03 sec)

mysql>

[hand]

What I found: Some mySQL versions support '-' within a database-, table- or columnname.

: When you want to manipulate a database with a dash in the name, do it with backquotes.

CREATE DATABASE `my-db`;
SELECT * FROM `my-db`;
...

$query = "INSERT INTO `$tablename` (id,product,comment) VALUES ('$id','$product','$comment')";

But I think that, if it is possible, it is better to rename these tables.

[kagg]

Thanks!

I changed the table name.
🙂