Random image problem

[SpasePeepole]

I wrote a simple little random image generator only the problem is the images wont show up in forums when I use the img code on it. Such as using it for a random sig.
Here is the code for you guys to look at and tell me what I should fix :

 
<?php

$pics = array(0 => "1.jpg", 1 => "2.jpg");

$random = rand(0, 1);

echo "<img src=\"/$pics[$random]\" border=\"0\">";

?>

[intenz]

$strHandle = opendir('.');
while($strFile = readdir($strHandle))
{
	if($strFile != '.' && $strFile != '..' && (strrchr($strFile,'.')=='.jpg' || strrchr($strFile,'.')=='.gif'))
	{
		$arrPics[] = $strFile;
	}
}
if(count($arrPics) == 0) die('No pictures');
srand ((double) microtime() * 1000000);
$strRandPic = mt_rand(0,count($arrPics)-1);
echo '<img src="' . $arrPics[$strRandPic] . '">';

[examancer]

i think your problem may be here:

echo "<img src=\"/$pics[$random]\" border=\"0\">";

should be:

echo "<img src=\"/{$pics[$random]}\" border=\"0\">";

when you call a variable in a string, php stops when it find a valid variable, so it would stop at $pics and not see that you are calling an element within that array, so you must surround the variable in brackets so that php knows what you are talking about. Or, my personal fav: don't put variables inside of strings, its dirty! do this:

echo "<img src=\"/". $pics[$random] . "\" border=\"0\">";

[SpasePeepole]

Thank you both for your replies. I will try both of your methods

[Weedpacket]

Hang on; do you mean that you want to use this php script instead of an image - i.e., you want your forum's img src to be this script file ("<img src='random_pic.php'>") so that whenever an image is supposed to be displayed, this script is run?

If that is the case, then you want to send the image file itself, not another HTML <img> tag. For that, see the readfile() function (and also use header() to send a suitable Content-Type - image/gif or image/jpeg depending on taste).

[SpasePeepole]

Yeah thats what I wanted to do. Thanks I'll look into it :d

[SpasePeepole]

Alright I have set the content type at the top as image/jpeg, now I am not sure how to use the readfile function. I put in place of the echo statement :

readfile($final);

$final being $pics[$random]
only it gives me this error :
readfile("") - Inappropriate ioctl for device

[intenz]

Try this...

pic.php

<?
header("Content-type: image/gif");
$strHandle = opendir('.');
while($strFile = readdir($strHandle))
{
    if($strFile != '.' && $strFile != '..' && (strrchr($strFile,'.')=='.jpg' || strrchr($strFile,'.')=='.gif'))
    {
        $arrPics[] = $strFile;
    }
}
if(count($arrPics) == 0) die('No pictures');
srand ((double) microtime() * 1000000);
$strRandPic = mt_rand(0,count($arrPics)-1);
readfile($arrPics[$strRandPic]);
?>

something.html

<img src="pic.php">

Good luck!

[SpasePeepole]

Thanks for your suggestion intenz but I got it working like this

readfile($pics[$random]); 

Thanks all you guys