SQL error eluding me....

jstarkweather

I am getting this error:

Error in query: . You have an error in your SQL syntax near ') VALUES (0, '10', '2002-09-2' at line 40

for this INSERT statement:


        	$column = &$pntable['reviews_column'];
        	$newid = $dbconn->GenId($pntable['reviews']);
        	$result = $dbconn->Execute("INSERT INTO $pntable[reviews] ($column[id],
																	$column[secid],
																	 $column[date],
																	$column[title],
																	 $column[text],
																 $column[reviewby],
																	$column[score],
																	$column[cover],
																	  $column[url],
																$column[url_title],
																	 $column[hits],
																$column[rlanguage],
																   $column[itemid],
																	 $column[msrp],
																	$column[scale],
																  $column[makerid],
																$column[ratename1],
																$column[ratename2],
																$column[ratename3],
															   $column[ratevalue1],
															   $column[ratevalue2],
															   $column[ratevalue3],
																 $column[heading1],
																 $column[heading2],
																 $column[heading3],
																 $column[heading4],
																 $column[section1],
																 $column[section2],
																 $column[section3],
																 $column[section4],
																$column[secimage1],
																$column[secimage2],
																$column[secimage3],
																$column[secimage4],
																$column[imageurl1],
																$column[imageurl2],
																$column[imageurl3],
																$column[imageurl4],
																$column[imgborder],
															 $column[addimagesurl]) VALUES ($newid,
																						  '$secid',
																						   '$date',
																						  '$title',
																						   '$text',
																					   '$reviewby',
																						  '$score',
																						  '$cover',
																							'$url',
																					  '$url_title',
																							   '1',
																					  '$rlanguage',
																						 '$itemid',
																						   '$msrp',
																						  '$scale',
																						'$makerid',
																					  '$ratename1',
																					  '$ratename2',
																					  '$ratename3',
																					 '$ratevalue1',
																					 '$ratevalue2',
																					 '$ratevalue3',
																					   '$heading1',
																					   '$heading2',
																					   '$heading3',
																					   '$heading4',
																					   '$section1',
																					   '$section2',
																				   	   '$section3',
																					   '$section4',
																					  '$secimage1',
																					  '$secimage2',
																					  '$secimage3',
																					  '$secimage4',
																					  '$imageurl1',
																					  '$imageurl2',
																					  '$imageurl3',
																					  '$imageurl4',
																					  '$imgborder',
																				   '$addimagesurl')") or die("Error in query: $result. " .$dbconn->ErrorMsg());

Thanks for any help.

Jim

sfhc

You are missing single quotes around $newid.

sbacelic

btw for those big SQL queries its better to use
INSERT [LOW_PRIORITY | DELAYED] [IGNORE]
[INTO] tbl_name
SET col_name=(expression | DEFAULT), ...
syntax because you know which value is assigned to which field

jstarkweather

I have tried it with single quotes... same error.

Jim

sbacelic

try quoting field names

Lars_Berg

$q = "INSERT INTO $pntable[reviews] ($column[id],
$column[secid],
$column[date],
$column[title],
$column[text],
$column[reviewby],
$column[score],
$column[cover],
$column[url],
$column[url_title],
$column[hits],
$column[rlanguage],
$column[itemid],
$column[msrp],
$column[scale],
$column[makerid],
$column[ratename1],
$column[ratename2],
$column[ratename3],
$column[ratevalue1],
$column[ratevalue2],
$column[ratevalue3],
$column[heading1],
$column[heading2],
$column[heading3],
$column[heading4],
$column[section1],
$column[section2],
$column[section3],
$column[section4],
$column[secimage1],
$column[secimage2],
$column[secimage3],
$column[secimage4],
$column[imageurl1],
$column[imageurl2],
$column[imageurl3],
$column[imageurl4],
$column[imgborder],
$column[addimagesurl]) VALUES ($newid,
'$secid',
'$date',
'$title',
'$text',
'$reviewby',
'$score',
'$cover',
'$url',
'$url_title',
'1',
'$rlanguage',
'$itemid',
'$msrp',
'$scale',
'$makerid',
'$ratename1',
'$ratename2',
'$ratename3',
'$ratevalue1',
'$ratevalue2',
'$ratevalue3',
'$heading1',
'$heading2',
'$heading3',
'$heading4',
'$section1',
'$section2',
'$section3',
'$section4',
'$secimage1',
'$secimage2',
'$secimage3',
'$secimage4',
'$imageurl1',
'$imageurl2',
'$imageurl3',
'$imageurl4',
'$imgborder',
'$addimagesurl')";
echo $q;

and show the result. It is probably that you have a column name that is a reserverd word. Btw, your application would benefit if you normalized the database.

jstarkweather

Lars,
I think you are right as I tried to modify 2 fields already and they came back as reserved (text and date). I don't know a lot about this unfortunately, what do I do to normalize? Should the field names be changed?

Thanks I will try the echo $q.

Jim

jstarkweather

Lars,
Thanks for the $q read-out. That allowed me to find the missing info (which was in an include file for table-field names... I was missing the .addimagesurl field. Doh! I must have looked at that 10 times too.

Thanks everyone for the help.

Jim