Switches and 0

[rillo]

Whenever I am doing switches I always encounters a problem with the value zero when using switches. Look exaple,

switch ($beer_days) {
case ($beer_days>20):
$newprice_beer = $beer_price1;
break;
case ($beer_days=10):
$newprice_beer = $beer_price1.2;
break;
case ($beer_days=0):
$newprice_beer = $beer_price*1.4;
break;

If $beer_days is = 0 it will show the $newprice_beer for case ($beer_days>20): Anyone knows why? Had this problem before and didn´t solve back then either 😛

[TTT]

of course, first case is true --> break

first case:
case ($beer_days>20 && $beer_days != 0):

[TTT]

also there is error:

if 10 --> 1. and 2. are true

when you do this kind of switch you have to put equls to top and and > / < to bottom

case(0);
case(10);
case(>10);
case(<10);

[rillo]

Thank you the last did the trick.

case (>20): <--- Gives me parse error, any ideas?

Rillo

[Weedpacket]

Originally posted by TTT
of course, first case is true --> break

first case:
case ($beer_days>20 && $beer_days != 0):

So 0>20 in your world?

PHP's loose typing caught you out (it caught me out, too). testing ($beer_days) when $beer_days is zero will be false, because 0==false. 0>20 is also false, so that's the case that matches.

When $beer_days is 0 (aka. false), you've got:

switch(false) {
case (false):
$newprice_beer = $beer_price*1;
break;
...

So of course the first case is the one that fires.

One solution would be to test for $beer_days==0 first.

Another would be to use switch($beer_days!==false) instead.

Or rearrange your cases (this also illustrates how switch statements are supposed to be used):

 switch($beer_days) {
case 0: $newprice_beer = $beer_price*1.4;
        break;
case 10: $newprice_beer = $beer_price*1.2;
        break;
default: $newprice_beer = $beer_price*1;
}

You don't say what happens if the number of days is 7 or 14. Are you sure you've thought this through?

[rillo]

Thanks alot, now I am a switch master 😉

This solves my problem, and so you know that was just a very little bit of the switch to illustrate my problem =)

Rillo

[Weedpacket]

Originally posted by rillo
Thank you the last did the trick.

case (>20): <--- Gives me parse error, any ideas?

Rillo

Yah, TTT is talking cobblers.

If you're wanting ranges like that, the clearest (and safest, as you've found) thing to use would be if-elseif-else statements.

if($foo>20)
{...do_bar;
}
elseif($foo==10)
{...do_baz;
}
elseif($foo==0)
{...do_bar;
}
else
{...quietly_panic;
}