A little confused w/ mysql_fetch_array...

Plum-Loco

I'm attempting to convert my users from my old forum to a new phpBB one. I've apparently figured out how to get 1 user in, but the next time it executes the loop it flips out. Just confused on how to use mysql_fetch_array appropriatly...

Here's my code...

	$sql = "SELECT * FROM members";
	$query = mysql_db_query($GLOBALS["database"], $sql) or die(geterrdesc($sql));	

while ($memberinfo = mysql_fetch_array($query, MYSQL_ASSOC)) {
		$sql = "INSERT INTO phpBB_users (user_id, user_active, username, user_password, 
				user_session_time, user_session_page, user_lastvisit, user_regdate, 
				user_level, user_posts, user_timezone, user_style, user_lang, 
				user_dateformat, user_new_privmsg, user_unread_privmsg, 
				user_last_privmsg, user_emailtime, user_viewemail, user_attachsig, 
				user_allowhtml, user_allowbbcode, user_allowsmile, user_allowavatar, 
				user_allow_pm, user_allow_viewonline, user_notify, user_notify_pm, 
				user_popup_pm, user_rank, user_avatar, user_avatar_type, user_email, 
				user_icq, user_website, user_ftp, user_from, user_sig, 
				user_sig_bbcode_uid, user_aim, user_yim, user_msnm, user_occ, 
				user_interests, user_actkey, user_newpasswd)

				VALUES ($user_id, 1, '$memberinfo[username]', '$user_password', '', '', 
				$memberinfo[lastposttime], $memberinfo[register], 0, 
				$memberinfo[post_num], -4.00, 2, 'english', 'D M d, Y g:i a', 0, 0, 0, 
				NULL, 1, $user_attachsig, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 
				'$memberinfo[avatar]', $user_avatar_type, '$memberinfo[email]', 
				'$memberinfo[icq]', '$user_website', '$user_ftp', 
				'$memberinfo[location]', '', '', '$memberinfo[aim]', '', 
				'$memberinfo[msn]', '$memberinfo[occupation]', '', '', '')";

		$query = mysql_db_query($GLOBALS["database"], $sql) or die(geterrdesc($sql));

		echo("$user_id: $memberinfo[username] INSERTED!" );
		echo("<BR>");
		$user_id += 1;
}

Thanks in advance 🙂

Plum-Loco

btw... here's the output

6: AntiIdentity INSERTED!

Warning: mysql_fetch_array(): supplied argument is not a
valid MySQL result resource in test1.php on line 35

evildj

From the manual... http://www.php.net/manual/en/function.mysql-db-query.php

This function has been deprecated since PHP 4.0.6. Do not use this function. Use mysql_select_db() and mysql_query() instead.

Also, you are using the function within the while loop, which is incorrect. You have already queried the database.

bobthedog

Agreed -

Just drop

$query = mysql_db_query($GLOBALS["database"], $sql) or die(geterrdesc($sql));

out of your while loop and it shud work fine.

Plum-Loco

Thanks for the help folks, very much appreciated... here's what ended up working... (for those just reading, both the source and destination tables exist in the same database, I'm sure with some slight editions you could make it so that you can convert from one table to another from seperate databases...)

<?
	// connects to the database
	mysql_connect ('localhost', '***', '***') 
		or die ('I cannot connect to the database. Make sure that mysql is installed and that you are trying to log in as a valid user.'); 
	mysql_select_db ('***') 
		or die ('The database specified in database_name must exist and must be accessible by the user specified in mysql_connect'); 

// queries the source table: members
$query = "SELECT * FROM members ORDER BY `register` ASC LIMIT 0, 1020"; 
$query_result_handle = mysql_query ($query) 
	or die ('The query failed! table_name must be a valid table name that exists in the database specified in mysql_select_db'); 

// variable changes (not really needed for sheer conversion)
$user_id = 1;
$user_id_off = 2;
$user_id += $user_id_off;

// the big loop for each row...
while ($memberinfo = mysql_fetch_array($query_result_handle)) 
{ 
	// more variable changes
	$user_attachsig = ($memberinfo[check_signature] == 'yes') ? 1 : 0;
	$user_avatar_type = ($memberinfo[avatar] == '') ? 0 : 2;
	$user_password = md5($memberinfo[password]);
	$user_website = ($memberinfo[homepage] == 'http://') ? '' : $memberinfo[homepage];
	$user_ftp = ($memberinfo[ftp] == 'ftp://') ? '' : $memberinfo[ftp];

	// INSERT statment (destination table: phpBB_users)
	$sql = "INSERT INTO phpBB_users (user_id, user_active, username, user_password, 
			user_session_time, user_session_page, user_lastvisit, user_regdate, 
			user_level, user_posts, user_timezone, user_style, user_lang, 
			user_dateformat, user_new_privmsg, user_unread_privmsg, 
			user_last_privmsg, user_emailtime, user_viewemail, user_attachsig, 
			user_allowhtml, user_allowbbcode, user_allowsmile, user_allowavatar, 
			user_allow_pm, user_allow_viewonline, user_notify, user_notify_pm, 
			user_popup_pm, user_rank, user_avatar, user_avatar_type, user_email, 
			user_icq, user_website, user_ftp, user_from, user_sig, 
			user_sig_bbcode_uid, user_aim, user_yim, user_msnm, user_occ, 
			user_interests, user_actkey, user_newpasswd)

			VALUES ($user_id, 1, '$memberinfo[username]', '$user_password', '', '', 
			$memberinfo[lastposttime], $memberinfo[register], 0, 
			$memberinfo[post_num], -4.00, 2, 'english', 'D M d, Y g:i a', 0, 0, 0, 
			NULL, 1, $user_attachsig, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 
			'$memberinfo[avatar]', $user_avatar_type, '$memberinfo[email]', 
			'$memberinfo[icq]', '$user_website', '$user_ftp', 
			'$memberinfo[location]', '', '', '$memberinfo[aim]', '', 
			'$memberinfo[msn]', '$memberinfo[occupation]', '', '', '')";

	// implements the INSERT statment
	$query = mysql_query ($sql) or die ('The query failed! table_name must be a valid table name that exists in the database specified in mysql_select_db');

	// more variable changes
	$user_id += 1;

	// displays users inserted into the table (not needed, but comforting)
	echo("$user_id: $memberinfo[username] INSERTED!" );
	echo("<BR>");
}
// shut 'er down!
mysql_close($db);
?>

It may look a little sloppy through this webpage, but when you cut and paste it into a text file it'll be more usefull... Once again thanks!!!