php/mysql...what's wrong?

ef2k_php

$result = mysql_query("INSERT INTO news (date,by,article) VALUES('$date','$name','$entry')");

i can't figure out what's wrong with this!
the variable names are correct, i checked by using echo()
the table row names are correct, too.
can anyone see anything that could be wrong???
thanks!
eric

evildj

At first glance there doesn't appear to be any problems with your statement. I usually set up the query string seperately. Why don't you give the context and the actual error you are getting?

ef2k_php

the php:

<?
$id = "username";

$pass = "password";

$db=mysql_connect("localhost",$id,$pass) or die("Cant connect!");

mysql_select_db("thedb", $db) or die("Cant select DB!");

$sql="INSERT INTO news (date,by,article) VALUES('$date','$name','$entry')";

$result = mysql_query($sql);

if ($result) {echo "Yes!";}
else {echo "No!";}
?>

go to www.captainrerun.com/post.html

thanks for your help!

evildj

Again, you are not showing me anything that seems a problem. Better get used to debugging and smacking yourself in the head for missing obvious things.

The first thing I would do is echo $sql; to see if it looks like I expect it to.

ef2k_php

done. the sql looks fine. i sat up till almost 4AM once because if a missing semicolon, so believe me, i know alll about stupid errors 🙂
this one's really got me stumped, though.

Weedpacket

$result = mysql_query($sql) or die "Failed to insert. MySQL's reason: ".mysql_error();

algis

Please try changing table fields name - date is reserved word I think (and maybe "by" and "article" too - I forgot)

Hope this help

Algis

KoshNaranek

Yepp.. "date" is reserved... "by" and "article" are not... but call the fields like

"creationdate" "postedby" "articletext" and it'll work 😉

By the way... "timestamp" isn't a reserved word.. although "timestamp" is an option to create a field in a table... Hmmmm :rolleyes:

Weedpacket

Originally posted by KoshNaranek
Yepp.. "date" is reserved... "by" and "article" are not... but call the fields like

But hold on; wouldn't MySQL have whinged when asked to create a table with a field named with a reserved word?

KoshNaranek

Hmmmmm...

with phpMyAdmin i can create a table with a field called "date"

CREATE TABLE TEST (
date DATE NOT NULL,
PRIMARY KEY (date)
); works... don't ask me why... maybe a bug?

maybe because "date" is a php-command? who knows? 😕 :rolleyes:

Weedpacket

Originally posted by KoshNaranek
Hmmmmm...

with phpMyAdmin i can create a table with a field called "date"

CREATE TABLE TEST (
date DATE NOT NULL,
PRIMARY KEY (date)
); works... don't ask me why... maybe a bug?

maybe because "date" is a php-command? who knows? 😕 :rolleyes:

Ah, of course - you've called the table date, not date!

ef2k_php

thanks guys for all your help, i finally figured out a solution 🙂
i just changed it to INSERT INTO news VALUES [...]
leaving out the names of the table elements 🙂 i think the problem WAS that i was using date as a name, and didn't think about it being reserved 🙂 but thanks again for all your help guys! look forward to helping people as well as getting help 🙂
thanks,
eric