Session help

r3n

Ok, i have some code within an IF case statement:

$data = mysql_fetch_array($result);
$user_name = $data["user_name"];
$user_id = $data["user_id"];

mysql_query("insert into $admin_statustbl set user_id=$user_id, user_name='$user_name'") or die (mysql_error());  // Record user status

		session_register("user_name"); 	// Register username as global variable
		session_register("user_id");	// Register userid as global variable

		header ("Location: admin.php?action=home");

Could anybody tell me why its returning:

Warning: Cannot send session cookie - headers already sent by (output started at e:\users\uclan\admin\admin-inc.php:40) in e:\users\uclan\admin\security.php on line 42

Warning: Cannot send session cache limiter - headers already sent (output started at e:\users\uclan\admin\admin-inc.php:40) in e:\users\uclan\admin\security.php on line 42

Warning: Cannot add header information - headers already sent by (output started at e:\users\uclan\admin\admin-inc.php:40) in e:\users\uclan\admin\security.php on line 45

Thx

irishprogrammin

get rid of all blank lines in code, that will fix it. the blank lines are seen as output.

(blank lines prior to 'Header' statement)

r3n

Hmm, are you sure? I dont think that would make a diffrence -- i'll chekc out admin-inc.php 🙂

evildj

And you don't have any html code before the php?

And no blank lines before the <?php opening tag?

r3n

I use a PHP session manager with templates. This means that I dont need to code my php into my html 🙂.
This method was developed for teams; so that the designers didnt need to interfear with the programmers work :p.
The problem i'm having is something to do with the session manager.

As i'm not very clear on what the problem is - i'm gona have to hope that someone has experience with Session managers such as "PHP4 MySQL Session Handler" by Ying Zhang.

Its a bit of a long shot, but has anybody seen these kind of errors before when using this session manager?

rroc

You have to note, that the

session_start();

has to be given BEFORE you output ANY HTML-output to the user's browser. This means, that if those templates print some HTML, before they run your PHP script, your session won't be started.

I had a similar problem, so I had to modify my 'template'-code so that it checks the file which it is going to insert into the template if there is any session starts: And after that it prints the template and evaluates the rest of your script.

I hope you have the possibility to modify the template script.

fandelem

Just look at line 40 in e:\users\uclan\admin\admin-inc.php, and you should see what is causing the output error. If not, post lines 35-45 and we'll dissect it.

r3n

line 40 is the end of a function:

	function chksecurity($minlevel)  // Check current user for acceptable security level
	{
		session_start();
		global $user_id, $user_name , $access_level, $admin_statustbl, $REMOTE_ADDR, $HTTP_HOST, $REQUEST_URI;

	// Record user activity into status table
	$query = "insert into $admin_statustbl 
	user_id	=	'$user_id', 
	ip		=	'$REMOTE_ADDR', 
	url		=	'$HTTP_HOST$REQUEST_URI', 
	date	=	now()";

	$result = mysql_query($query) or die(mysql_error());

	if (!session_is_registered("user_id"))
	{
		include_once("../templates/template-inc.php");
		$t = new Template("../templates");

		$t->set_file('template','sec-login.ihtml');

		$t->set_var('siteName',$siteName);
		$t->set_var('pageTitle',$pageTitle);
		$t->set_var('AdminPanelVer',$AdminPanelVer);
		$t->set_var('error','<p class="mainBodyTitles"><font color="#FF0000">You need to be logged in to access this feature.</font></p>');

		$t->pparse('Output', 'template');
		exit;
	}
}

This has session_start() in it, so why isnt it working?

frymaster

before any headers are sent there cannot be any output, even blank space ahead of yr <?php tag.... this automatically sends a text/html header which is bad. bad. bad.
you can overcome this with output buffering (http://us2.php.net/manual/en/ref.outcontrol.php). this is not a very elegant solution, but it will work.