"set" type not working correctly

[Eep__]

How would I take a database table string "1,2" from a MySQL table "set" column type and separate it into individual numbers ("1","2") to be passed as the same field ("genreID") to be used to create checked checkboxes?

Here's what I have so far:

$sql = "SELECT
	*
	FROM
	compare,games,genres,publisher,engine
	WHERE id=$id
	AND compare.gameID=games.gameID
	AND compare.genreID=genres.genreID
	AND compare.publisherID=publisher.publisherID
	AND compare.engineID=engine.engineID";

  $result = mysql_query($sql);
  $row = mysql_fetch_array($result);

  $id = $row["id"];
  $game = $row["game"];
  $circa = $row["circa"];
  $genreID = $row["genreID"];
    $genreID = explode(",",$genreID);
//    foreach ($genreID as $genreID) { $genreID=$genreID; }
  $genre = $row["genre"];
  $publisherID = $row["publisherID"];
  $publisher = $row["publisher"];
  $engineID = $row["engineID"];
  $developer = $row["developer"];

Then the HTML code:

<input type=text name=genre[] maxlength=40 value=<?=$genreID?>><br>
<input type=checkbox name=genre[] value=action <?if($genreID=='1'){echo checked;}?>>action<br>
<input type=checkbox name=genre[] value=adventure <?if($genreID=='2'){echo checked;}?>>adventure<br>
<input type=checkbox name=genre[] value=role-playing <?if($genreID=='3'){echo checked;}?>>role-playing (RPG)
<br>
<input type=checkbox name=genre[] value=simulation <?if($genreID=='4'){echo checked;}?>>simulation:
	<dd><input type=checkbox name=genre[]>city/empire-building
	<dd><input type=checkbox name=genre[]>driving/racing/riding
<br>
<input type=checkbox name=genre[] value=strategy <?if($genreID=='5'){echo checked;}?>>strategy
	(<input type=checkbox name=genre[]>real-time
	<input type=checkbox name=genre[]>turn-based)

But what happens is $genreID comes out to "3" and so "role-playing" is checked when I want "action" ("1") and "adventure" ("2") checked. How do I do that?

[Vex]

You're exploding the $genreID back into itself, so then it becomes an array...

So you need to access it as such...

<input type=checkbox name=genre[] value=action <?if([b]$genreID[0][/b]=='1'){echo checked;}?>>action<br>
<input type=checkbox name=genre[] value=adventure <?if([b]$genreID[1][/b]=='2'){echo checked;}?>>adventure<br>
<input type=checkbox name=genre[] value=role-playing <?if([b]$genreID[2][/b]=='3'){echo checked;}?>>role-playing (RPG)

See if that does it. Maybe...

[Eep__]

Still doesn't work. $genreID is still coming up with a value of "3" instead of "1,2"...

[Vex]

Try printing the values in the array, see what is exactly in there...

Or try changing the code to...

if (trim($genreID[0]) =='1' )

There maybe leading/trailing spaces...

[Eep__]

When I print $genreID before and after the explode(), it has a value of "3". The explode() doesn't seem to be working or else the "mysql_query($sql);" and/or "$row = mysql_fetch_array($result);" commands aren't working correctly or something. I just don't know...what can I do?

[Vex]

Okay, try these things...

As you're assigning variables the values of the row columns, add

echo $row["genreID"];

So we can see what the DB is giving us.

Then, use this to assign the values to $genreID..

$genreID = explode( ",", $row["genreID"]);

echo "<BR>".$genreID[0];
echo "<BR>".$genreID[1];
echo "<BR>".$genreID[2];
echo "<BR>".$genreID[3];

That will let us see what explode has given us...

Then we can fix the other code.... 🙂

(Be quick I need sleep.. )

[Eep__]

I did a "print_r($row);" but it came up with:

[4] => 1,2 [genreID] => 3

Why is it changing (adding?) "1,2" into "3"?

Perhaps because of "AND compare.genreID=genres.genreID" in the query is somehow equating "1,2" in compare.genreID with "3" in genres.genreID? I just don't understand...I thought the query was to just link the compare.genreID to genres.genreID and not do any conversion or whatever? :/

[Vex]

Ahhh....

Change your code from ....

$row_=_mysql_fetch_array($result);

to

$row_=_mysql_fetch_assoc ($result);

mysql_fetch_array brings back an enumerated array...

mysql_fetch_assoc brings back an associative array... Which is how you're accessing the $row array...

[Eep__]

According to http://www.php.net/manual/en/function.mysql-fetch-array.php, "mysql_fetch_array -- Fetch a result row as an associative array, a numeric array, or both." so why would I have to explicitly use mysql_fetch_assoc() if mysql_fetch_array() can do associative arrays too?

[Vex]

Oh, mysql_fetch_array brings back an array with both numeric and associative indices...

BUT you accessing a number of tables, and using * more than one table has the genreID field in it, accessing the array with "genreID" will give you the value of the last occurance of the genreID column.... Which will be from the last table.....

[Eep__]

OK, so can I just do

$genreID = $row["compare.genreID"];

instead of

$genreID = $row["genreID"];

and keep the normal array call in case other functions don't work because they would be associative?

[Vex]

The best way to fix it (and a good habit to get into), is to specify each of the columns you want in the SELECT part of the query, and then access the $row array either with the column number or the column name (remembering to alias an duplicate columns in the SELECT statement)..

That should fix it...

EDIT: Yes, what you suggest should/might fix it also... 🙂

EDIT x 2: Actually, maybe not... As what you printed out from the array earlier suggests that you just get the column and not the table as well....

[Vex]

Anyway, hopefully I've given you enough hints to get it sorted...

I need bed...

Night.. 🙂

[Eep__]

Well, I'm still confused about the SELECT stuff but thanks for your help regardless--I'll have to dork around with it some more.

I tried the mysql_fetch_assoc() as you suggested but genreID still comes out "3". :/

[Eep__]

OK, like you suggested, I just changed the SELECT query to only choose compare.genreID instead of also genres.genreID. Thanks for your help!

Any more suggestions? 🙂