Question on Variables

[Admin32]

Hi everyone,

I need to get some more information on a sugestion by a friend in regarding to php variables when using them to create a menu.

Here is part index.php:
------------------- START-----------
<?php
if ($c != "") {
include("".$c);
} else {
include("home.php");
}

           ?>

---------------END--------------------
Now, I use the following structure to pass values to the variable and get the requested page :

http://www.mysite.com/index.php?c=info.php

This will make the info.php page come up.

What I have been suggested is this :

"in the file u are processing this variable 'c'
ensure that the value of 'c' has an extension .php . OR use some numbering scheme like
switch(c)
case 1
this page..
etc."

Can someone please explain what he means and give me a simple example to understand how I would need to modify my files and links to make his suggestion work ??

Thanking you in advanced.

[jeremuck]

Why are you trying to change it?
Is it broken?

Don't try to fix something that works.

the switch case:

 

$includeFile = "";

switch(c)
{
case 'info':
$includeFile = "myFile.php";
break;

case 'stats':
$includeFile = "myOtherFile.php";

break;

case 'personal':
$includeFile = "myPFile.php";
break;

default:
$includeFile = "home.php";
break;
}

include_once($includeFile);

however, I like the system you have better.
The above is useful if the page names are not the same as your variable names. But if the variable is the same as your page name, just include it. And yeah, make sure it has the right file extension.

$includeFile = $c . ".php";

include_once($includeFile);

My advice is that if it works, don't fix it.

[roger20]

The problem with your existing code...

<?php 
if ($c != "") { 
include("".$c); 
} else { 
include("home.php"); 
} 

?> 

... is that someone could change the url parameter and include any file they wish, and the contents would display in the browser.

--
R