Validate E-Mail

jeffgman

I have a form where users can signup to a few different mailing lists we offer. I would like to make sure the e-mail address they enter is in a valid form. The form asks for Name, E-Mail, and a second E-Mail field for verification that they entered it correctly. I want this validation to take place when they select the "Subscribe" button. So, I was thinking of an onClick setting. I have created two functions to accomplish this. This is where I am lost. Not sure if I am doing any of this correctly. Here are the two fuctions.

function check_email ($str) {
	// Returns 1 if a valid email, 0 if not

	if (ereg ("^.+@.+\..+$", $str)) {
		return 1;
	} else {
		return 0;
	}
}

function js_alert($msg) {
	// create a JavaScript alert using $msg

	if ($msg == "") return;

	echo (
		"\n<SCRIPT LANGUAGE='JavaScript'>\n" .
		" <!-- \n" .
		" alert (\"$msg\");\n" .
		" // --> \n" .
		"</SCRIPT>\n"
	);
}

function check_email2 ($str) {
if (check_email ($email) == 0 ) {
js_alert ("Please enter a valid email address in the \"Email Address\" and \"Verify Email Address\" boxes");
}

if ($email != $vemail) {
js_alert ("Please verify you have entered the correct email address in the \"Email Address\" and \"Verify Email Address\" boxes");
}
}

And, I have a javascript function to display an error message. Are these functions correct? If so, what do I enter in the onClick field for the form? Or, is there a better way to do this? Once the form is entered, and they hit subscribe, it goes to another page which actually does the mailing of the subscribe mails. Then, it will come back to this original page in a different section confirming the mailings.

Thanks for any help you can offer me.

Jeff

matto

you are mixing things up here.

if you want php to include error messages (javascript or not) regarding previously entered form data, you have to submit the page first (otherwise no php code gets executed). therefore, a normal click on "submit" is sufficient, you don't have to use onClick.

in my opinion, I would construct the script as a form page that reloads itself on submit (<form action=$PHP_SELF>). In the beginning of the script, if the submit button (e.g. $ok) is set, the script jumps into the validating/processing section. collect errors in a string.

then do the processing (i.e., mail the user data) only if the error string is empty. when this is done, you can header() to another page on your site.

if there were errors, the form is re-displayed and should contain the previously entered data so the user can correct it. display the error string, too.

jeffgman

Okay, I think I have it now. But, one more question. You say I should reload the page on submit by using $PHP_SELF and checking for the submit is okay or not. And, if submit is okay, jump to the mailing/validation section. How do I jump to the mailing/validation section of the script?

Thanks

jeffgman

Okay, I have created a new page. But, seem to have a problem with the page when the addresses either do not agree, or the address is not in the proper format. Here is a copy of the code. Can somebody look it over and tell me if they find where I am messed up?

Thanks,
Jeff

I have the following PHP page, but have some problems with it. Can somebody look it over and tell me where I can refine it? It appears to work fine if the addresses match. But, if the address is not correct, or they enter in two different addresses, the page dies.

Thanks,
Jeff

p.s. I am attaching the file because it is too big.