Searching the databse

mysql_query

I have a simple db search and print result code. I get a parse error on the first line of the display.

print "<td>$ligne->id</td>";

There. Can someone tell me what the problem is? Here's the complete code.

<html>
<head>
<title>Untitled</title>
</head>
<body>
<table align="center" cellspacing="0" cellpadding="0" border="1" width="80%">
<tr>
<td bgcolor="black"><font color="white">Route ID</td>
<td bgcolor="black"><font color="white">Origin</td>
<td bgcolor="black"><font color="white">Destination</td>
<td bgcolor="black"><font color="white">Estimated Completion Time</td>
</tr>
<?php
$db = mysql_connect("localhost", "thawowi", "phoi") or die ("could not connecto to db");
mysql_select_db("dbthawowi_0") or die ("could not select database");
$request="SELECT * FROM routes WHERE origin='$string'";
$result="mysql_query($request, $db);
while ($ligne = mysql_fetch_object ($result)) 
{
    print "<td>$ligne->id</td>";
    print "<td>$ligne->origin</td>";
    print "<td>$ligne->destination</td>";
    print "<td>$ligne->est_time</td>";
    print "</tr>";
}
mysql_free_result ($result);
?>
</body>
</html>

Thanks.

Query.

jerdo

Where do you set the $string variable found in your sql query? If that is null you will get an error.

PHPdev

you can always do a "or die(mysql_error()); after your mysql_query() that way during testing you can see if there is an error in your query.

as jerdo said before where to you set $string...

PHPdev

daveyboy

have you tried:

echo "<td>" . $ligne->id . "</td>";

I don't know if this will make a difference, but it makes it easier to read. Make sure that the keys really exist and:

$db = mysql_connect("localhost", "thawowi", "neptun")

I hope this isn't the real password😉

mysql_query

No, it's not the real password, I changed it. Man, my spelling sucks.

Anyway, '$string' comes from an HTML form I had before. Any more ideas?

PHPdev

Not sure if this is in your previous form or not, but I hope that you are doing some error handeling to make sure there is something in $string... also you can always use a die() at any point to print out your variables and such.

Something else is to try useing $_POST["string"] or $HTTP_POST_VARS["string"], showing you what is in the string...

Finally try and do a die($request) just after the statement is created so that you can manually run in at in mysql.

I also notice you have a " infront of mysql_query just after the =, this should create a parse error... not sure if this is just a typo when the code was transfered over...

Let me know if this helps...

PHPdev

mysql_query

I removed the " from after mysql_query, but I still get a parse error. No matter what I do, I get a parse error on line 23. This is the new code:

<html>
<head>
<title>Untitled</title>
</head>
<body>
<table align="center" cellspacing="0" cellpadding="0" border="1" width="80%">
<tr>
<td bgcolor="black"><font color="white">Route ID</td>
<td bgcolor="black"><font color="white">Origin</td>
<td bgcolor="black"><font color="white">Destination</td>
<td bgcolor="black"><font color="white">Estimated Completion Time</td>
</tr>
<?php
$db = mysql_connect("localhost", "thawowi", "password") or die ("could not connecto to db");
mysql_select_db("dbthawowi_0") or die ("could not select database");
$request="SELECT * FROM routes WHERE origin='$string'";
$result=mysql_query($request, $db) or die (mysql_error());
while ($ligne = mysql_fetch_object ($result)) 
{
    print "<tr>"
    print "<td>$ligne->id</td>";
    print "<td>$ligne->origin</td>";
    print "<td>$ligne->destination</td>";
    print "<td>$ligne->est_time</td>";
    print "</tr>";
}
mysql_free_result ($result);
?>
</body>
</html>

PHPdev

You are missing a ";" after your first print statement...

I think the parse error should tell you what it is looking for... if it says ')' on line XX then look about that line... if it is a ";" then look above that point...

Sorry in my previous post I did not remember that you were getting a parse error... The die() technique will not help with that but rather when code is running...

Thanks

PHPdev

mysql_query

Thanks PHPdev, I got it working. The ";" was the problem.

Another question. Say I want to search bot the "origin" field and the "destination" fileld. Is there and "OR" coomand? Something like

$request="SELECT * FROM routes WHERE origin OR destination='$string'";

What would be the correct syntax?

Thanks.

PHPdev

You probably want to do...

$request="SELECT * FROM routes WHERE origin = '$string' AND destination='$string'";

PHPdev

You probably want to do something like this...

$request="SELECT * FROM routes WHERE origin = '$string' AND destination='$string'";

You can download the mysql manual which has SQL syntax from http://www.mysql.com then look under documentation

mysql_query

No sir.

"AND" doesn't work. I need "or", as in, if one of them is '$string" then display the result, not if both are $string.

I will take a look at the manual, thanks.

PHPdev

Sorry, my bad... It was kind of late and I must not have been thinking clearly... but there certainly is an OR. Just replace where I put AND, and it should work...

Thanks

PHPdev

mysql_query

Thank you very much, that works.

One final question about this script. If the query does not return any rows, how can I tell that to the user? Something with an if statement.

Thanks.

PHPdev

Assuming from your name, you are running a mysql database... then I generally

$rs = mysql_query("sql here");

if (mysql_num_rows($rs) == 0) (
echo "no rows returned";
} else {
echo mysql_num_rows($rs)." rows returned";
}

I think the function you are looking for is mysql_num_rows... There are several handy functions in the mysql area you may take a look at http://www.php.net/manual/en/ref.mysql.php

PHPdev

mysql_query

THank you very much for all your help.

My script is now finished.

Good luck to you, sir.

Query.