if and else troubles

darknuke

i am devloping a script where i have checkboxes for options, and when i make options, i use the if elseif and else commands, but there must be an easier way to this:

theres about 40 branches of if and elses what can i do to make it smaller 🙁

my problem possiblities:

E = Error
Y = Yes
N = No

first i choose Y and theres a possibility of E
(2)
first i choose N
(3)
from Y i choose another Y and i could get a E 1
(5)
instead of Y i chose N instead
(6)
from that N i chose Y with a possiblity of E
(8)
i instead take N which then also ends my branch-offs
(10)
at 1 i took another Y which has a possibility of E and also ends my branch-offs
(13)

see what i mean 🙁 it is SOO confusing 🙁

junkie_doodle

if it's not a top secret code, it'd help people if you post the if..else..elseif code for people to find out how to re-write it in a better form..

darknuke

well this is the start of it

if (($filename_type=="image/bmp") || ($filename_type=="application/x-zip-compressed") || ($filename_type=="image/x-png") || ($filename_type=="audio/mid") || ($filename_type=="audio/wav")){

if ($enableallowedurl == "checked") {
if ($HTTP_REFERER == "$allowedurl") {
if ($enabledmaxdirsize == "checked") {
if ($spaceused < "$maxdirsize") {
if ($enabledmaxfilesize == "checked") {
if ($maxfilesize < "$maxfilesize") {
uploadfile();
} else {
print "$pagelooks$fontformat$maxfilesizeerror";
}

} else {
*doesnt use max file sizes
}
} else {
print "$pagelooks$fontformat$uploaddirfull";
}
} else {
if ($enabledmaxdirsize == "checked") {
if ($spaceused < "$maxdirsize") {
uploaddir();
} else {
print "$pagelooks$fontformat$uploaddirfull";
}
} else (
*doesnt use max dir
}



elseif ($enabledmaxdirsize == "checked") {
if ($spaceused < "$maxdirsize") {
elseif ($enabledmaxfilesize == "checked") {
if ($maxfilesize < "$maxfilesize") {
} else {

} else {
$pagelooks$fontformat$cantupload
}

} else { *END ENABLED URL CASE*
}

darknuke

are for comments that ill later delete

Weedpacket

Well, I don't understand your description that much, and your code is awfully hard to read (partly because there are more { in it than }). My preferred style would see this code written more like:

if ($enableallowedurl == "checked")
{	if ($HTTP_REFERER == "$allowedurl")
	{	if ($enabledmaxdirsize == "checked")
		{	if ($spaceused < "$maxdirsize")
			{	if ($enabledmaxfilesize == "checked")
				{	if ($maxfilesize < "$maxfilesize")
					{	uploadfile();
					}
					else
					{	print "$pagelooks$fontformat$maxfilesizeerror";
					}
				}
				else
				{	//doesnt use max file sizes
				}

One of the things that makes it look incomplete is that part reads:

if($enabledmaxdirsize == 'checked')
{	//stuff
}
else
{	if($enabledmaxdirsize == 'checked')
	{	//more stuff
	}
}

It's fairly obvious that "more stuff" will never happen. A few lines later is

else
(	//doesnt use max dir
}
elseif ($enabledmaxdirsize == "checked")
{	if ($spaceused < "$maxdirsize")
	{	elseif ($enabledmaxfilesize == "checked")

In which (a) the $enabledmaxdirsize test is still automatically false and (b) syntactically dodgy. If you're going to test $enabledmaxsize so often, why not do so early on in the piece and get it out of the way once and for all?

It also sounds as if many bits of this should be farmed out to functions - each dealing with one major branch (returning true or with results if they went ahead or false if their own tests failed).