help with function for betting script

[martincrumlish]

Hi,

I need a function to do the following for a betting calculator I am putting together.

In the simplest form, I am calculating a "double" bet which is best explained like so:
we have 2 bets and 1 stake:

$total1 = $odds1 $stake + $stake;
$total = $total1 $odds2 + $total1;

What I need to do is add a form field for a user to say if a bet was a winner or not. (I have the form field already). If the bet is a winner it will be evaluated, if not it wont. The problem i am having is when calculating a multiple bet like the one above. How can I say

IF bet1 is a WINNER
...calculate $total1 using $stake
IF bet2 is a WINNER
...calculate using $total1 as $stake

(if the first bet isnt a winner, there will be no $total1 and the stake used should then be the original $stake.)

I am not too sure if I am explaining this correctly.

I think I am probably making a really innefficient use of code as well due to the amount of repeating elements but I didnt have time to work it all out with functions etc so I went for the messier approach.

This will be used for different bets so it would be better to have a function for this which will return the result

Regards,
Martin

[daveyboy]

...you want something like this:

$stake = $_GET[ 'stake' ]; // or $stake = mysql_fetch_row( $res )[0] or whatever
$winnings = 0;
if ( $won_races[ 'race1' ] == 1 ) {
    // assuming array of races where 1 = won, 0 = lost
    $winnings = $stake + ( $odds['race1'] * $stake );
}
if ( $won_races[ 'race2' ] == 1 ) {
    $winnings += $odds['race2'] * $stake; 
}
if ( $winnings == 0 ) {
    echo "You lose.";
} else {
    printf( "You have won $%.02f", $winnings ); 
}

[martincrumlish]

Well, heres a snippet of what I have at the moment:

Form page:

<form method="post" action="calc.php">
<table align="left" class="inputtable">
<tr>
<td align="left" colspan="2" class="title">
<b>Double</b>
<tr>
<td align="left" class="oddstext">
Odds 1:
</td>
<td align="left" class="oddsform">
<INPUT TYPE="text" class="input1" NAME="odds1" SIZE=4><select name="status1">
<option>win</option><option>lose</option>
</select>
</td>
</tr>
<tr>
<td align="left" class="oddstext">
Odds 2: 
</td>
<td align="left" class="oddsform">
<INPUT TYPE="text" class="input1" NAME="odds2" SIZE=4><select name="status2">
<option>win</option><option>lose</option>
</select>
</td>
</tr>
<tr>
<td align="left" class="staketext">
Stake: 
</td>
<td align="left" class="stakeform">
<INPUT TYPE="text" class="input1" NAME="stake" SIZE=4>
</td>
</tr>

here is a snippet of the calculation code which is added as an include file at the top of calc.php

if($calc == "double")
	{
	if($status1 == "win")
		{
		$total1 = $odds1 * $stake + $stake;
		}
		else{
			$total1 = 1;
		}
	if($status2 == "win")
		{
		$total = $total1 * $odds2 + $total1;
		}
		else{
		$total = $total1;
		}
	}

At the moment, this works if I set bet 1 to win and bet 2 to win. i enter odds 1 as 2/1, odds 2 as 2/1 an stake as 1...that returns 9 which is correct.
If bet 1 is a loss and bet 2 is a win (or vice versa)(at 2/1 with a stake of 1) then it should return 3.

If both bets are a loss then it should return 0 but with the code I have it returns 1.

The reason i need to get this spot on and preferrably in a function is because I have to recreate it for all types of bets with up to 8 selections. As you can imagine, this could lead to very messy/complicated code.

Any help is appreciated.

Cheers,
Martin

[daveyboy]

You set $total1 = 1 if bet 1 is not win. Therefore your winnings will be 1, not 0, as $total = $total1.

if($calc == "double")  {
    $total = 0;
    if($status1 == "win")  {
        $total += ($odds1 * $stake) + $stake;
    } 
    if($status2 == "win" && $total != 0 ) {
        $total += ($total * $odds2) + $total;
    }
} 

should do the trick. Or should you be able to bet on race 2 alone?

[daveyboy]

i misunderstood the bet 🙂 hang on a tick...

 
if($calc == "double")  {
	$total = 0;
	if($status1 == "win")  {
        $total += ($odds1 * $stake) + $stake;
	} 
    if($status2 == "win" ) {
		if ( $total == 0 ) {
			$multiplier  = 1;
		} else {
			$multiplier = $total;
		}
		$total += $multiplier * $odds2;
	}
}

Does that help? I think I understand what you want, now.

[martincrumlish]

Thanks for the reply,

I'm afraid this isnt returning the correct results though.

If I set both odds to 2/1 and the stake to 1 then it is returning 12 when the real return should be 9.

If I set 1 to lose and 2 to win it returns 2 when it should return 3.
If I set 1 to win and 2 to lose it returns 3 which is correct and if both are set to lose it returns 0, which is also correct.

By the way, what does += do?

[daveyboy]

I changed the code a bit:
It did read:
$total += ( $multiplier * $odds2 ) + $total;

$total +=
is short for $total = $total +
so the last $total had to go. I'll wager you still have it. Sorry - copy it again - I fixed the one above.

[daveyboy]

I changed the code a bit:
It did read:
$total += ( $multiplier * $odds2 ) + $total;

$total +=
is short for $total = $total +
so the last $total had to go. I'll wager you still have it. Sorry - copy it again - I fixed the one above.

[martincrumlish]

Sorry, its still returning 2 for bet1: 2/1, bet2: 2/1 stake 1 when i set bet1 to lose and bet2 to win.

[martincrumlish]

I got it returning the correct results now 🙂

if($calc == "double")  {
    $total = 0;
    if($status1 == "win")  {
        $total += ($odds1 * $stake) + $stake;
    } 
    if($status2 == "win" ) {
        if ( $total == 0 ) {
            $multiplier  = $stake;
        } else {
            $multiplier = $total;
        }
        $total = ($odds2 * $multiplier) + $multiplier;
    }
}

Thanks for your help so far 🙂

Maybe you could tackle this problem.....how would I implement this (which is basically code to ignore bets that are set to "lose") if I have an 8 selection (i.e. 8 different sets of odds where the result of each "odds * stake + stake" becomes the stake for the next bet.

[daveyboy]

Now I see how the bet is supposed to work. not a gambling man, I'm afraid.

 
function winnings( $odds, $stake, $total = 0 )
{
	if ( $total == 0 ) {
		$multiplier = $stake;
	} else {
		$multiplier = $total;
	}
	return ( $multiplier * $odds ) + $multiplier;
}

// set this stuff from the POST data
$odds = array( 2, 4, 10, 25 ); // the odds. race 1 = $odds[0] etc.
$bets = array( 1, 0, 1, 1); // 1 = win 0 = lose. race 1 = $bets[0] etc.
$stake = 20;

$total = 0;
for( $x = 0; $x < sizeof( $bets ); $x++ ) {
	if ( $bets[$x] == 1 ) {
		$total = winnings( $odds[$x], $stake, $total );
	}
}
printf( "You have won \$%.02f", $total );

This should be close to what you want.

[martincrumlish]

I'm not really a gambling man either but this project requires that i learn all about it 🙂

Well, the code you just gave me worked perfectly. I tested it against the code I already have and it matched the return.

So, how would I put the values entered in my form fileds into the array, do i need to declare it first?

Here is the code I have at the moment (before adding your new function)

I havent really worked with arrays etc other than DB result arrays so i am not too sure how to integrate it.

<?
if($submit)
{

if($calc == "double")  {
    $total = 0;
    if($status1 == "win")  {
        $total += ($odds1 * $stake) + $stake;
    } 
    if($status2 == "win" ) {
        if ( $total == 0 ) {
            $multiplier  = $stake;
        } else {
            $multiplier = $total;
        }
        $total = ($odds2 * $multiplier) + $multiplier;
    }
}

}
?>
<html>
<body>
<a href="<?$PHP_SELF?>?bet=double">Click here</a>
<FORM METHOD="post" ACTION="<?$PHP_SELF?>">
<input TYPE="hidden" NAME="calc" VALUE="<?=$bet?>">
<? if($bet == "double")
{
?>
<table align="left" class="inputtable">
<tr>
<td align="left" colspan="2" class="title">
<b>Double</b>
<tr>
<td align="left" class="oddstext">
Odds 1:
</td>
<td align="left" class="oddsform">
<INPUT TYPE="text" class="input1" NAME="odds1" SIZE=4>
<select name="status1">
<option>win</option>
<option>lose</option>
</select>
</td>
</tr>
<tr>
<td align="left" class="oddstext">
Odds 2: 
</td>
<td align="left" class="oddsform">
<INPUT TYPE="text" class="input1" NAME="odds2" SIZE=4><select name="status2">
<option>win</option><option>lose</option>
</select>
</td>
</tr>
<tr>
<td align="left" class="staketext">
Stake: 
</td>
<td align="left" class="stakeform">
<INPUT TYPE="text" class="input1" NAME="stake" SIZE=4>
</td>
</tr>
<?
}
?>
<?
if($bet)
{
?>
<tr>
<td align="left">
<INPUT TYPE="submit" NAME="submit" VALUE="Calculate">
</td>
<?
}
?>
</FORM>
<? if($submit)
{
?>
<table>
<tr>
<td colspan="2">
<b>Result</b><p>
Here are the details of your bet with the return at the bottom.<p>
</td>
</tr>
</table>
<?
	}
if($calc == "double")
	{
?>
<table class="resultstable">
<tr>
<td align="left" class="price">
<b>Price 1</b>
</td>
<td align="left" class="price2">
<?=$odds1?>
</td>
</tr>
<tr>
<td align="left" class="price">
<b>Price 2</b>
</td>
<td align="left" class="price2">
<?=$odds2?>
</td>
</tr>
<tr>
<td class="stake">
<b>Stake:</b>
</td>
<td class="stake2">
€<?=$stake?>
</td>
</tr>
<tr>
<td>
<?
printf("Return: <font color=blue>€<b>%.2f", $total . "</b></font>");
?>
</td>
</tr>
</table>
<?
	}
?>

Thanks again for your help.

[daveyboy]

$bets = array();
$odds = array();
$stake = $_POST[ 'stake' ];

// fill the arrays from POST data
for ( $a = 1; $a < sizeof( $_POST ); $a++ ) {
	if ( $_POST[ "status$a" ] == "win" ) {
		$bets[$a] = 1;
		$odds[$a] = $_POST[ "odds$a" ];
	} else {
		$bets[$a] = 0;
		$odds[$a] = 0;
	}
}

function winnings( $odds, $stake, $total = 0 )
{
	if ( $total == 0 ) {
		$multiplier = $stake;
	} else {
		$multiplier = $total;
	}
	return ( $multiplier * $odds ) + $multiplier;
}
if ( $calc == "double" ) {
	$total = 0;
	echo "<table>";
	for( $x = 1; $x <= sizeof( $bets ); $x++ ) {
		if ( $bets[$x] == 1 ) {
echo "<tr><td>Price $x</td></tr><tr><td>Odds ". $odds[ $x ] ."/ 1</td></tr>";		
	$total = winnings( $odds[$x], $stake, $total );
		}
	}
	printf( "<tr><td>You have won \$%.02f</td></tr>", $total );
	echo "</table>";
}

Pretty rough and ready, but in the right direction. Try to use for loops to generate your HTML and parse the results as often as possible - less typing innit. You might want to write a function like print_row( $raceno, $odds ) or something, so you don't have to type the same stuff 8 times.

[martincrumlish]

Hi,

Sorry, I cant get this working (doh)

I made a page called xtest.html and put all your code in x.php.

here is xtest.html:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
<HEAD>
<TITLE> New Document </TITLE>
<META NAME="Generator" CONTENT="EditPlus">
<META NAME="Author" CONTENT="">
<META NAME="Keywords" CONTENT="">
<META NAME="Description" CONTENT="">
</HEAD>

<BODY>
<form method="post" action="x.php">
<input type="hidden" name="calc" value="double">
<table align="left" class="inputtable">
<tr>
<td align="left" colspan="2" class="title">
<b>Double</b>
<tr>
<td align="left" class="oddstext">
Odds 1:
</td>
<td align="left" class="oddsform">
<INPUT TYPE="text" class="input1" NAME="odds1" SIZE=4>
<select name="status1">
<option>win</option>
<option>lose</option>
</select>
</td>
</tr>
<tr>
<td align="left" class="oddstext">
Odds 2: 
</td>
<td align="left" class="oddsform">
<INPUT TYPE="text" class="input1" NAME="odds2" SIZE=4><select name="status2">
<option>win</option><option>lose</option>
</select>
</td>
</tr>
<tr>
<td align="left" class="staketext">
Stake: 
</td>
<td align="left" class="stakeform">
<INPUT TYPE="text" class="input1" NAME="stake" SIZE=4><input type="submit" name="submit" value="submit">
</td>
</tr>
</table>
</form>
</BODY>
</HTML>

What am I missing?

I tied echoing stuff in your code to see what was happening and it just echoed "Array" when I echoed bets etc so I guess the values aren't getting inserted into the array.

[daveyboy]

if you use 'echo( $array )' it will only print 'Array'. Use 'print_r( $array )'.

Here are the two files I've been working with - they work fine:

calc.html

 
<html>
<body>
<form method="post" action="calc.php">
<table align="left" class="inputtable">
<tr>
<td align="left" colspan="2" class="title">
<b>Double</b>
<tr>
<td align="left" class="oddstext">
Odds 1:
</td>
<td align="left" class="oddsform">
<INPUT TYPE="text" class="input1" NAME="odds1" SIZE=4>
<select name="status1">
<option>win</option>
<option>lose</option>
</select>
</td>
</tr>
<tr>
<td align="left" class="oddstext">
Odds 2: 
</td>
<td align="left" class="oddsform">
<INPUT TYPE="text" class="input1" NAME="odds2" SIZE=4>
<select name="status2">
<option>win</option>
<option>lose</option>
</select>
</td>
</tr>
<tr>
<td align="left" class="staketext">
Stake: 
</td>
<td align="left" class="stakeform">
<INPUT TYPE="text" class="input1" NAME="stake" SIZE=4>
<br>
<input type="submit" name="go" value="go">
</td>
</tr>
</table>
</form>
</body>
</html>

and calc.php

<?php
$bets = array();
$odds = array();
$stake = $_POST[ 'stake' ];

// fill the arrays from POST data
for ( $a = 1; $a < sizeof( $_POST ); $a++ ) {
	if ( $_POST[ "status$a" ] == "win" ) {
		$bets[$a] = 1;
		$odds[$a] = $_POST[ "odds$a" ];
	} else {
		$bets[$a] = 0;
		$odds[$a] = 0;
	}
}

function winnings( $odds, $stake, $total = 0 )
{
	if ( $total == 0 ) {
		$multiplier = $stake;
	} else {
		$multiplier = $total;
	}
	return ( $multiplier * $odds ) + $multiplier;
}
$total = 0;
echo '<table border="1" cellspacing="0" cellpadding="3"><tr><th>Race</th><th>Odds</th><th>Subtotal</th></tr>';
for( $x = 1; $x <= sizeof( $bets ); $x++ ) {
	if ( $bets[$x] == 1 ) {
		$total = winnings( $odds[$x], $stake, $total );
		printf( "<tr><td>%s</td><td>%s / 1</td><td>\$%.02f</td></tr>", $x,$odds[ $x ], $total  );
	}
}
printf( "<tr><td colspan=\"3\">You have won \$%.02f</td></tr>", $total );
echo "</table>";
?>
 

I don't have your if $calc == "double" loop, cos I don't have your whole script. The above work fine for me.

[martincrumlish]

Hi,

thanks for replying.

I have a few questions. First off, what does %s do?
Secondly, I copied your files exactly and saved as calc.html and calc.php but when I went to calc.html and entered values the return was 0.00 when it should have been 9 (ie: 2/1 and 2/1 at stake 1 with both bets as winners)

Would it be anything to do with register_globals? They are switched on on my installation (4.0.6) I noticed $_POST in your code and I am not really familiar with it but i think its something to do with register_globals.

[martincrumlish]

bump

🙂

[daveyboy]

Originally posted by martincrumlish
I have a few questions. First off, what does %s do?

%s is a string replacement for the functions printf and sprintf, e.g. printf( "My name is %s", $name ) prints "My name is dave", assuming $name == "dave". I think it looks nicer that "text". $var ." text" or vars in strings. Also, you can do things like printf( "%.02f Kb", $bytes / 1024.0 ) and it will display the float to 2 decimal places. Check out the manual:
http://de.php.net/manual/en/function.printf.php

Secondly, I copied your files exactly and saved as calc.html and calc.php but when I went to calc.html and entered values the return was 0.00 when it should have been 9 (ie: 2/1 and 2/1 at stake 1 with both bets as winners)

Would it be anything to do with register_globals? They are switched on on my installation (4.0.6) I noticed $_POST in your code and I am not really familiar with it but i think its something to do with register_globals.

My guess is you're using a different version of PHP to me. Try $HTTP_POST_VARS[ 'odds' ] instead of $POST[ 'odds' ] or maybe just $odds. It works fine here.