Wierd Happenings with @ sign when connecting

cyronuts

Hi,

The following is based on a script posted by Florian in PHPbuilder to pull and view binary data from mysql db. When I remove the @'s and use my db_connct() to do the same thing, it gets wacky and will not display the image.

Here is the slightly altered code:


<?php

// getdata.php3 - by Florian Dittmer <dittmer@gmx.net>
// Example php script to demonstrate the direct passing of binary data
// to the user. More infos at [url]http://www.phpbuilder.com[/url]
// Syntax: getdata.php3?id=<id>

if($id) {

// you may have to modify login information for your database server:
db_connct();  

mysql_select_db("sample_db");

$query = "select bin_data,filetype from image_data where id=$id";
$result = MYSQL_QUERY($query);

$data = MYSQL_RESULT($result,0,"bin_data");
$type = MYSQL_RESULT($result,0,"filetype");

Header( "Content-type: $type");
echo $data;

};
?>

Here is my db_connct():


function db_connct()

{

   @ $db = mysql_pconnect("db.modwest.com", "user", "pass");



  if (!$db)

  {

 echo "Error: Could not connect to database.  Please try again later.";

 exit;

  }  



}

It works fine, until I try the alterations above and then it just does not display the image, something to do with the @ sign?

Thanks, Cyro

DonChris

hi cyro,
the '@' is at the wrong place:
@ $db = mysql_pconnect("db.modwest.com", "user", "pass");
has to be:
$db = @mysql_pconnect("db.modwest.com", "user", "pass");

hth
chris

cyronuts

Thanks for the reply...

Tried that and it still doesn't work, anyother ideas?

I'm just trying to move the user/pass out of the script and into my db_fns file.

Cyro

bobthedog

Is the database connectivity set up ok? Is that the address of the box with the MySQL server on? is that the correct username and password?

Try checking the value of mysql_error(). It may help you.

cyronuts

The connectivity is definitely right, because I rely on it heavily for other parts of the program...how do I use my_sqlerror?

bobthedog

The connectivity is definitely right, because I rely on it heavily for other parts of the program

So - why don't you just use that code if you are connecting to it elsewhere ok? Why re-invent the wheel?

As to mysql_error(), just call that function after any mysql operations and it will normally return you a string containing a possible descriptor of the error. This might help you debug your code.

cyronuts

I was somewhat re-inventing the wheel, but only because I was trying to take the db user/pass out of the script, and put it in a function. It seems so simple, yet it will not work.

FireyIce01

Why don't you put the whole DBconnect into a function?

Part of the common.php I include in my files:

<?
/**
MySQL details
Login Name, Password, Database, Table Name, Etc.
**/

$dbHost = "localhost";
$dbUser = "root";
$dbPass = "pass";
$dbName = "databasename";
$table = "tablename";
$link = "";

/** now onto the business **/

function openLink() {
global $dbHost;
global $dbUser;
global $dbPass;
global $dbName;
global $link;

$link = @mysql_connect($dbHost, $dbUser, $dbPass);

if (!$link) {
print "Error: Could not connect to database ";
return false;
}

if (!@mysql_select_db($dbName)) {
print "Error: Could not find database ";
return false;
}

} // close function