recursive move function problem

[djarre4]

function move($SOURCE, $DESTINATION)
{
chdir($SOURCE);
$DIRECTORY = opendir(getcwd());
while($FILE = readdir($DIRECTORY))
{
if ($FILE == '.' || $FILE == '..') { continue; }
if (is_dir($FILE))
{
echo "<b>&nbsp;$FILE</b><br>";
//echo "mkdir($DESTINATION$FILE, 0700);<br>";
move($SOURCE . "/" . $FILE, $DESTINATION . "/" . $FILE);
//echo "rmdir($DESTINATION$FILE, 0700);<br>";
}
elseif (is_file($FILE))
{
echo "&nbsp;$FILE<br>";
//echo "copy($SOURCE$FILE, $DESTINATION/$FILE);<br>";
//echo "unlink($DESTINATION$FILE);<br>";

	}

}
closedir($_DIRECTORY);

}
move("/usr/local/apache/htdocs/fin/efile/storage", "/usr/local/apache/htdocs/fin/efile", "");

This is my function that I am having problems with. I am merely trying to recursivly copy (move) files from one directory to the next. For some reason, when I make a call to move() from within move() the variables get messed up. The result is that only 1 directory is displayed. If I remove the call to move() within the function move() all directories are displayed. I thought that maybe I would have to declare the variables as static, but that doesn't work. Any ideas on how to solve this problem?

[bobthedog]

it sounds like you are just trying to rename a directory.

In which case - why not just use the "rename()" function built into PHP?

http://www.php.net/manual/en/function.rename.php

This can be used on both files AND directories.

If you want to copy a directory - take a look at the user comments on the copy page

http://www.php.net/manual/en/function.copy.php

To coin a phrase "Five minutes with the manual can save you two hours on the forums"

[djarre4]

I read the user notes on copy and rename, and rename seemed to have problems on some systems, so I thought an easy way was just to write a recursive function to copy/move the files. I will try the rename function though and see if it works. It still puzzles me why this function does not work.

What is even more strange is that if i have:

move ($var1, $var2)
{
static $var1, $var2;
..
..
..
}

and then call it:

move("1", "2");

$var1 and $var2 are both empty in the function even though they were passed. It is just very confusing with the limited C experience I have.

thanks though

[bobthedog]

PHP works slightly differently it seems.

I suggest that by passing in your arguments, and then redeclaring them as statics - you are redeclaring the variables, and so their original values are being lost.

Try using different names for your statics (if that's the way you are going to proceed).

TBH - I dont see any reason for static variables, this negates the reason for doing it recursively.