Include... I need help

Wrath

Ok, I'm trying to use <?php include ('name.ext'); ?> but I'm having this really big problem.

I do this

<?php
include ('reviews.txt');
include ('previews.txt');
?>

And I put this link in http://www.playstationultra.com/~gaminginstitution/main.php?=previews or this link http://www.playstationultra.com/~gaminginstitution/main.php?=previews and the top one is supposed to display reviews.txt but it displays both of them reviews.txt and previews.txt could you please help me fix this??

I want http://www.playstationultra.com/~gaminginstitution/main.php?=previews to display previews only and http://www.playstationultra.com/~gaminginstitution/main.php?=reviews this one to show reviews only.

That's the best I can describe hope someone can help me.

daveyboy

Well, your code just includes both, regardless of what variables it receives. And you aren't even setting variables - you just have a value.

You need something like:
http://www.mydomain.com/mypage.php?action=reviews
and
http://www.mydomain.com/mypage.php?action=previews
for the links - not the action var - then:

switch ($_GET[ 'action' ] ) {
    case 'previews':
        include_once( 'previews.txt' );
        break;
    case 'reviews':
        include_once( 'reviews.txt' );
        break;
    etc...
    etc...
    default:
        // if no value / value is unknown
        echo "Welcome to my homepage!";
}

It will include a different file, according to your action var.

Wrath

Ok i did that and I get this message "switch ($_GET[ 'action' ] ) { case 'previews': include_once( 'previews.php' ); break; case 'reviews': include_once( 'reviews.php' ); break; "

daveyboy

you have to put it in <?php ...the code... ?> tags...

Wrath

umm, I know nothing about php I just got this off a tutorial that sukcs. Co where do the php tags go?

daveyboy

before the code and after the code.

Wrath

Parse error: parse error, unexpected '.' in /home/virtual/site15/fst/home/gaminginstitution/public_html/main.php on line 94

Now I got a parse error.

This is the codes I have

<?php
switch ($_GET[ 'action' ] ) {
case 'previews':
include_once( 'previews.html' );
break;
case 'reviews':
include_once( 'reviews.html' );
break;
etc...
etc...
default:
// if no value / value is unknown
echo "Welcome to my homepage!";
}
?>

metin

You have to be kidding!
I understand that you don't know anything about Php,
but you seem to be unable to think also!
Remove the:
etc...
etc...

In the end it should look like this:

<?php 
switch ($_GET[ 'action' ] ) { 
case 'previews': 
include_once( 'previews.html' ); 
break; 
case 'reviews': 
include_once( 'reviews.html' ); 
break; 
default: 
// if no value / value is unknown 
echo "Welcome to my homepage!"; 
} 
?>

Aeiri

LOL... um...

Well that was interesting... HAHA!

Sorry...

You could also use:


include($action.".txt");

Since they have the same name for everything he is using...

Wrath

Thanks

Aeiri

I noticed you got it working...

Whose code did you end up using?

Wrath

metin's and <?php include ('whatever.txt') ?> wont work cause I have more then 1 page.

Aeiri


<? if(!empty($action) include($action.".txt");
else echo("Welcome to The Gaming Institution"); ?>

I just realized I forgot that...
Mine is a little less code, and less processor intensive.

Using switch statements to change a value INTO the value you checked it against? That's a little strange...

metin

Just to want to clarify things!
The code was not mine,
it was contributed by "daveyboy" originally!

Cheers!

daveyboy

Originally posted by Aeiri
<? if(!empty($action) include($action.".txt");
else echo("Welcome to The Gaming Institution"); ?>
Using switch statements to change a value INTO the value you checked it against? That's a little strange...

It's also a bit more secure than just including unchecked variables from the user, don't you think?

You could do:

$tfile = '/my/path/' . basename( $_GET[ 'action' ] . 'txt' );
if ( file_exists( $tfile ) ) {
    include( $tfile );
} else {
    include( 'homepage.txt' );
}

Or you could do it your way and let visitors browse any .txt file on the server readable by Apache, that they can be bothered to look for.