Session problems :(

[r3n]

Ok, I am having problems registering vars as global vars, take a look at this script:

	case "checklogin":

	$action = 'AdminPanel Login Success';

	$query  = "select $user_id_const, $user_name_const, $user_pass_const ";
	$query .= "from $user_tbl ";
	$query .= "where $user_name_const='$username' and $user_pass_const='$password'";

	$result = mysql_query($query) or die (mysql_error());

	$data = mysql_fetch_array($result);
	$user_name = $data[$user_name_const];
	$user_id = $data[$user_id_const];

	if (mysql_num_rows($result))
	{
		$query  = "insert into $log_tbl ";
		$query .= "set user_id=$user_id, user_name='$username', user_ip='$REMOTE_ADDR', timestamp=now(), action='$action'";

		$result = mysql_query($query) or die (mysql_error());

		session_register("user_name");
		session_register("user_id");
		header("Location:http:admin.php?action=home");
	}
	else
	{
		$pageTitle = 'Login Retry';
		$action = 'AdminPanel Login Failure';

		include("../php/template-inc.php");

		$t = new Template("../templates");

		$query  = "insert into $log_tbl ";
		$query .= "set user_id=$user_id, user_name='$username', user_ip='$REMOTE_ADDR', timestamp=now(), action='$action'";

		$result = mysql_query($query) or die (mysql_error());

		$t->set_file('template','admin-login.ihtml');
		$t->set_var('error','<p class="mainBodyTitles"><font color="#FF0000">Incorrect login,<br>Please try again...</font></p>');

		$t->set_var('siteName',$siteName);
		$t->set_var('pageTitle',$pageTitle);
		$t->set_var('AdminPanelVer',$AdminPanel_ver);

		$t->pparse('Output', 'template'); 
	}

break;

You see the lines where it says:

session_register("user_name");
session_register("user_id");

... Well for some reason, when i try and use them in functions (see below) they show blank - proving the session_register() function dosen't work for some reason:

global $user_name, $user_id;

Hope i layed that out clean enough 🙂 Thx

[merkinmuffley]

when i try and use them in functions (see below) they show blank

... but are they OK when not used in a function? I fail to see how this proves that session_register() "doesn't work"... if there's a problem it's either in your code, or in the server configuration (for example, register_globals not turned on).

[r3n]

hehe, you'll have to forgive me - i'm a bit of a newbie 🙂 - thanks for the info merkinmuffley, how do you turn on register_globals?

[merkinmuffley]

not so fast... you didn't answer my question. the question "do those variables have the right value when you look at them outside any function?", is more important than your server configuration right now.

[r3n]

Hmm, register_globals is turned on because i tested it with includes as so:

admin-inc.php

<?
{
$user_name = 'test';
$user_id = 1;

session_register(user_name);
session_register(user_id);
}
?>

admin-test.php

<?

include("admin-inc.php");

session_start();

print $user_id . ' - ';
print $user_name;

?>

Wich prints ... 1 - test.

So why isn't it working within a function?

The function i'm using:

function chksecurity($minlevel)
{
	session_start();

global $user_id, $user_name, $log_tbl, $REMOTE_ADDR, $HTTP_HOST, $REQUEST_URI, $siteName, $AdminPanel_ver;

mysql_query("insert into $log_tbl set user_id='$user_id', user_name='$user_name', user_ip='$REMOTE_ADDR', action='Requested: $HTTP_HOST$REQUEST_URI', timestamp=now()") or die(mysql_error());

if (!session_is_registered("user_id"))
{
	$pageTitle = 'Login Retry';
	include_once("../php/template-inc.php");
	$t = new Template("../templates");

	$t->set_file('template','admin-login.ihtml');

	$t->set_var('pageTitle',$pageTitle);
	$t->set_var('siteName',$siteName);
	$t->set_var('pageTitle',$pageTitle);
	$t->set_var('AdminPanelVer',$AdminPanel_ver);
	$t->set_var('error','<p class="mainBodyTitles"><font color="#FF0000">You need to be logged in to access this feature.</font></p>');

	$t->pparse('Output', 'template');
	exit;
}
}

I'm not to sure about the claus' stopping the vars from just being transfered onto the next script, but its late and i have a headache 🙂 lol

[merkinmuffley]

your first example there doesn't really prove anything; to make it interesting you'd have to register the variables on one page, then follow a link to another page and echo the values. example:

//page 1
session_start();
session_register("user_name");
session_register("user_id");
$user_name = "test";
$user_id = 1;
echo "<a href=\"page2.php\">";

//////////////////////////////////////////////////////////////////

//page 2
session_start();
echo "User name: $user_name<br>ID: $user_id";

do an example like this and post back the results.

[r3n]

i notice that every1 specifies the variables using the register after using session_register() - is this important?

[merkinmuffley]

good question... I used to think it was important because I have this recollection of reading somewhere, how session_register() clears out the value of the variable. But, other folks have told me that's not true. Now I do it from force of habit more than anything else.