INSERT INTO lunaticasylum (if I don't sort this)

Jon

I'm using an HTML form to POST strings to this page:

<html>
<head>
<title>Update Db</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body bgcolor="#FFFFFF" text="#000000">
<?

/ INIT TABLES /

$link = mysql_connect("localhost","root","")
or die("Could not Connect");

// Select the dbQ database
if (! @mysql_select_db("db", $link) ) {
echo( "Unable to locate the " .
"database at this time." );
exit();
}

/ GET TODAYS DATE /

$dstring = date("d/m/Y");

/ BUILD SQL STRING /

$sql = "INSERT INTO db.dbquestion (QRef,QTitle,Date,QCategory,Question,QTip,ClientName,ClientEmail)";
$sql .= " VALUES (NULL,";
$sql .= $QTitle;
$sql .= ",";
$sql .= $dstring;
$sql .= ",";
$sql .= $QCategory;
$sql .= ",";
$sql .= $Question;
$sql .= ",";
$sql .= $QTip;
$sql .= ",";
$sql .= $ClientName;
$sql .= ",";
$sql .= $ClientEmail;
$sql .= ")";

/ TEMP BUG CHECK, ECHO SQL STRING /

echo $sql;

/ INSERT DATA TO TABLE /

$junk = mysql_query($sql);

/ TEMP ECHO ERROR MESSAGE /

echo mysql_error($link);

/ CLOSE THE DATABASE /

mysql_close($link);

/ USER FEEDBACK /

?>
Thank you for your question.
 Please refer back tomorrow for your reply.
 On <?echo $dstring; ?>, You said:
 Title:
<? echo $QTitle; ?>

 Category:
<? echo $QCategory; ?>

 Question:
<? echo $Question; ?>

Quick Tip:
<? echo $QTip; ?>

 Your Name:
<? echo $ClientName; ?>

 Your Email:
<?echo $ClientEmail; ?>

</body>
</html>
NOTES:
I've split the $sql string up for ease of reading.
The 'echo $sql' line works perfectly.
Fieldnames in HTML forms are the same as the fieldnames in the MySQL table.
The NULL is to update an autonumber field.
All the fields are text fields except QRef (autonumber) and Question (bigtext).

THE PROBLEM:
mysql_error returns "Unknown column <text of $QTitle > in 'field list' "
For <text of $QTitle > read "whatever is typed into the QTitle field".

Now I KNOW this has to be a simple error - but what? It's driving me nuts.
MORE INFO:
If I type a proper style email address into the ClientEmail, the error changes to "There is an error in your code near '@.com' ", if there is a space in anyof the fields I get the same message, pointing at the space.

Can anyone save my sanity?

jeremuck

does it work if you hardcode the values?

You might add backticks around your table and field names:

field, field2

And you might put some kind of quote indicator around your inserted text:

'text to be inserted' or

$insertThis = "\"text to be inserted\"";

also, you might need to parse the strings for the db...
use addslashes or something.

Jon

Thanks for your reply.

Hmmm....with hardcoded strings (provided I do not include spaces or @'s, I get exactly the same error message - and of course, it does not insert the record.

This suggests passing the values to the query is fine and the error is elsewhere - esp. as the echo $sql line is OK.

You're right of course about using addslashes but that should not be necessary for spaces surely?

tha_mink

Try it this way...

$sql = "INSERT INTO db.dbquestion (QRef,QTitle,Date,QCategory,Question,QTip,ClientName,ClientEmail)";
$sql .= " VALUES (NULL,'$QTitle','$dstring','$QCategory', '$Question', '$QTip', '$ClientName', '$ClientEmail')";

That should work or at least provide better debugging.

tha_mink

Jon

YES!
It works. Many thanks for your help.
Now I can get on with the rest of it.
Thanks again

:-)