Variable not updating correctly

[ywickham]

Hi,

I have a variable ($digipagetype) that doesn't seem to updating after it is updated within a function (printHeader). For instance, in the example below, when entering the "for ($counter" loop, $digipagetype should equal 2. It current returns null. What am I doing wrong?

Thanks!

<?
/*Initialize variables*/
$digipage = a; //this is set dynamically by passing from another page
$digipagetype = 1;
$range = 0.099;
$end_range = 0.9;


printHeader($digipagetype, $digipage, $range, $end_range);

for ($counter = 1;$counter < 3; $counter++) {

if ($digipagetype == 1) {
	.
	.
	.
} else { //if digipagetype = 2
	print "$digipagetype = ".$digipagetype."<br>";
}

} // match for: for counter





function printHeader($digipagetype, $digipage, $range, $end_range) {

if (is_numeric($digipage)) {
	if ($digipage == 0) {
		.
		.
		.
	}
	elseif ($digipage == 1) {
		.
		.
		.
	}
	elseif ($digipage == 2) {
		.
		.
		.
	}

	$digipagetype = 1;

} else {
	if ($digipage == "a") {
		.
		.
		.
	}

	$digipagetype = 2;
}

print "$digipagetype = ".$digipagetype."<br>";

}
?>

Results:
$digipagetype = 2
$digipagetype =
$digipagetype =

[tomhath]

You've made it extra confusing by using the same names for both the global variables and the function parameters.

The globals are not visible inside the function because you did not declare them to be global inside. Php function parameters are normally passed by value unless you specifically pass them by reference. So there's no way for the assignment you made inside the function to have any effect after the function returns.

[ywickham]

Sorry to confuse you...it's actually easier for me to see what's going on if I refer to my variables by the same name, no matter where they are in my scripts.

Thanks for the solution. You were absolutely right in that I forgot to call by reference. (Not that you needed me to tell you that.) 🙂 Once I added my ampersand, it worked beautifully.