page navigation --whats wrong with this function

[netmastan]

Here is the function

function index()

{

global $link;

$perpage=5;

echo" <h3>Top Headline News</h3>";

$res = mysql_query("select * from inews", $link);
     $numstories = mysql_num_rows($res);
     $numpages = ceil($numstories / $perpage);



if ($pagenum == "") { $pagenum = 1 ; }
     $offset = ($pagenum-1) * $perpage ;

 $result=mysql_query("Select newsid,headline,body,date,hits,source from inews  ORDER BY date DESC limit $offset, $perpage",$link);
 while(list($newsid,$headline,$body,$date,$hits,$source)=mysql_fetch_row($result)) {


  echo"»&nbsp;<a href=\"index.php?action=click&amp;newsid=$newsid\">$headline</a>&nbsp;(total Read:$hits)<br>$date-Source:$source<br>";

   }
    if ($numpages > 1) {
            echo "<P align=\"left\">$numstories Stories ($numpages Pages, $storynum Per Page)" ;
            echo "[ " ;
            for ($i=1; $i < $numpages+1; $i++) {
                if ($i == $pagenum) {
                    echo "$i";
                } else {
                    echo "<a href=\"index.php?pagenum=$i\">$i</a>";
                }
                if ($i < $numpages) { echo " | "; } else { echo " ]</center>"; }
            }
        }

}

and the switch code is like this

switch($action) {

case "click":
counthits($newsid);
   break;

case "readnews":
   readnews($newsid);
    break;

default:
index();
break;

}

page Navigation is not working.. it shows page 1 and 2 when i click the link it shows the same page...
I want to have url like this index.php?page=2 etc

thanks in advance

[examancer]

with that function $pagenum will ALWAYS equal 1. $pagenum is not passed to the function, nor is it referenced globally, so $pagenum will always appear empty and will be given a value of one here:

if ($pagenum == "") { $pagenum = 1 ; }

$pagenum is no where to be found before that, so it will ALWAYS be empty, and be set to 1. I don't know the rest of your code, but I'm guessing that the page number should either be passed to your function, or should be globally referenced (like $link is).

You might want to change how you check to see if $pagenum is empty too, since that way could cause warnings if its not set. This is generally preferred over your method:

if (empty($pagenum)) { $pagenum = 1; }

Also, "SELECT * FROM inews" is a bad way to count the number of records. This will pull ALL the data from the inews table, which would result in a huge query if there are a lot of records. A MUCH faster way of doing it would be this:

$res = mysql_query("select count(*) from inews", $link);
$numstories = mysql_result($res, 0);
$numpages = ceil($numstories / $perpage);

this query only retrieves the number of records, not the records themselves, so its MUCH faster.

Those are just some things that caught my eye, so no guaruntee that will fix all your problems, but I hope it helps.

[netmastan]

thank you for some tips . Could you tell me what '0' means in the following code

$numstories = mysql_result($res,0);

Still page navigation not working .. anyone can help ....

cheers

[examancer]

the 0 is specifying the result that the function should fetch, in this case you want the first and only result (count(*)) which is 0 (starts at 0, 1 would be the second result).

[netmastan]

It's working now after adding $pagenum in the index function

so the the function should be writtten

function index($pagenum) 

thanks again for the tips and suggestion .