Form (Undefined variable:)

wil

I am having a problem with geting my form scripts to work on my computer. I have XP pro with Apache 1.3.27, PHP 4.2.3, Tomcat 4.1.12, and MySQL 3.23.52. I know that all of this works. I have tested it with other scripts and have had success using it. I have had the exact same form and php script work on my virtual server that my site runs off of. I just am having problem with it running on my workstation. I have included the HTML doc and the php doc.

This is the error message I get on my workstaion when I submit the form.

Notice: Undefined variable: email in c:\program files\apache group\apache\htdocs\info.php on line 4

Here is the scripts:

<?php

if ($name != ""){
}else{
die("Name is Required");
}

if ($email != ""){
} else {
die("Email address Required");
}

if ($data_name != "") {
copy("$data", "/home/wjlorgan/public_html/onestopfreakshop/upload/$data_name");
}

echo "Thank you $name for your interest in our product";
echo "<br><br>";
echo "We will respond within 24-48hrs";
echo "<br><br>";
echo "Name: $name";
echo "<br>";
echo "Email: $email";
echo "<br>";
echo "Diameter: $diameter";
echo "<br>";
echo "Wood Type: $woodtype";
echo "<br>";
echo "Flare Type: $flaretype";
echo "<br>";
echo "Customizing: $custom";
echo "<br>";
echo "You sent in $data_name";

mail("info@notreal.com",
"Web Information Request",
"$name has requested information on.

Diameter: $diameter
Wood Type: $woodtype
Flare Type: $flaretype
Customizing: $custom
Flie Sent: $data_name",
"from: $email");

HTML Document:

<html>
<head>
<title>Information Form</title>

<body>

<table width="400"><tr><td align="center">
Please fill in the form and submit it.<br>
We will get back to you in 24-48 hrs
</td>

Name
<input type="text" name="name" size="20" maxlength="30">
<br>
Email
<input type="text" name="email" size="20" maxlength="40">
<br>
Diameter
<select name="diameter">
<option value=2g>2g
<option value = 0g>0g
<option value = 00g>00g
</select>

<br>

Wood Type
<select name="woodtype">
<option value = chakte_kok>Chakte Kok
<option value = chechen>Che Chen
<option value = ebony>Ebony
<option value = grandillio>Grandillio
<option value = maple>Maple
</select>

<br>

Flare Type:
<select name = "flaretype">
<option value = straight>Straight no grooves
<option value = straight_o>Straight w/O-rings grooves
<option value = 1flare>Single flare no grooves
<option value = 1flare_o>Single Flare w/grooves
<option value = dflare>Double Flare
</select>

<br>

Customizing:
<textarea cols="30" rows="5" name="custom">
</textarea>
<br>
Add a File:
<input type="file" name="data">

<p align="center"> </p>
<p align="center"><i><font size="2">As with all natural products our jewelry is
to be worn at your OWN risk. Not all types of material is appropriate for
certain sensitive skin individuals.</font></i><br>
<i><font size="1">All designs and pictures are property of<br>
WJL Organic Industries,Inc &<br>
One Stop Freak Shop &copy 2001-2002</font></i></p>

</table>
</body>

</html>

Thanks in advance for the help.

jburfield

undefined variable is a generic error meaning that there is no variable set for, in your case, 'email.'

However, I see you do have it as a form element.

I don't see where you are grabbing the vars from post anywhere...did you turn REGISTER GLOB ALS on? If not, you need to grab the variables such as:

$email = $_POST["email"];
etc, etc...

Are you doing something like that?

-- Jason

wil

Jason,
I do not have REGISTER GLOBALS on. I still have it as OFF from the default setting. I just set up everthing yesterday so this is the first thing I have done on it. Should I turn them on or not? If not can you please explain more on how to use this.

$email = $_POST["email"];
etc, etc...

This is the first thing I have done in PHP. So please bear with the lack of knowledge.

Wil

philipolson

There are two main issues you should be aware of regarding this question:

a) The error_reporting directive
b) The register_globals directive

First, undefined variable errors are errors of level E_NOTICE. Typically one does not show these but good little programmers (like you) do not want to create these errors. So instead of comparing a variable (that may or may not be defined) to an empty string (""), use a PHP function that's made for this, such as isset() or empty(). For example:

Good*:

if (empty($var)) {

Bad:

if ($var != '') {

error_reporting can be set in php.ini and at runtime with the error_reporting() function.

Second, you have register_globals = off. This means that $email will never exist, none of your form variables,like $name, will either. You should be using the autoglobals instead, so:

if (empty($_POST['email'])) {
    print "Please enter an email address";
    exit;
}

jburfield suggested $email = $_POST['email'] for that reason. Also, please read these manual entries:

http://www.php.net/manual/en/language.variables.external.php
http://www.php.net/manual/en/language.variables.predefined.php
Read the manual for further details, like '0' is considered empty.

jburfield

Excelent post by philipolson. Read what he said and this should all make sense.

The $_POST["something"]; is just the way to retrieve elements passed in through a form.

$HTTP_POST_VARS["something"]; was how it was used in previous versions of PHP.

If you have the following form:

<form name="xxx" action="somepage.php" method="post">
Name: <input type="text" name="name"><BR>
Emai: <input type="text" name="email"><BR>
Phone: <input type="text" name="phone"><BR>
<input type="hidden" name="action" value="go">
<input type="submit" value="submit">
</form>

When you submit this form you can grab the following variables:

$name = $POST{"name"];
$email = $POST["email"];
$phone = $POST["phone"];
$action = $POST["action"];

You can then do whatever you need to with them.

If, on the other hand, you are passing vars through in the URL you can use the $_GET{""] array (or the $HTTP_GET_VARS[""] array);

If the URL is:
http://www.sportsshooter.com/fmembers.html?id=2

You can grab this id with this:
$id = $_GET["id"];

Helping any?

-- Jason

wil

I am understanding how to do this. At least I think I am. It will be a few days until I get to try to work it out. I will post more when I get it done.

Thanks again for the help,
Wil

wil

This is what I came up with. It does work but I want to know if it written properly. If not what do I need to change.

if (empty($_POST ['email'])){
print "Please enter an Email address";
exit;
}

if (empty($_POST ['name'])){
print "Please enter your name";
exit;
}

if (is_uploaded_file ($_FILES ['data'] ['tmp_name'])) {

$data_name = $_FILES ['data'] ['name'];

copy ($_FILES ['data'] ['tmp_name'], "C:\Program Files\Apache Group\Apache\htdocs\file\.$data_name");

}

$name = $POST ['name'];
$email = $POST ['email'];
$diameter = $POST ['diameter'];
$woodtype = $POST ['woodtype'];
$flaretype = $POST ['flaretype'];
$custom = $POST ['custom'];

mail("info@wjlorganics.com",
"Web Information Request",
"$name has requested information on.

Diameter: $diameter
Wood Type: $woodtype
Flare Type: $flaretype
Customizing: $custom
Flie Sent: $data_name",
"from: $email");