file txt

[girub]

Hi guys, I have this problem that I can not resolve.
I have to control if inside the file txt there are variables.
If there are not I have to insert these variables.
My script is the seguent:

$fp=file("../erogazione_artl.txt");
while(list($key,$val)=each($fp)) {

list($txt_id,$txt_nome,$txt_cognome,$txt_indirizzo)=explode("|",$val);

 if ($txt_id== $id){
echo"<br>già esiste<br>";
 }else{

  function for insert into txt.....
 }

}

The fact is that this script is inside a loop "for" therefore the checking is repeating two times.
the first one for the loop "for" that finds all the "$id" from the table and the second one,
for the loop "while" that reads the file txt and finds "$txt_id"
Hi everybody and thanks anyway.
Giuseppe

[philipolson]

How about something like:

<?php
$match = false;
$lines = file($filename);
foreach ($lines as $line) {
    list($txt_id, $txt_nome, $txt_cognome, $txt_indirizzo) = explode("|", $line);

if (trim($txt_id) == trim($id)) {
	$match = true;
	break;
}
}

if ($match != true) {
	if (!insert_text($filename, $text)) {
		print 'Unable to write file';
	} else {
		print 'Thanks, you have been added';
	}
} else {
	print "<br>già esiste $txt_nome<br>";
}


function insert_text($filename, $text) {
	if (!$fp = fopen($filename, 'a')) {
		return false;
	}

if (!fwrite($fp, "$text\n")) {
	return false;
} else {
	return true;
}
fclose($fp);
}

?>

You may want to adjust the error handling :-) (like, make sure $id exists...) Notice how we used break; if the id was found, that'll stop the loop.

[girub]

thank you very much... you have risolved my problem....
Unfortunately now I have another little problem. The fact that repeats the seguent message many times because anyway the "print" is inside the loop:

print 'Thanks, you have been added';

Hi, you have been very kind.
🙂
Giuseppe

[philipolson]

Not sure what you mean, that's why we created $match. That print statement isn't inside of a loop.