Class Confusion

beastlet

Can someone please explain what I am doing wrong here? Below is the code I am using to extend a class I already created. The page class works perfectly, so no problem there. The URL that leads to this page is of the form:

http://www.domain.net/author.php?authorid=xx

I get this error: Parse error: parse error, unexpected T_VARIABLE in /home/virtual/site1/fst/home/meandthee/public_html/authorpage.inc on line 10.

I've tried numerous variations, including just defining var $authorid;, not defining it, calling it with $this->, calling it without $this->, etc and I can't figure this out.

Thanks,
Trixie

// START CODE

require ("page.inc");

class AuthorPage extends Page
{

// class authorpage's attibutes

Line 10 var $authorid = $_GET[authorid];

// class authorpage's operations

function GetAuthorInfo($this->authorid)
{
	@ $db = mysql_pconnect("localhost", "user", "password");

	if (!$db)
	{
		echo "Error: Could not connect to database. Please try again later.";
	}

	mysql_select_db("domain_net");
	$autid_query = "select * from table where authorid = $authorid;";
	$autid_result = mysql_query($autid_query);
	$autid_row = mysql_fetch_array($autid_result);

}

function DisplayAuthorHeader()
{
	echo "<font size=+4>";
	if ($autid_row["firstname"])
	{
		echo stripslashes($authid_row["firstname"])." ";
	}
	echo stripslashes($authid_row["lastname"]);
	echo "</font><br><br>\n\n";
}

}

// END CODE

_SuperString

Try putting quotes around you $_GET variable:

$_GET['authorid'];

as per your line 10.

🙂

IceD

RTFM.
There are following errors in your class:
1. You can't assign value to the variable when difening it. You should do this in the constructor.
2. You don't need to pass class variables into the class functions 😉
3. In line 14 you should place '@' before mysql_pconnect, but not before $db
4. And other errors.
Here is corrected code:

<?

require ("page.inc");

class AuthorPage extends Page
{

var $authorid;
var $audit_row;

function AuthorPage()
{
    $this->authorid = $_GET["authorid"];
}

function GetAuthorInfo()
{
    $db = mysql_pconnect("localhost", "user", "password") or die("Could not connect to database");
    mysql_select_db("domain_net");
    $autid_query = "select * from table where authorid = " . $this->authorid;;
    $autid_result = mysql_query($autid_query);
    $this->autid_row = mysql_fetch_array($autid_result);
    mysql_free_result($autid_result);
}

function DisplayAuthorHeader()
{
    echo "<font size=+4>";
    if ($this->autid_row["firstname"])
    {
        echo stripslashes($this->authid_row["firstname"]) . " ";
    }
    echo stripslashes($this->authid_row["lastname"]);
    echo "</font><br><br>\n\n";
}
}

?>

BTW. Why have you implement connection to the DB in the AuthorPage class? In should be in the Page class...

beastlet

Originally posted by IceD

RTFM.

I'm working on it. It's not always that easy when you don't know what exactly to look up in the index.

There are following errors in your class:
1. You can't assign value to the variable when difening it. You
should do this in the constructor.

I figured that out right after posting, while RingTFM.

You don't need to pass class variables into the class
functions 😉

Good. I'm glad you explained that, because it wasn't clearly explained in the book I'm using.

And other errors.
Here is corrected code:

That code generated error messages as well, but between your code and mine I was able to figure out where the problem was.

BTW. Why have you implement connection to the DB in the
AuthorPage class? In should be in the Page class...

It is in the Page class. I didn't know I didn't have to do it again. I've only been at this for a few days so haven't quite reached exalted guru status or anything. I'm hoping to trade in clueless newbie sometime this year.

Thanks,
Trixie

IceD

I figured that out right after posting, while RingTFM.
RTFM is acronym for "Read This Fscked Manual"

That code generated error messages as well, but between your code and mine I was able to figure out where the problem was.
And this is errors from your "page.inc" 😉

Good. I'm glad you explained that, because it wasn't clearly explained in the book I'm using.
Try different books. I suggest you to read
- "MySQL/PHP Database Applications" by Greenspan and Bulger
- "PHP and MySQL Web Development" by Welling and Thomson
- "Web Applications Development with PHP 4.0" by Ratschiller and Gerken

beastlet

Originally posted by IceD
>>I figured that out right after posting, while RingTFM.

RTFM is acronym for "Read This Fscked Manual"

That's why I was Read'ing' The F'ing Manual.

That code generated error messages as well, but between your code and mine I was able to figure out where the problem was.
And this is errors from your "page.inc" 😉

Well I didn't have to do anything to page.inc to make things work, but what do I know?

IceD

Try

while ($row = mysql_fecth_assoc($res))
{
  do_smth($row);
}