Ahhhh!!

[brcolow]

Ok, im trying to see if a varible is over 15 characters, ive tried char_count but it doesnt really work well, then i tried the mb_seren (sp?) and it said call to undefined function, either my php is too old or too new. So now, what can i do to count the ammouint of characters in a varible?

[philipolson]

Try strlen().

if (strlen($var) > 15) {
    print "Silly, I said ($var) can't be over 15 characters";
}

Btw, mb_strlen() is undefined because you don't have the Multi-Byte String Functions compiled into your PHP. But, you don't need them anyways.

[brcolow]

Thanks that works, now two more questions...

One... I got a code snipplet that checks if an email is valid. At the end it says this

//Return 1 if email is valid else 0 if mail is invalid

So i tried using if statements but it didnt work. Then i tired...

if(isset( $email ))
{
echo "Activation email has been sent to $email";
}

But that displays the email even when it is invalid... so what should i do for that?

My second question is... how can i check to see if the username does not include invalid characters, like spaces, symbols etc. Thanks alot
-Mike

[philipolson]

Whether or not $email equals 0 or 1, it's still set. You want to use empty() instead of isset().

So, do you want only letters and numbers in the username?

[brcolow]

Ok, i got the invalid character thing and im about to try the empty() lets see if it works...

[brcolow]

Ok heres what i did

if (empty($email)) 
{
	echo "Invalid email, please go back and try again.<br>";
}
else
{

echo "An activation email has been sent to $email .<br>";
}		
(line 82) ?>

And it gives me this...

Parse error: parse error, unexpected $ in D:\www[url]www.flashstand.com\users\validate.php[/url] on line 82

[philipolson]

That piece of code does not have a parse error, check your other code. I'm guessing a missing " or } somewhere.

[brcolow]

no, i seriously dont see one....

[philipolson]

Look harder, there is an error somewhere else. If you don't believe me, ask PHP. Make a script with just the code above and it'll work fine.

[brcolow]

if (strlen($username) < 5) {
    print "Your username is too short, it must be more then 5 characters. Please go back and try again.<br>";



if (strspn($username,"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_*~") 
	!= strlen($username)) {
	echo "Illegal character in your username. Please go back and try again.It cannot contain any symbols except for -, _, *, or ~.<br>";
}

if (strlen($password) > 15) {
    print "Your password is too long, it can only be 15 characters. Please go back and try again.<br>";
}

if (strlen($username) < 5) {
    print "Your password is too short, it must be more then 5 characters. Please go back and try again.<br>";

if (strspn($password,"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_*~") 
	!= strlen($username)) {
	echo "Illegal character in your password. Please go back and try again. It cannot contain any symbols except for -, _, *, or ~<br>";
}

if( $password <> $password2 )
	echo "Your passwords dont match!<br>";

See one?

[philipolson]

That's not 82 lines and I don't know how your logic is done here (without seeing the whole file) but if (strlen($username) < 5) { lacks a }, and if (strlen($username) < 5) { might too. If you use a {, you must use a }. Or, use neither.

[brcolow]

ok the whole thing then..

<?
$username = $_POST['username'];
$password = $_POST['password'];
$password2 = $_POST['password2'];
$errors = 0;
$addtoerrors = 1;
if (strlen($username) > 15) {
    print "Your username is too long, it can only be 15 characters. Please go back and try again.<br>";
	$errors + $addtoerrors;
}

if (strlen($username) < 5) {
    print "Your username is too short, it must be more then 5 characters. Please go back and try again.<br>";



if (strspn($username,"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_*~") 
	!= strlen($username)) {
	echo "Illegal character in your username. Please go back and try again.It cannot contain any symbols except for -, _, *, or ~.<br>";
}

if (strlen($password) > 15) {
    print "Your password is too long, it can only be 15 characters. Please go back and try again.<br>";
}

if (strlen($username) < 5) {
    print "Your password is too short, it must be more then 5 characters. Please go back and try again.<br>";

if (strspn($password,"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_*~") 
	!= strlen($username)) {
	echo "Illegal character in your password. Please go back and try again. It cannot contain any symbols except for -, _, *, or ~<br>";
}

if( $password <> $password2 )
	echo "Your passwords dont match!<br>";

function plugin($email)
{
		$pat1 = "@";	
		$emailarr = split ($pat1,$email);		
		$email1 = $emailarr[0];
		$email2 = $emailarr[1];			
		$email = trim($email);
		$elen = strlen($email);
		//find for dot	46 ord of . =================================	
		$dotpresent = 0;
		for ($i=2;$i<=$elen;$i++)
		{
			$j = substr($email,0,$i);
			$jlen = strlen($j);			
			$lastj = substr($j,$jlen-1,$jlen);			
			$asci = ord($lastj);				
			if ($asci==46)
			{				
				$dotpresent = 1;
			}						
		}	
		//find for space 32 ord of space in between ====================
		$spaceexist = 0;
		for ($k=0;$k<$elen;$k++)
		{
			$myword = substr($email,$k,1);			
			if (ord($myword)==32)
			{
				$spaceexist = 1;
			}

	}				
	if ($email2)
	{
		$atpresent = 1;
	}		
	if ($atpresent=='1' AND $dotpresent=='1' AND $spaceexist=='0')
	{
		$validmail = 1;
	}
	else
	{
		$validmail = 0;
	}		
	return ($validmail);		
}
		$email = $_POST['email'];
		$validmail = plugin($email);	
		//Return 1 if email is valid else 0 if mail is invalid
if (empty($email)) 
{
	echo "Invalid email, please go back and try again.<br>";
}
else
{

echo "An activation email has been sent to $email .<br>";
}		
?>

The email function im sure works because i tested it alone so hmmm... i cant find one, can u?

[philipolson]

I was referring to the code above, not an email function. Anyway, the two spots I mentioned in my last post are missing }, so, you are missing two }'s Btw, the second if (strlen($username) < 5) { in your code should have $password in it.

[brcolow]

Well i added the }'s and it still gives me

Parse error: parse error, unexpected $ in D:\www[url]www.flashstand.com\users\validate.php[/url] on line 95

[philipolson]

You'll eventually figure it out, the error has to do with braces.

[brcolow]

Just tell me man, jesus

[Hank]

just look better in your code for forgotten brackets...

<?
$username = $_POST['username'];
$password = $_POST['password'];
$password2 = $_POST['password2'];
$errors = 0;
$addtoerrors = 1;
if (strlen($username) > 15) {
    print "Your username is too long, it can only be 15 characters. Please go back and try again.<br>";
    $errors + $addtoerrors;
}

if (strlen($username) < 5) {
    print "Your username is too short, it must be more then 5 characters. Please go back and try again.<br>";
} //<----this one


if (strspn($username," abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_*~") != strlen($username)) {
    echo "Illegal character in your username. Please go back and try again.It cannot contain any symbols except for -, _, *, or ~.<br>";
}

if (strlen($password) > 15) {
    print "Your password is too long, it can only be 15 characters. Please go back and try again.<br>";
}

if (strlen($username) < 5) {
    print "Your password is too short, it must be more then 5 characters. Please go back and try again.<br>";
} //<--and this one you forgot

if (strspn($password," abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_*~") 
    != strlen($username)) {
    echo "Illegal character in your password. Please go back and try again. It cannot contain any symbols except for -, _, *, or ~<br>";
}

if( $password <> $password2 )
    echo "Your passwords dont match!<br>";

function plugin($email)
{
        $pat1 = "@";    

        $emailarr = split ($pat1,$email);        

        $email1 = $emailarr[0];
        $email2 = $emailarr[1];            

        $email = trim($email);
        $elen = strlen($email);
        //find for dot    46 ord of . =================================    

        $dotpresent = 0;
        for ($i=2;$i<=$elen;$i++)
        {
            $j = substr($email,0,$i);
            $jlen = strlen($j);            

            $lastj = substr($j,$jlen-1,$jlen);            

            $asci = ord($lastj);                

            if ($asci==46)
            {                

                $dotpresent = 1;
            }                        

        }    

        //find for space 32 ord of space in between ====================
        $spaceexist = 0;
        for ($k=0;$k<$elen;$k++)
        {
            $myword = substr($email,$k,1);            

            if (ord($myword)==32)
            {
                $spaceexist = 1;
            }

    }                
    if ($email2)
    {
        $atpresent = 1;
    }        
    if ($atpresent=='1' AND $dotpresent=='1' AND $spaceexist=='0')
    {
        $validmail = 1;
    }
    else
    {
        $validmail = 0;
    }        
    return ($validmail);        
}
        $email = $_POST['email'];
        $validmail = plugin($email);    

        //Return 1 if email is valid else 0 if mail is invalid
if (empty($email)) 
{
    echo "Invalid email, please go back and try again.<br>";
}
else
{

echo "An activation email has been sent to $email .<br>";
}        

?>

[crickettdt]

This works, u were missing a few curly braces.

Also, try writing your code in this format, makes it very easy to see if you are missing a curly brace.

if(strlen($username) < 5)
{
    print "Your username is too short, it must be more then 5 characters. Please go back and try again.<br>";
}



if(strspn($username," abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_*~") != strlen($username)) 
{
    echo "Illegal character in your username. Please go back and try again.It cannot contain any symbols except for -, _, *, or ~.<br>";
}

if(strlen($password) > 15) 
{
    print "Your password is too long, it can only be 15 characters. Please go back and try again.<br>";
}

if(strlen($username) < 5) 
{
    print "Your password is too short, it must be more then 5 characters. Please go back and try again.<br>";
}

if(strspn($password," abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_*~") != strlen($username)) 
{
    echo "Illegal character in your password. Please go back and try again. It cannot contain any symbols except for -, _, *, or ~<br>";
}

if( $password <> $password2 )
{
    echo "Your passwords dont match!<br>";
}