Query Insert Problem!

phence

when i run this query(below), all the data is inserted out of order, in the mysql database... why? is there a better way to code this query... I am using php

$query = "INSERT INTO customer VALUES (" .
			"\"" . $formVars["surname"] . "\", " .
			"\"" . $formVars["firstName"] . "\", " .
			"\"" . $formVars["title"] . "\", " .
			"\"" . $formVars["address1"] . "\", " .
			"\"" . $formVars["address2"] . "\", " .
			"\"" . $formVars["city"] . "\", " .
			"\"" . $formVars["state"] . "\", " .
			"\"" . $formVars["zipcode"] . "\", " .
			"\"" . $formVars["country"] . "\", " .
			"\"" . $formVars["phone"] . "\", " .
			"\"" . $formVars["fax"] . "\", " .
			"\"" . $formVars["email"] . "\", " .
			$dob . ", " . 0 . ")";

thank-you all help is appreciated!

jeremuck

you should supply the order of the columns too.

phence

what do u mean?

Lars_Berg

all the data is inserted out of order, in the mysql database

You can not assume that data in a table in a relational database is ordered in any way.

Ordering is only applicable to result sets and is specified by using an order by clause in a select statement.

jeremuck


$query = "INSERT INTO customer VALUES (" .
            "\"" . $formVars["surname"] . "\", " .
            "\"" . $formVars["firstName"] . "\", " .
            "\"" . $formVars["title"] . "\", " .
            "\"" . $formVars["address1"] . "\", " .
            "\"" . $formVars["address2"] . "\", " .
            "\"" . $formVars["city"] . "\", " .
            "\"" . $formVars["state"] . "\", " .
            "\"" . $formVars["zipcode"] . "\", " .
            "\"" . $formVars["country"] . "\", " .
            "\"" . $formVars["phone"] . "\", " .
            "\"" . $formVars["fax"] . "\", " .
            "\"" . $formVars["email"] . "\", " .
            $dob . ", " . 0 . ")";


//I prefer something like this:
// just make it's the ones you want by usinga key list
foreach($formVARS as $key=>$value)
{
$fields[$key] = $key;
$values[$key] = $value;

}

$set = "`" . explode("`, `", $fields) . "`";
$values = "'" . explode("', '", $values) . "'";

$SQL = "INSERT INTO `customer` (" . $set . ") VALUES (" . $values . ");";

echo $SQL;

I like to get a list of fields from the DB.
Generate a key list from that.
Prepare all my values.
Then in my loop, I check to make sure the current one is in the key list. If it is, I do what you see, if not I just skip it.