checkdate() problem

jowatkins

Hi,

I have a function that uses the checkdate() function to validate a date entry. However, the checkdate function itself is returning false for valid dates. For example, if I enter todays date as 2002-10-17, it returns false.

Here's the code:

function valid_date($date)
{
	global $date;
	global $day;
	global $month;
	global $year;
	global $month_and_day;

$todaycheck = gmdate ("Y-m-d", mktime (1,1,1998));
$date_without_dash = str_replace("-", '', $date);
$day = substr ($date_without_dash, -2); 
$month = substr ($date_without_dash, -4, -2); 
$year = substr ($date_without_dash, 0, 4); 
echo "date = $date<br/>";
echo "date_without_dash = $date_without_dash<br/>";
echo "day = $day<br/>";
echo "month = $month<br/>";
echo "year = $year<br/>";
/*
if (!date_correct_format($date)) 
{
  echo "Please enter date in correct format<br/>";
	return false;
}	
elseif ($date < $todaycheck) 
{
  echo "Sorry, you cannot enter past dates.<br/>";
	return false;
}
*/
if (checkdate($month, $day, $year)) 
{
  echo "Sorry, you have entered an invalid date<br/>";
	echo "Possible causes could be:<br/>";
	echo "<ul>";
	echo "<li> The number of days in the month is invalid";
	echo "<li> The date you have entered is invalid due to a leap year";
	echo "</ul>";
	return false;
}
else
{
	return true;
}
return $day;
return $month;
return $year;
return $month_and_day;

}

Can anyone shed some light on this?

IceD

$date = time();
$year = date("Y", $date);
$month = date("m", $date);
$day = date("d", $date);
echo checkdate($month, $day, $year);

BTW. You have some errors in your script - you can't return multiply values from function, you should use "return array($val1, $val2, $val3)"

jowatkins

Thanks, but it still isn't working. There seems to be something wrong in the way it handles leapyears. I know 2003 is not a leapyear, but 2004 is.

But if I enter 2003-02-29 it returns true, so the date is considered to be OK. But 2004-02-29 is returned false.

This is backwards.

milanisti

change this
if (checkdate($month, $day, $year))
into
if (!checkdate($month, $day, $year))

jowatkins

Hi Guys,

Thanks for the help, but I tried your suggestions but I still can't get this to work.

If I hard code in the numbers, it works fine.

$dateok = checkdate(02, 29, 2003);

if ($dateok == "0") 
{
  echo "Date Wrong<br/><br/>";
}
else
{
  echo "Date OK<br/><br/>";
}

But if I pass in variables, it all fails

$dateok = checkdate($Month, $Day, $Year);

I realised the variables were being recognised as strings and converted them to integers using intval(), but no luck. Any other ideas?

jowatkins

bump

IceD

One suggestion:
Try to [man]echo[/man] data before checking - it's the easiest way to "debug" your code.

Weedpacket

Wouldn't the global variable $date stomp on the function parameter $date?

function($date)
{ // $date contains what
  // was passed to the function
  global $date;
  // Now $date is a reference to
  // $GLOBALS['date']
...
}

(Actually, why are any of those variables declared global? If they're not being passed in as parameters you appear to be wanting to return them (but you won't, because you're returing either true or false instead), or not using their values at all anyway.

PS. an easier way to separate "yyyy-mm-dd" into year, month and day would be
list($year,$month,$day)=explode('-','1998-10-17');