Where Did It Go Wrong???

NYSiRacer

I'm using the code below to log visitors, but it's not working, could someone tell me what I did wrong?

if (!getenv("HTTP_REFERER")) {
$referer = "&nbsp;";
} else {
  $referer = getenv("HTTP_REFERER");
  }
if ((!preg_match("/^http:\\/\\/evilcity\\.com/i",$referer)) || (!preg_match("/^http:\\/\\/www\\.evilcity\\.com/i",$referer))) {
// if $referer doesn't come from my domain, log $referer
// but it doesn't work...
}

Thank you.

bbaassiri

try using an else and dont use not

it worked for me

what version of php are you using

if ((preg_match("/^http:\/\/evilcity\.com/i",$referer)) || (preg_match("/^http:\/\/www\.evilcity\.com/i",$referer))) {
// if $referer doesn't come from my domain, log $referer
// but it doesn't work...
	print( 'match' );
}
else
{
    //log it!!!
}

NYSiRacer

PHP version 4.2.1, could it be a bug?
Well, I used [not] because I didn't want it to do anything if $referer is from my domain...

darknuke

the $referer variable before i think about... 4.3 is $HTTP_REFERER
hope that helps

dawson1323

Try it like this then:

if ((preg_match("/^{http://evilcity.com/i",$referer))} || (preg_match("/^{http://www.evilcity.com/i",$referer)))}
{
}

else

{
//Log it

}

darknuke

after that... i THINK its something like:
GLOBALS[HTTP_REFERER]

NYSiRacer

Originally posted by dawson1323
Try it like this then:

if ((preg_match("/^{http://evilcity.com/i",$referer))} || (preg_match("/^{http://www.evilcity.com/i",$referer)))}
{
}

else

{
//Log it

}

Yeah... I thought of that too, but then the code just looks kinda stupid..
is there another way around this?

To darknuke, it works fine without using globals... I think it's the ! (not) that's causing the malfunctions.

michael

Generically strstr works faster.

Michael