foreach error running under 4.2.3

dotcomtim

I am running the following script here at home on PHP 4.1.2 and it runs smoothly; when I up load the script to the server I am getting a foreach error on the $imgList under PHP 4.2.3

function to grab the images from directory

function getImgList($dir)
{
global $thumbFlag;
$handle = opendir($dir);

while ($file = readdir($handle))
{
	$ext = substr($file, strrpos($file, ".") + 1);

	if (eregi('^(jpg|gif|png|jpeg|jpe)$', $ext) && !ereg("($thumbFlag\.$ext)$", $file))
    	$imgList[] = $file;
}

closedir( $handle );

if (!empty($imgList))
{
	ksort($imgList);
	return $imgList;
}
else
{
	return False;
}

}

function to draw the table to build the thumbnails table which also has the foreach error

function thumbTable( $thumbRowCnt, $imgSpacing, $borderWidth, $borderColor )
{
global $thumbFlag, $gallery, $glocation, $imgList, $imgCnt;

if (!empty($borderWidth))
{
	$bStr1 = "<table cellspacing=\"" . $imgSpacing . "\" cellpadding=\"" . $borderWidth . "\" border=\"0\"><tr><td bgcolor=\"#" . $borderColor . "\">";
	$bStr2 = "</td></tr></table>";
	$imgSpacing = "0";
}
else
{
	$bStr1 = ""; $bStr2 = "";
}

echo "<table cellspacing=\"0\" cellpadding=\"0\" border=\"0\">\n";

$i = 1;
$count = 1;
foreach ($imgList as $img)
{

	$thumbURL = "$glocation" . ereg_replace("\.", "$thumbFlag.", $img);

	if ($i == 1)
	{
	echo "<tr>\n";
	}

	echo "<td>" . $bStr1;
	echo "<a onmouseover=\"window.status='CLICK TO DISPLAY LARGER PICTURE'; return true\" href=\"javascript:imgSubmit('?gallery=" . $gallery . "&imgNo=" . $count . "&imgCnt=" . $imgCnt . "');\">";
	echo "<img src=\"http://img.ebonyd.com" . $thumbURL . "\" border=\"0\" vspace=\"" . $imgSpacing . "\" hspace=\"" . $imgSpacing . "\"></a>";
	echo $bStr2 . "</td>\n";

	if ($i == $thumbRowCnt)
	{
		echo "\n</tr>\n";
		$i = 1;
	}
	else
	{
		$i++;
	}
	$count++;
}

echo "</table>\n";

}

ednark

please post the exact error

dotcomtim

Warning: Invalid argument supplied for foreach() in /home/htdocs/users/aplata/aplata/scripts/functions.php on line 130

philipolson

I'm guessing this is a register_globals issue. register_globals is a php directive, which is found in php.ini

When register_globals = on, then $id will exist from example.com/index.php?id=42 but if register_globals = off, $id will NOT exist. Regardless of the register_globals setting, you can go through predefined PHP variables.

As of PHP 4.1.0, PHP has autoglobals (also known as superglobals) available. For GET data (in the url), you can use $GET['id']. For POST data, $POST['foo'], etc. All this can be read about here:

In PHP 4.2.0, the default value for register_globals in php.ini went from ON to OFF. So if you're using the default php.ini, it's now off. Don't hesitate to modify your code to work with this directive being off.

dotcomtim

I double check at as well.. And I am sure it isn't a register_globals problems, when at home it does work.. and i have the following at the root of my website in and htaccess file ... php_flag register_globals off

So they have alsways been off.. Since I first written in I have found another area with the $imgList

var imgList = new Array(' 
Warning: Bad arguments to implode() in /home/htdocs/users/aplata/aplata/templates/gallerytop.php on line 31

the line looks like this: var imgList = new Array('<?= implode("', '", $imgList); ?>');

and the results is to look like this: var imgList = new Array('APPLES.JPG', 'PEARS.JPG', 'ORANGES.JPG');

It seems to be as if it isn't reading from the directory correctly. But if I am way off, and it is a register_globals thingy ... is there away to turn it on?

I did try 'register_globals on' but it didn't work.. I don't have access to the php.ini on the actual server itself...

dotcomtim

I found where I am getting the error.. but i still don't under stand why it doesn't work in php 4.2.3 but works in the other versions

if (eregi(".(jpg|gif|png|jpeg|jpe)$", $ext) && !ereg("($thumbFlag.$ext)$", $file))

If remove the thumbnail flag it reads all the images but if i leave it I am still getting the error:

var imgList = new Array(' Warning: Bad arguments to implode() in /home/htdocs/users/aplata/aplata/templates/gallerytop.php on line 31 

The script is suppose to read all the images in the directory then remove the images that don't have the thumbnail flag and in return produce a thumbnail gallary..

ie: all images ending with pic01t.jpg not pic01.jpg

philipolson

Take your code:

$imgList[] = $file; 
}

And underneath it make sure your regex is even passing any files into $imgList to implode. So:

$imgList[] = $file; 
}
var_dump($imgList);
exit;

If this array is empty, implode() will be given an empty array. Not good. Regarding your empty() check on $imgList, use count() instead as an empty array is not empty.

dotcomtim

I treid everones solutions but i am still getting the same error..
From the debugging I did it is finding and reading the images;

If it makes any sense this might be where the problem is if I remove the ! from the following line it reads all the images I need to search the array an only place thumbnail images..

!ereg("($thumbFlag\.$ext)$", $file))

that is what the code looks like now..

ereg("($thumbFlag\.$ext)$", $file))

that is what I did to get all the images to get pulled..

Is there another way to do this like the preg_

The directory has the following images:
pic1.jpg
pic1t.jpg
pic2.jpg
pic2t.jpg
pic3.jpg
pic3t.jpg and so on...

I want just the ones with the t in the name...

dotcomtim

I got it to work.. After the last post, it came to me so I tried it out and it works...

Thanks again for everyones help