eregi_replace problems

jesus_hairdo

I am attempting to do some simple custom bbcode type tags.
I have managed simple open and close tags fine.
The tags i am having problems with are the type which have parameters such as a URL tag. The problem i am having is actually retrieving the tag infomation.

Currently i have

$test_text = "[a=\"/it/?main_url=/it/helpdesk/smilies.html\"] here [/a] ";
$test_text2 = eregi_replace("\[a=(.)*\]", "<a href=\\1>", $test_text);
$test_text3 = eregi_replace("\[/a\]", "</a>", $test_text2);

which doesn't work, it just outputs

 
<a href=L>

Can someone give me a clue as to where i am going wrong??

Thanks

Jamie

tomhath

You need to escape the "[" and "]" characters. Thay have special meaning in regular expressions (define a character class).

rroc

$test_text2 = eregi_replace("[a=(.)*]", "<a href=\1>", $test_text);

That piece .* searches as many letter as possible, so in your case it replaces the whole string. i.e.

your string:
"[a=\"/it/?main_url=/it/helpdesk/smilies.html\"] here [/a] "

becomes understood like this(already in the first replacement):
"[a=.*] "

So, I'd use preg_replace, because there you can use the ?-sign to mean that you want as few letters as possible... This may seem a bit complicated, but it does the BOTH replacements you wanted at the same time:

 
$test_text = "[a=\"/it/?main_url=/it/helpdesk/smilies.html\"] here [/a] ";
$test_text2 = preg_replace("/(\\[a=)(.*?)\\](.*?)(\\[\\/a\\])/i","<a href=$2>$3</a>",$test_text);

also even if you'd do it using eregi, you'd have to use '\'-character to escape '[' and ']', because those are used for special purposes(defining for example a range of numbers i.e. [0-4] ). The syntax of preg is quite useful to learn if you're going to hang around with php for longer time. 🙂 Have fun.

jesus_hairdo

Thanks for this, i have a problem though.
I get a

'Warning Unknown modifier 'a' in filename on line 111'

(111 being the line with the preg_replace command in)
I'm guessing the problem is with the '[/a]' part of the pattern match, but quite what the problem is and how to solve it, i'm not sure.

Any ideas?

Thanks

Jamie

jesus_hairdo

With the help of bbencode_code() function from phpBB i have managed to correct the preg_replace, if i use

$text = preg_replace("/(\[a=)(.*?)\](.*?)(\[\/a\])/i","<a href=$2>$3</a>",$text);

It now works fine.

rroc

Heh 🙂

It seems you printed it wrong aswell!!! And it was not my fault and not your fault, but the forums fault! One has to type '\\' just to get one of those. So this is the correct line:

preg_replace("/(\\[a=)(.*?)\\](.*?)(\\[\\/a\\])/","<a href=$2>$3</a>",$test_text);