Passing variables to Javascript. Register Globals Off

baughmankr

OK. PHP gets me again.

I had a javascript program that used to work just fine. Then my ISP tightened up the security on PHP, turning "register globals" off among other things and now my Javascript went "North" and I can't figure out how to get it working again.

The problem is the "id" variable isn't being passed to the Javascript function from the anchor tag.

The program is a simple list of upcoming events on a client's page. When the page loads, we run a PHP routine that queries the database and lists the event title and the date. The user clicks on the event title and a popup window comes up with details about the event.

Here's the Javascript function:

function _onclick(id)
{
window.open('event.php?id='.concat(id),'Panel','location=no,toolbar=no,width=300,height=200');
return;
}

-->
</script>

Here's the code that passes the info.

<?php
$mysql_table = "event";
$sql_statement = "SELECT title,DbID,DATE_FORMAT(dt,\"%W, %b %e\") FROM ".$mysql_table." order by dt ";
$db = mysql_select_db("my_databasename", $link_id);
$result = mysql_query($sql_statement) or die(mysql_error());
if (mysql_num_rows($result) > 0){
while ($row = mysql_fetch_array($result)) {
?>
<strong><?php echo $row[2]?></strong><br>
<a href="javascript:_onclick(<?php echo $row[1]; ?>)" class="event"><?php echo $row[0]; ?></a><br>
<?php
}
}
?>

The error message we get in the popup window is:

" Error in query: SELECT event, title, DAYNAME(dt), MONTHNAME(dt), DAYOFMONTH(dt) FROM event where Dbid= "

which comes from "event.php", the script called by the Javascript function.

You can view the failed code at:

http://www.ci.conover.nc.us

Thanks for any help you can give this frustrated PHP user.

Cheers!

Kinney

jeremuck

hmmm well usually, when you turn register_globals off, it affects people who are using a form.
Instead of being able to access the variable implicitly by it's own name, they ave to access it explicitly through POST array or GET array depending on the method.

Here's what you can do... your php is probably getting the variable, but you need to access it differently.
so if you do this:
print_r($GLOBALS) you should be able to see it somewhere in there... and if it isn't it's own index into the globals array, you need to use the index that's shown.

hopefully you'll see when you look at it... if not, post the results here (or let us see them on your site) and we can help further.

baughmankr

Thanks for the pointer. Your suggestion paid off. After printing out all the Environment variables, I found what I was looking for and figured out how to get the variable. It was being passed, as you suggested. I just wasn't calling it correctly.

I've had a hard time understanding the ramifications of turning off globals. From the newsgroups, it appears I'm not the only one. I wish someone would write a nice tutorial or white paper explaining it all and post it on the PHP site. It would save many of us a lot of headaches if someone could explain in plain English just what to do. The discussion currently going on the PHP site in the online documentation for "Register Globals" goes right over my head.

And I'm 6'8" tall!!

Thanks again for your help.

Kinney