Counter resetting to 0

hatch789

Hi guys, I have a small snippet of code that I'll post. I use it for my counter, but I'm not sure why the damn thing resets to 0 so often. I am positive it is a concurrent access issue, but I don't know why it would be taking place. I am looking for suggestions on fixing it if someone can help me, I'd be very happy!

function HitCounter ($CounterFile)
{
if(file_exists($CounterFile)) {
if(!($fp = fopen($CounterFile, "r"))) return ("Cannot read $CounterFile? hmmm");
$count = (int) fread($fp, 30);
fclose($fp);

            $count++;
            $count2 = number_format($count);

            if (!($fp = fopen($CounterFile, "w"))) return ("Cannot write to $CounterFile. Did you chmod 666 the file?");
            fwrite($fp, $count);
            fclose($fp);

            return ($count);
    }

}

michael

chant('sql');

hatch789

Please forgive me but chant('sql'); means nothing to me. Unless it was a joke, in which case you're saying I'm screwed.

But on the 'glass is half full' side of life, I am sure there is a solution to this simple problem. If anyone out there could possibly contribute or help me, that would be great. I am rather stumped with this one?

Thanks,
-Chris

jeremuck

why not use a database?

using a text file is clunky, complex, and really just inapropriate.

A database will make your code easier to read and understand.

Jayson

You need to employ some kind of file locking mechanism. I'm not sure if it would solve your problem, but try it.

http://www.php.net/manual/en/function.flock.php

Change your code to:

function HitCounter ($CounterFile)
{
if(file_exists($CounterFile)) {
if(!($fp = fopen($CounterFile, "r"))) 
return ("Cannot read $CounterFile? hmmm");
flock($fp, 2);
$count = (int) fread($fp, 30);
flock($fp, 3);
fclose($fp);

$count++;
$count2 = number_format($count);

if (!($fp = fopen($CounterFile, "w"))) return ("Cannot write to $CounterFile. Did you chmod 666 the file?");
flock($fp, 2);
fwrite($fp, $count);
flock($fp, 3);
fclose($fp);

return ($count);
}
}

Its only an advisory lock and I don't know if it would work, but its worth a try. I don't have much knowledge of file locking in PHP.

A database would be better, but if all you want is a counter and nothing else than this would be fine if it works.