Problem: header already sent??

nmcglennon

I am trying to generate an Excel document from a database using PHP. A group called Darkstreak developed a function list to do this. Darkstreak's Website shows how to use his functions to accomplish this.

I have followed his coding only I slighly modified it to get data from my database:

<?php
$link = mysql_connect("localhost", username, password);
mysql_select_db (texasdeltachi_org);

	$query = "SELECT * FROM guestlist ORDER BY lname, fname";
$result = mysql_query ($query) or die ("Query failed");

require_once("functions.php"); 
deliveryfmt_initialize(); 
deliveryfmt_set_format('xls', false); 

header('Content-Type: '.deliveryfmt_mimetype());    	header('Content-Disposition: attachment;filename="guestlist.'.deliveryfmt_format_extension().'"');    	header('Expires: Mon, 26 Jul 1997 05:00:00 GMT'); 
header('Last-Modified: '.gmdate("D, d M Y H:i:s").' GMT'); 
$nocache = 'Cache-Control: no-cache'; // HTTP/1.1
if ($SERVER_PROTOCOL == 'HTTP/1.0') { $nocache = 'Pragma: no-cache'; } 
header($nocache);
header('Content-Transfer-Encoding: binary');

deliveryfmt_header();

$colnames = array(1=>'lastname', 2=>'firstname');
deliveryfmt_set_column_names($colnames);

	while($row = mysql_fetch_array($result))
	{
$data = array('lastname'=>$row["lname"], 'firstname'=>$row["fname"]);
	deliveryfmt_put_array($data);
	}

mysql_close($link); 
deliveryfmt_trailer(); 
$buffer = deliveryfmt_finish(); 
echo $buffer;

?>
[/SIZE]

Thats pretty simple, and I follow what he does down to a T. It should work like that, but it doesn't. I get the following errors:

Warning: Cannot add header information - headers already sent by (output started at /home/bkputh/texasdeltachi-www/act/f/gen.php:2) in /home/bkputh/texasdeltachi-www/act/f/gen.php on line 13

Warning: Cannot add header information - headers already sent by (output started at /home/bkputh/texasdeltachi-www/act/f/gen.php:2) in /home/bkputh/texasdeltachi-www/act/f/gen.php on line 14

Warning: Cannot add header information - headers already sent by (output started at /home/bkputh/texasdeltachi-www/act/f/gen.php:2) in /home/bkputh/texasdeltachi-www/act/f/gen.php on line 15

Warning: Cannot add header information - headers already sent by (output started at /home/bkputh/texasdeltachi-www/act/f/gen.php:2) in /home/bkputh/texasdeltachi-www/act/f/gen.php on line 16

Warning: Cannot add header information - headers already sent by (output started at /home/bkputh/texasdeltachi-www/act/f/gen.php:2) in /home/bkputh/texasdeltachi-www/act/f/gen.php on line 19

Warning: Cannot add header information - headers already sent by (output started at /home/bkputh/texasdeltachi-www/act/f/gen.php:2) in /home/bkputh/texasdeltachi-www/act/f/gen.php on line 20
LASTNAME FIRSTNAMEAltschul MattCarter MattDalton James Desai Kasul Grove Dave Krug Ryan LouAnthony

daynah

What's in functions.php ? Are there any echo/print statements?

You may want to move:

header('Content-Type: '.deliveryfmt_mimetype()); header('Content-Disposition: attachment;filename="guestlist.'.deliveryfmt_format_extension().'"'); header('Expires: Mon, 26 Jul 1997 05:00:00 GMT'); 
header('Last-Modified: '.gmdate("D, d M Y H:i:s").' GMT');

above the require_once() function. See if that helps.

nmcglennon

That didn't work... and the header functions use some nested functions from that required php file.

The functions in that file are the EXACT same as .here

jeremuck

I don't believe you showed ALL the output.

what's this?:
<?php
$link = mysql_connect("localhost", username, password);
mysql_select_db (texasdeltachi_org);

how come the db name is not in quote?

I bet you are getting a parser error, or warning at least.

Errors and warnings count as output, and you can't send headers after any output.
I bet putting the db name in quotes will fix the problem.

EDIT: on second thought that looks like a constant, however you haven't defined any constants. either way, I think that is the source of the problem. (Line 2 is that line, anyway, isn't it....)

nmcglennon

I am showing all the output... as far as the database stuff goes, thats all correct. I haven't had any problems with it in any other aspects. I changed the username and the password when I displayed it here...

I went ahead and changed the db name into quotes but same old story, same old song and dance...

jeremuck

do you have blank lines before the opening php tag?

It says that line 2 is giving output... is the dbname in a proper string format?

RobNewYork

For what its worth, unless you're doing some pretty fancy excel formatting, you might be better off just dumping an HTML table to excel instead.

Excel does a nice job of taking these (as is) and respects any cell backgrounds, colspans, rowspans, and widths applied during the HTML format process.

Include these lines at the beginning of your code:

header("Content-type: application/ms-excel");
header("Content-Disposition: attachment; filename=somefile.xls");
echo "\r\n";

Then send your <TABLE>...

Pretty straight forward and I've had excellent results with this approach.