upgrade to php4.2.3 problems

jowatkins

Hi,

I've just upgraded to php 4.2.3 and I'm now getting a lot of errors in my code that wasn't there before. I've had to go through and predefine all of my variables as I have been getting undefined variable messages and now it seems to be having a problem with the way I built the following two dimensional array.

$fieldsarray = array (
		array (name => "button", value => "no"),
		array (name => "chassis", value => "$chassis"),
		array (name => "productlevel", value => "$productlevel"),
		array (name => "status", value => "$status"),
		array (name => "originator", value => "$originator"),
		array (name => "assignedto", value => "$assignedto"),
		array (name => "area", value => "$area"),
		array (name => "drrank", value => "$drrank"),
		array (name => "datefrom", value => "$datefrom"),
		array (name => "dateto", value => "$dateto")
	);

Notice: Use of undefined constant name - assumed 'name'

Can anyone tell me whats going on? I was previously using php4.1.0 without these problems. I've looked through the change logs but I can't find anything that explains this. I don't want to go through and change all my code as there's hundreds of scripts.

Thanks in advance,

IceD

You should put name and value into quotes --> "name", "value"!!! This was the same in previous versions of PHP, but in 4.2.3 default error level is different...

Weedpacket

Well, you're using the constant name - PHP doesn't recognise this constant, so figures you meant the string'name'.

You've always been supposed to do this (and the reasons are described), but it's only been with your upgrade that the error reporting level has been set high enough for the warning to be displayed.

So... do the Right Thing and go

$fieldsarray = array(
  array('name' => 'button', 'value'=>'no'),
...
);

As for predefining variables - you should be doing that anyway; otherwise how can you trust them to have sensible values?