If - then ignored!?

[leatherback]

Hi All,

I am trying to get a page-label on top of each page I load. The coding is pasted below.

Strangely enough, the if - else which I use is ignored. When I show the $sublabels[pageID] and the $labels[pageID] I can see they are different (eg 3 vss 4), and still the code in the " if ($SubLabels[PageID] = $labels[PageID]) { } " section is executed.

It searches for a page with a specified subject, and page (nr) of 0 (That is the first in the series of nested pages, with the main label)

Is there an error here I am missing?

Thanks for your help!

Jelle

$labelQuery = " Select * from bioindex where bioindex.PageId = $id";
$LabelResult = mysql_query($labelQuery);
//echo $labelQuery;

while ($labels =@ mysql_fetch_array($LabelResult))
{
$Query = " Select * from bioindex where bioindex.Subject = $labels[Subject] and bioindex.page = 0";
$QueryResults = mysql_query($Query);
while ( $SubLabels =@ mysql_fetch_Array($QueryResults))
{
if ($SubLabels[PageID] = $labels[PageID]) {
$label = "$labels[topic]";
} else {
$label = "$labels[topic]>$SubLabels[topic]";
}
}
}

[leatherback]

Ah,
Stupid typing error,

1 '=' was missing in the if statement:

if ($SubLabels[PageID] = $labels[PageID]) {
should be
if ($SubLabels[PageID] == $labels[PageID]) {

[tomhath]

Why are you using the '@' symbol to suppress error messages?

Instead of hiding error messages, you should be using a 'OR die "message " . mysql_error();' clause after EVERY database hit. That way the you will see the error messages passed back when you give it an invalid query or non-resource (as you must be getting from the code you posted).

You missed quotes where needed and had them where not needed. This might be closer (untested):

$labelQuery = " Select * from bioindex where bioindex.PageId = $id"; 
$LabelResult = mysql_query($labelQuery) or die "bioindex.Pageid = $id query failed " .  mysql_error(); 
//echo $labelQuery; 

while ($labels = mysql_fetch_array($LabelResult)) 
{ 
  $Query = " Select * from bioindex where bioindex.Subject = '" . $labels["Subject"] . "' and bioindex.page = 0"; 

  $QueryResults = mysql_query($Query) or die "Subject = '" .  $labels["Subject"] . "' query failed " .  mysql_error(); 

  while ( $SubLabels = mysql_fetch_Array($QueryResults)) 
  { 
   if ($SubLabels["PageID"] = $labels["PageID"]) { 
    $label = $labels["topic"]; 
   } else { 
    $label = $labels["topic"] > $SubLabels["topic"]; 
   } 
  } 
}

[tomhath]

I missed the reason your "if" doesn't work, comparison uses ==, a single = is an assigment:

if ($SubLabels["PageID"] == $labels["PageID"]) {