Problem with nesting if's

[paul_v_l]

Can anyone please tell me why this crappy code keep's giving me the parse error? Below you will find a piece of the code that should be causing it. For the complete code please check the attachment. The error occurs on line 10 of the file.

Thank a lot for reading (and reacting),

Paul van Leeuwen

By the way: The original attachment was a .php file, but I had to rename it to an .txt to be able to post it here.

<?PHP if ($row = MYSQL_FETCH_ARRAY($result, MYSQL_BOTH))
{
if (!(isset($geselecteerdepilot)))
{$geselecteerdepilot=$row["naam"]}
else
($geselecteerdepilot=rawurldecode($geselecteerdepilot)};
}
else
{
if (!(isset($inhoud)))
{$inhoud=$row["link"]}
else
{$inhoud=rawurldecode($inhoud)};
}?>

[Weedpacket]

You're missing a bunch of semicolons. If you read the error message you'll see that PHP is complaining about an unexpected } in the fourth line of your sample.

[paul_v_l]

Thanks for reacting. I might still be typing 2 left hands, but this code doesn't seem to work also:

<?PHP if ($row = MYSQL_FETCH_ARRAY($result, MYSQL_BOTH))
{
   if (!(isset($geselecteerdepilot)))
      {$geselecteerdepilot=$row["naam"];}
   else
      {$geselecteerdepilot=rawurldecode($geselecteerdepilot);};
}
else
{
   if (!(isset($inhoud)))
      {$inhoud=$row["link"];}
   else
      {$inhoud=rawurldecode($inhoud);};
}
?>

I believe this is the syntax by the manual (or not, since it still does not work). If you/anyone have/has any sugestion on what goes wrong: please don't hesitate to drop a line.

This has really got me stuck.

Thanks again in advance.

Paul van Leeuwen

[ednark]

your code is stylistically hard to read... you should break it up more so you can see what is happenging... and try to put echo comments in there so you can see what is and what is not executing...

there a a bunch of things wrong with this code... mostly logical... however i would get rid of the ';' after the '}' as it is unnecessary

this is the file i was testing on...

<?php

/// set initial values or comment this out
/*
$geselecteerdepilot = 'pilot%20name';
$inhoud = 'in%20hound';
*/

/// fake database query
$row = array( 'naam'=>'ednark', 'link'=>'www.phpbuilder.com' );
$database_faked = TRUE;

/// show what we have
echo "<br>CURRENT VARS: <br>";
echo "&nbsp;&nbsp;&nbsp;&nbsp;geselecteerdepilot = '$geselecteerdepilot' <br>";
echo "&nbsp;&nbsp;&nbsp;&nbsp;inhoud = '$inhoud' <br><br>";


/// if we got the row from the database
if ( $database_faked )
{
    echo "we have a result from the database<br>";
    /// if geselecteerdepilot has not been set
    if ( !(isset($geselecteerdepilot)) )
    {
        echo "geselecteerdepilot has not been set :: set it from the database<br>";
        /// set geselecteerdepilot to 'naam' from the database
        $geselecteerdepilot = $row["naam"];
    }
    /// if geselecteerdepilot has a previous value
    else
    {
        echo "geselecteerdepilot has been previously set :: rawurldecode it<br>";
        /// rawurldecode geselecteerdepilot
        $geselecteerdepilot = rawurldecode($geselecteerdepilot);
    };

}
/// we did not get the row from the database
else
{

echo "there is no result from the database<br>";
/// if $inhound has not been set
if ( !(isset($inhoud)) )
{

    echo "inhoud has not been set :: set it from the database<br>";
    /// set inhound from the database
    $inhoud = $row["link"];
}
/// if geselecteerdepilot has a previous value
else
{
    echo "inhoud has been previously set :: rawurldecode it<br>";
    /// rawurldecode inhound
    $inhoud = rawurldecode($inhoud);
};
}

/// show what we have
echo "<br>CURRENT VARS: <br>";
echo "&nbsp;&nbsp;&nbsp;&nbsp;geselecteerdepilot = '$geselecteerdepilot' <br>";
echo "&nbsp;&nbsp;&nbsp;&nbsp;inhoud = '$inhoud' <br><br>";

?>

[Weedpacket]

<?php
if($row = mysql_fetch_array($result, MYSQL_BOTH))
{ if(isset($geselecteerdepilot))
    $geselecteerdepilot = rawurldecode($geselecteerdepilot);
  else
    $geselecteerdepilot = $row['naam'];
}
else
{ if(isset($inhoud))
    $inhoud = rawurldecode($inhoud);
  else
    $inhoud = $row['link'];
}
?>

Or

<?php
if($row = mysql_fetch_array($result, MYSQL_BOTH))
  $geselecteerdepilot = isset($geselecteerdepilot)
                      ? rawurldecode($geselecteerdepilot)
                      : $row['naam'];
else
  $inhoud = isset($inhoud)
          ? rawurldecode($inhoud)
          : $row['link'];
?>

Either is syntactically correct. But what happens if $row is false
because there wasn't a result? $row['link'] won't have a value and then
you're in trouble...

As ednark's code points out:

{//we did not get the row from the database
  {// if $inhoud has not been set
    {// set inhoud from the database

[/code]

[paul_v_l]

Hmm... Your right! Looking back at my own code makes my selfrespect drop to point zero.

At the other hand, it was 3:30 o clock in the middle of the night when I posted the question, so I wasn't that focused anymore. 😃

Anyway the fresh new code works splendit so I gues that makes me your humbel servant for the rest of my life.

Thnx
Paul van Leeuwen