upload error

rulian

On my local apache server, the code works fine, online the upload code produces this error:

Warning: Unable to open 'D:\Websites\folder\file.jpg' for reading: No such file or directory in /mysite/www/manage/submit.php on line 216
Error uploading the file

here is the code for the upload:

function upload_form($message){

if (isset($message)) echo $message;

@$big=$_POST["big"];

@$small=$_POST["small"];

@$smallest=$_POST["smallest"];

@$title=$_POST["title"];

@$description=$_POST["description"];

@$artist=$_POST["artist"];

echo "

<tr>

<td>

  <table width='100%' border='0' cellspacing='0' cellpadding='0'>

    <tr> 

      <td>Artwork Submittion</td>

    </tr>

    <tr> 

      <td>

        <table width='100%' border='0' cellspacing='0' cellpadding='0'>

          <tr> 

            <td width='27%'>Title:</td>

            <td width='73%'> 

              <input type='text' name='title' value='$title'>

            </td>

          </tr>

<tr>

            <td width='27%'>Artist:</td>

            <td width='73%'> 

              <input type='text' name='artist' value='$artist'>

            </td>

          </tr>

<tr>

            <td width='27%'>50 x 50:</td>

            <td width='73%'> 

              <input type='file' name='smallest' value='$smallest'>

            </td>

          </tr>

<tr>

            <td width='27%'>160 x 120:</td>

            <td width='73%'> 

             <input type='file' name='small' value='$small'>

            </td>

          </tr>

          <tr> 

            <td width='27%'>Bigone:</td>

            <td width='73%'> 

              <input type='file' name='big' value='$big'>

            </td>

          </tr>

          <tr> 

            <td width='27%'>Description</td>

            <td width='73%'> 

              <textarea name='description' cols='40' rows='10' wrap='VIRTUAL'> $description</textarea>

            </td>

          </tr>

          <tr>

            <td width='27%'>&nbsp;</td>

            <td width='73%'>

              <input type='submit' name='Submit' value='Submit'>

            </td>

          </tr>

        </table>

      </td>

    </tr>

  </table>

</td>

</tr>

</table>

</form><br>

<tr>

<td><b><font color='#990000'>PLEASE NOTE!</font></b></td>

</tr>

<tr>

<td> 

  <p>NAME YOUR FILES YOURNAME_TITLE, KEEP YOUR TITLES UNIQUE! </p>

  </td>

</tr>

</table>

}

function writefile($id){

@$big=$_POST["big"];

@$small=$_POST["small"];

@$smallest=$_POST["smallest"];

@$title=$_POST["title"];

@$description=$_POST["description"];

@$artist=$_POST["artist"];

$directoryb='../artwork';
$directorys='../artwork/smalls';
$directorys2='../artwork/buttons';

$bigname=basename($big);

$smallname=basename($small);

$smallestname=basename($smallest);

if (!copy($big, "$directoryb/$bigname"))

{ echo "Error uploading the file"; dodelete($id); }

else {
if (!copy($small, "$directorys/$smallname"))

{ echo "Error uploading the file"; dodelete($id); }
else {
if (!copy($smallest, "$directorys2/$smallestname"))

{ echo "Error uploading the file"; dodelete($id); }

else {echo "Your upload worked<br><a href='http://www.artistan.com/artwork.php?id=$id'><font color=black>Go to your artpiece</a></font>";}
}
}

}

function dodelete($id){

$do=mysql_query("DELETE from artwork where artid='$id'");

if (!$do) echo "Sorry, could not delete rows";

}

function writedb(){

global $link_id;

@$big=$_POST["big"];

@$small=$_POST["small"];

@$smallest=$_POST["smallest"];

@$title=$_POST["title"];

@$description=$_POST["description"];

@$artist=$_POST["artist"];

if ((!isset($big)) or ($big=="")) upload_form("No big file to upload");

else {

if ((!isset($title)) or ($title=="")) upload_form("You did not specify a title");

else {

if ((!isset($smallest)) or ($smallest=="")) upload_form("You did not upload a 50 x 50");

else {

if ((!isset($description)) or ($description=="")) upload_form("You did not specify a description");

else {
if ((!isset($small)) or ($small=="")) upload_form("You did not upload a 160 x 120");

else {
if ((!isset($artist)) or ($artist=="")) upload_form("You did give your name");

else {

$doit=mysql_query("INSERT INTO artwork values (null,'$title','$artist','$big','$small','0','0','0', '0', NOW(), '$description','$smallest')");

if (!$doit) echo "Error inserting file into DB";

else {

$id=mysql_insert_id($link_id);

if ($id) {

writefile($id);}

else dodelete($id);

}

}}}}}}

}

@$do=$_POST['do'];

if ((isset($do)) AND ($do=='write')) writedb();

else upload_form(" ");

Weedpacket

Originally posted by rulian
Warning: Unable to open 'D:\Websites\folder\file.jpg' for reading: No such file or directory in /mysite/www/manage/submit.php on line 216
Error uploading the file

You know, call me a wild unprincipled fool, but maybe the problem is because there is no such file or directory as "D:\Websites\folder\file.jpg' on the server.

harlowhair

Your code seem slightly over complex to me, and I can't see either where the file 'D:\Websites\folder\file.jpg' is created. Couple of fundamentals though, I always use forward slash (/) when specifying paths, regardless of OS. Also, there should be a hidden field in your form specifying the maximumn file size for HTTP uploads e.g:

which limits the file size to 1mb. I THINK that this is a required field. If you are using a recent version of PHP, why not use the inbuilt fileupload functions, such as:

if(!is_dir("d:/websites/folder/file.jpg"))
{
	mkdir("d:/websites/folder/file.jpg");
}
if (is_uploaded_file($uploadedimg))
{
	move_uploaded_file ($uploadedimg, "d:/websites/folder/file.jpg/" . $uploadedimg_name);
}

where $uploadedimg is the uploaded image (name of the file control in the form), and its attributes can be accessed using:

$uploadedimg_name - actual filename
$uploadedimg_size - filesize and theres loads more, they're all in the manual. Not sure if any of this is any help, but just thought I'd try

michael

1000000 is not one megabyte. It's one million bytes. The bb and mb are advertising terms. Mb is 1048576

Weedpacket

Originally posted by harlowhair
Your code seem slightly over complex to me, and I can't see either where the file 'D:\Websites\folder\file.jpg' is created. Couple of fundamentals though, I always use forward slash (/) when specifying paths, regardless of OS.

Of course, if the server is a *nix (as it appears to be from the given error message)...

rulian

Well, i'm trying to use $_FILE now to do it, but my variable keeps coming up empty