Problem on line 55, not sure what.

nexgen_x

Hi all,
I'm pretty new to PHP, coming from a background of just boring html. Anyway, this is my first attempt at a script that I can actually use (ie. I've moved on from "hello world" 😃), but when I try and run it, I get the error:
"Parse error: parse error, unexpected T_STRING in /home/virtual/site76/fst/var/www/html/PHP/script.php on line 55"

I can't see whats wrong on line 55... Can someone help me out? And perhaps point out bits of particularly crappy coding, or bits that could be shortened into simpler code? The form that is used to obtain the variables for this code can be found at
www.lore-league.com/PHP/form.html

Cheers.

<?
//check fields have been correctly filled out
if($email = "") {
	$error = "Please enter an email address";
	ErrorPage($error);
}

if($password!=$passwordverify) {
	$error = "Passwords did not match";
	ErrorPage($error);
}

if($username = "") {
	$error = "Please enter a username";
	ErrorPage($error);
}

Else {
	PrintConfirm($encryptedpass);
	$encryptedpass = md5($password);

//compose email here
$to = $email;
$subject = "Application Recieved Successfully";
$message = "Hello $username, "
. "Your application was recieved successfully."
.""
.""
."Your username is $username"
."Your password is $password"
.""
."Thanks,"
." -Ben";
//send mail here
mail($to,$subject,$message, "From: [email]nexgen_x@hotmail.com[/email]", "nexgen_x@hotmail.com");
}


// functions (ErrorPage, PrintConfirm, PrintHeader & PrintFooter)

function ErrorPage($error) {
	$title = "Error!";
	PrintHeader($title);
	Print "There was an error processing your application:";
	Print "";
	Print $error;
	PrintFooter("");
}

function PrintConfirm ($encryptedpass) {
	$title = "Confirmation";
	PrintHeader($title);
	Print "Your application was successfully processed.  You should recieve an email with your application details in the next 24 hours.";
	Print "Just for your amusement, your encrypted password is: $encryptedpass ."
//the line below is line 55 (well, 56 now, but y'know :P)
PrintFooter();  

}

function PrintHeader($title) {
	Print "<html>";
	Print "<head><title>$title</title></head>";
	Print "<body>";
}

function PrintFooter () {
	Print "</body>";
	Print "</html>";
}

?>

[deleted]

The problem is actually on the line just before it:

Print "Just for your amusement, your encrypted password is: $encryptedpass ."

that should have a semi-colon at the end....

nexgen_x

Oops, lol - can't believe I didn't notice that. In fact I added it at the very last minute, just because I felt like seeing what it looked like encrypted, hah. Musta rushed it.

Thanks for pointing that out.

br__ken

try this

// defaults
$err=false;
$err_reason="";
// see whats missing 
if(empty($email)) $err=true;$err_reason.="<li>Email not entered";
if($password!=$passwordverify) $err=true;$err_reason.="<li>Passwords did not match";
if(empty($username)) $err=true;$err_reason.="<li>No usename entered";

if($err):
	// error = true, so print the reason(s)
	ErrorPage($err_reason);
else:
    $encryptedpass = md5($password);

//compose email here
$to = $email;
$subject = "Application Recieved Successfully";
$message = "Hello $username, \n"
. "Your application was recieved successfully.\n"
."\n"
."\n"
."Your username is $username\n"
."Your password is $password\n"
."\n"
."Thanks,\n"
." -Ben";
//send mail here
if(mail($to,$subject,$message, "From: [email]nexgen_x@hotmail.com[/email]", "nexgen_x@hotmail.com"))
	PrintConfirm($encryptedpass);
else
	ErrorPage("Mail failed");
endif;


// functions (ErrorPage, PrintConfirm, PrintHeader & PrintFooter)

function ErrorPage($error) {
    $title = "Error!";
    PrintHeader($title);
    echo "There was an error processing your application:";
    echo "<ul>$error</ul>";
    PrintFooter("");
}

function PrintConfirm ($encryptedpass) {
    $title = "Confirmation";
    PrintHeader($title);
    echo "Your application was successfully processed.  You should recieve an email with your application details in the next 24 hours.";
    echo "Just for your amusement, your encrypted password is: $encryptedpass ."
//the line below is line 55 (well, 56 now, but y'know :P)
PrintFooter();  

}

function PrintHeader($title) {
    Print "<html>";
    Print "<head><title>$title</title></head>";
    Print "<body>"
}

function PrintFooter () {
    Print "</body>";
    Print "</html>";
}

nexgen_x

Thanks, I understand most of that.

One question, though: whats the difference between

if($err):
    ErrorPage($err_reason);

and

if($err) {
  ErrorPage($err_reason);
}

?
Or is there none, and using : is just easier? 😉

Cogen

When doing "if" statements, you can leave out the curling brackets if you only have one line/statement in the If statement ...

Your example works fine, but it you wanted to do ...

if($err) {
  x = 1;
  ErrorPage($err_reason);
}

Then you couldn't do ..

if($err):
    x = 1;
    ErrorPage($err_reason);

Beause only the x = 1 is part of the if statement code, the ErrorPage line will run whether the If statment is true or false.

nexgen_x

Thanks.
Couple of final questions regarding

if(empty($email)) $err=true;$err_reason.="<li>Email not entered";

Firstly, is that the same as writing:

if empty($email) {
  $err=true;
  $err_reason.="<li>Email not entered";
}

And secondly, what does the full stop before the equals after $err_reason represent?

Thanks again,

br__ken

for the question of

if(conditon):

theres a number of ways to write an if statment 🙂 heres a few
i chose using a : and endif; because its just cleaner (imo) and since it was only 1 line you could also have done

if($err)
ErrorPage($err_reason);
else{
the rest
}
they are basically variations

<?
// the most known
if($x==1)
{ 
  echo "hello";
}else{
 echo "world";
}

// the 1 liner (w/o curly braces)
if($x==1)
 echo "hello";
else
 echo "world";

// and my fav (somewhat vb style) it cuts down on the braces and 
// imo doesnt confuse me when i have about 5 nested statements and 10000 { everythere 

if($x==1):
 echo "this";
 echo "can";
 echo "be more than";
 echo "1 line";
else:
 echo "same";
 echo "with this";
endif;
// just remember the endif; at the end - same with while(): endwhile;
?>

yeah both of your if statements are the same, i just wrote it on 1 line to save space..
im not sure what u meant by the other question tho

-r

nexgen_x

$err_reason.=

I mean, what does the period before the = do?

Cogen

huh????? That's cool! I'll use that vb version from now on. Just a personal preference, but I like the looks of that. 🙂

Cogen

The period just means concatenate the current contents of the variable with the new contents.

Example ...

$err_reason = "hello" /is equal to hello

$err_reason .= " world" / is equal to hello world

br__ken

Originally posted by Cogen
huh????? That's cool! I'll use that vb version from now on. Just a personal preference, but I like the looks of that. 🙂

it also works with:

while($x<10):
 ++$x;
endwhile;

// and //
for($x=0;$x<10;$x++):
 echo "x=$x<br>";
endfor;

it might work for more but i cant remember, its a lot cleaner when you write huge pages since brackets tend to make your eyes bleed