Can anyone figure this out? Or help me..

kpowning

I'm very new with all of this and I was wondering if someone can tell me what I'm doing wrong and maybe point me in the right direction. I have a database all designed with a table that included the fields:
User Name
Email Address
Password
Verify Password.

I'm using Dreamweaver MX and I have made a registration form that I'm trying to implement into my website so that my customers can register to become a member. I can't seem to get this form to enter the data that I'm trying to collect into the database fields. I keep getting an error: column "User Name" cannot be "NULL". Does anyone have any ideas for me. I would absolutely appreciate it greatly. Below is the copy of my code for the registration form:

<?php require_once('file:///E|/Gspot%20Website/Connections/GspotMembers.php'); ?>
<?php
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "")
{
$theValue = (!get_magic_quotes_gpc()) ? addslashes($theValue) : $theValue;

switch ($theType) {
case "text":
$theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
break;

case "long":
case "int":
$theValue = ($theValue != "") ? intval($theValue) : "NULL";
break;
case "double":
$theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
break;
case "date":
$theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
break;
case "defined":
$theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
break;
}
return $theValue;
}

$editFormAction = $HTTP_SERVER_VARS['PHP_SELF'];
if (isset($HTTP_SERVER_VARS['QUERY_STRING'])) {
$editFormAction .= "?" . $HTTP_SERVER_VARS['QUERY_STRING'];
}

if ((isset($HTTP_POST_VARS["MM_insert"])) && ($HTTP_POST_VARS["MM_insert"] == "Register")) {
$insertSQL = sprintf("INSERT INTO Members (User Name) VALUES (%s)",
GetSQLValueString($HTTP_POST_VARS['User Name'], "text"));

mysql_select_db($database_GspotMembers, $GspotMembers);
$Result1 = mysql_query($insertSQL, $GspotMembers) or die(mysql_error());

$insertGoTo = "file:///E|/Gspot Website/Successfulpayment.htm";
if (isset($HTTP_SERVER_VARS['QUERY_STRING'])) {
$insertGoTo .= (strpos($insertGoTo, '?')) ? "&" : "?";
$insertGoTo .= $HTTP_SERVER_VARS['QUERY_STRING'];
}
header(sprintf("Location: %s", $insertGoTo));
}
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>Registration</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<form name="form1" method="POST" action="<?php echo $editFormAction; ?>">
<p>Username:
<input name="UserName" type="text" id="UserName">
</p>
<p>
<input type="submit" name="Submit" value="Submit">
</p>
<input type="hidden" name="MM_insert" value="Register">
</form>
</body>
</html>

philipolson

This code seems overly complicated. Anyway, you can't use spaces in variables so don't use 'User Name' anywhere. You are trying to access the "User Name" as an array key, that won't work. It looks like "UserName" is what you want as that's what your form uses.

Btw, all values through HTTP are strings. And, PHP is a very loose language and rarely cares about types.

kpowning

I appreciate the information, but I'm still left pretty confused here. Does this code seem to look okay, or should I not use certain things? Like I said, "I don't know sh_t.. About PHP and SQL, just yet. I'm trying to learn..

Thanks.
Kyle

philipolson

A tip: Don't use spaces. Spaces bad. Don't use them in variable names, in mysql column names, anywhere! (except values 😉

Here's one way to write your code. It's not identical and actually is different in some ways but hopefully will give you an idea or two. There are unlimited ways to do it, the following will show a few methods:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> 
<html> 
<head> 
  <title>Registration Form</title>
</head> 
<body>
<?php
// If the form hasn't been submitted yet, show the form
if (empty($HTTP_POST_VARS['mm_insert'])) {
?>
<form name="form1" method="POST" action="<?php echo $HTTP_SERVER_VARS['PHP_SELF']; ?>">
<p>Username: <input name="username" type="text" id="username"></p> 
<p><input type="submit" name="submit" value="submit"></p>
<input type="hidden" name="mm_insert" value="Register"> 
</form>

<?php
// Form has been submitted, process it
} else {

$username = $HTTP_POST_VARS['username'];

// You may want to check alphanumeric, etc.
// And maybe put your form in a include, include it here
if (strlen($username) < 3) {
    print "Please go back and choose a username longer than two characters.";
    exit;
}

if (!get_magic_quotes_gpc()) {
    $username = addslashes($username);
}

$conn = mysql_connect($host, $user, $pass);

if (!$conn) {
    print "Could not connect to database";
    exit;
}

mysql_select_db($dbname);

$sql = "SELECT count(username) FROM members WHERE username = '$username'";
$result = mysql_query($sql);

// Maybe include the form here too, instead of forcing a back button
if (mysql_result($result, 0) > 0) {
    print "Please go back and choose another username, this one is taken!";
    exit;
}

$sql = "INSERT INTO members (username) VALUES ('$username')";

$result = mysql_query($sql);

if (!$result) {
    print "Could not run query ($sql), error: " . mysql_error();
    exit;
}

$username = stripslashes($username);
print "<p>Success!  Thanks for registering $username as a username</p>";

include 'successful_registration.php';
}
?>
 </body> 
</html>

Also, learn SQL: http://www.w3schools.com/sql/