trying to sort results, problem with variables

horstuff

This code is supposed to pull results from the databse and then allow options for how to sort it. It pulls all the data good enough, but when you try to sort it by using the links, it doesn't work. Any ideas? Thanks.

$query = "select DISTINCT manufacturer from product_status ORDER BY manufacturer ASC";
$result = mysql_query($query);
$num_results = mysql_num_rows($result);
for ($i=-0; $i <$num_results; $i++)
{
$row = mysql_fetch_array($result);
$myvarm = $row["manufacturer"];
echo "<a href='admin.php?sview=$myvarm'>$myvarm";
echo"</a>";
echo " | ";

}
print " SORT BY: ";
print "<a href='admin.php'>Product ID</a> | <a href='admin.php?view=sku$sview'>SKU</a> | <a href='admin.php?view=status$sview'>Stock Status</a> ";{
if (isset($view) and ($view == "sku$sview")) {
$query = "SELECT product_id,manufacturer,product_name,product_price,product_sku,shipping,stock_status,stock_comment FROM product_status WHERE manufacturer='$sview' ORDER BY product_sku ASC";
}else if (isset($view) and ($view == "status$sview")) {
$query = "SELECT product_id,manufacturer,product_name,product_price,product_sku,shipping,stock_status,stock_comment FROM product_status WHERE manufacturer='$sview' ORDER BY stock_status ASC";
}else{
$query = "SELECT product_id,manufacturer,product_name,product_price,product_sku,shipping,stock_status,stock_comment FROM product_status WHERE manufacturer='$sview' ORDER BY product_id ASC";
}
$result = mysql_query($query) or die("Query failed really bad");

tomhath

Where is variable $sview set? You use it but never give a value that I can see.

This would've been easy to spot if you had echoed $query and what mysql_error() returns. You can echo them into an HTML comment line while debugging and view the source from the browser if you don't want to disturb the page that should be displayed.

horstuff

can you give me an example of how to set it? The results are showing up now when the link is clicked that was created from the top query, and then I just want to sort the results that are being pulled by sku, stock status, or product id. Thanks.

tomhath

The first list of links have this:

The GET will have "sview" but not "view", so the isset($view) will always fail when this link is clicked.

The second block of links have this:

The only parameter passed back in the GET is "view", not "sview" so the WHERE manufacturer='$sview' will fail when this link is clicked.

It looks like in the second set of links you need to pass back both view and sview as parameters to the GET.