Undefined variable

wacook

with php 4.1.1 this code works with no errors with 4.2.2 I get undefined variable errors:

Notice: Undefined variable: tempString in c:\program files\apache group\apache\htdocs\ame\test\amttest\htmltable.php on line 69

This is the code:
function render() {

while(list($k,$v) = each($this->rows)) {
if ($color == '#999999') {
$color = '#CCCCCC';
} else {
$color = '#999999';
}

$tempString .= $v->render($color);
}
return "<table width=\"".$this->width."\" border=\"".$this->border."\">$tempString</table>";
}
}

Weedpacket

You're using a variable on line 69 before you've given it a value. (PHP 4.1.1 would have complained if you had set its error-detection level high enough).

As you know that line would take the values of $tempString and $v->render($color), concatenate them, and put the result in $tempString. If $tempString doesn't have a value, PHP will whinge.

It's generally not a Good Thing to use undefined variables - you can't really trust their values, which is why PHP's default error-reporting level has been raised.
So before you get into this loop,
$tempString='';
and you won't be using it before it's been given a value.