Code not updating database

[[deleted]]

This is a snippet of code that I'm having a problem with. When I run the Update part of the query in phpmyadmin it works fine, not here. I have echoed the query to make sure it reads what I expect and it does. The form is processing (but not updating) because I get the result "Update Successful".

Any ideas on how to further debug? Does anyone see a coding error?

Thanks.

if ($mod == 'news' AND $action == 'edit')

if (!$submit)
{
$qryEditPressRelease = "SELECT PressReleaseHeadline, PressReleaseDate, PressReleaseContent,PressReleaseContName FROM tblPressRelease WHERE PressReleaseID='$id'";
$rsltEditPressRelease = mysql_query($qryEditPressRelease);

// if records present
if (mysql_num_rows($rsltEditPressRelease) > 0)
{
// iterate through resultset
// print title with links to edit and delete scripts
while($edit_pr_row = mysql_fetch_object($rsltEditPressRelease))
{
{
echo "
<form action=\"".$PHP_SELF."\" method=\"POST\">
PressReleaseID = $id <br><br>
<input type=\"hidden\" name=\"PressReleaseID\" value=\"".$id."\">
<table width=\"100%\" cellspacing=\"0\" cellpadding=\"0\" align=\"center\">
<tr>
<td align=\"left\"> <font size=\"-1\"><b>Headline:<input name=\"PressReleaseHeadline\" type=\"text\" value=\"".$edit_pr_row->PressReleaseHeadline."\"></b><br>
<br>Date:[".formatDate($edit_pr_row->PressReleaseDate)."]</font> <br> <font size=\"-2\">
<p></td></tr>
<tr><td><b><font size=\"-1\">Contact:<input name=\"PressReleaseContName\" type=\"text\" value=\"".$edit_pr_row->PressReleaseContName."\"></b><br><br></td></tr>
<tr>
<td align=\"left\"> <font size=\"-1\"><b>Content:<br><textarea cols=\"40\" rows=\"10\" name=\"PressReleaseContent\"> ".$edit_pr_row->PressReleaseContent." </textarea></b>

<p></td></tr>
<tr><td align=\"center\" colspan=2><input type=\"Submit\" name=\"submit\" value=\"Update\"></td>
</tr>
</form>
";
}
}
}
}

// form submitted
// start processing it
else
{
// set up error list array
$errorList = array();
$count = 0;

// validate text input fields
if (!$PressReleaseHeadline) { $errorList[$count] = "Invalid entry: PressReleaseHeadline"; $count++; }

if (!$PressReleaseContent) { $errorList[$count] = "Invalid entry: PressReleaseContent"; $count++; }

// set default value for contact person
if (!$PressReleaseContName) { $PressReleaseContName = $Def_Contact; }

// check for errors
// if none found...
if (sizeof($errorList) == 0)
{
// open database connection
$connection = mysql_connect($host, $user, $pass) or die ("Unable to connect!");

// select database
mysql_select_db($db) or die ("Unable to select database!");

// generate and execute query
$qryUpdatePressRelease = "UPDATE tblPressRelease SET PressReleaseHeadline = '$PressReleaseHeadline', PressReleaseContent = '$PressReleaseContent', PressReleaseContName = '$PressReleaseContName', PressReleaseDate = NOW() WHERE PressReleaseID = '$id'";
$rsltPressReleaseUpdate = mysql_query($qryUpdatePressRelease) or die ("Error in query: $qryUpdatePressRelease. " . mysql_error());

// print result
echo "<font size=-1>Update successful. <a href=list.php>Go back to the main menu</a>.</font>";

[wilsonodk]

I see several small coding problems,
like some missing or misplace curly quotes, "{" or "}".

notice the first line of the code you posted...
no curly quote, not even below it.

also, after the [font=new courier]while[/font] statement
you have two opening curlies "{{"

my advice would be to go through the code indenting all the code within a curly bracket set. Do this line by line, so you can keep track of curlies.

also the try to avoid...

}
//
//
else {

its confusing.

you do a good job with comments though

Also, in the future when posting code wrap it in php code blocks {php}
where { is subsituted for [ and } is subsituted for ]
It helps us help you.

Thx

[mitakadai]

Shouldn't it be
if ($submit)
instead of
if (!$submit)

where are your variable values coming from if not from the submitted form????

[[deleted]]

I didn't want to put in all the code because it's a little long, but to clarify things here it is:

Up here I have the config file stating db name, etc.

<?php

// generate and execute query list Press Releases
$qryListPressRelease = "SELECT PressReleaseID, PressReleaseHeadline, PressReleaseDate, PressReleaseContent FROM tblPressRelease ORDER BY PressReleaseDate DESC";
$rsltListPressRelease = mysql_query($qryListPressRelease) or die ("Error in query: $qryListPressRelease. " . mysql_error());

// if records present
if (mysql_num_rows($rsltListPressRelease) > 0)
{
// iterate through resultset
// print title with links to edit and delete scripts
while($row = mysql_fetch_object($rsltListPressRelease))
{

if ($mod == 'news' AND $action == 'display')
{
echo "
<table width=\"100%\" cellspacing=\"0\" cellpadding=\"0\" align=\"center\">
<tr>
<td align=\"left\"> <font size=\"-1\"><b>$row->PressReleaseHeadline</b>
[".formatDate($row->PressReleaseDate)."]</font> <br> <font size=\"-2\"><a href=\"?id=$row->PressReleaseID&mod=$mod&action=edit\">edit</a>
| <a href=\"?id=$row->PressReleaseID&mod=$mod&action=delete\">delete</a></font>
<p></td>
</tr>
";
}
}
}
if ($mod == 'news' AND $action == 'edit')

if (!$submit)
{
$qryEditPressRelease = "SELECT PressReleaseHeadline, PressReleaseDate, PressReleaseContent,PressReleaseContName FROM tblPressRelease WHERE PressReleaseID='$id'";
$rsltEditPressRelease = mysql_query($qryEditPressRelease);

// if records present
if (mysql_num_rows($rsltEditPressRelease) > 0)
{
// iterate through resultset
// print title with links to edit and delete scripts
$edit_pr_row = mysql_fetch_object($rsltEditPressRelease);

echo "
<form action=\"".$PHP_SELF."\" method=\"POST\">
PressReleaseID = $id <br><br>
<input type=\"hidden\" name=\"PressReleaseID\" value=\"".$id."\">
<table width=\"100%\" cellspacing=\"0\" cellpadding=\"0\" align=\"center\">
<tr>
<td align=\"left\"> <font size=\"-1\"><b>Headline:<input name=\"PressReleaseHeadline\" type=\"text\" value=\"".$edit_pr_row->PressReleaseHeadline."\"></b><br>
<br>Date:[".formatDate($edit_pr_row->PressReleaseDate)."]</font> <br> <font size=\"-2\">
<p></td></tr>
<tr><td><b><font size=\"-1\">Contact:<input name=\"PressReleaseContName\" type=\"text\" value=\"".$edit_pr_row->PressReleaseContName."\"></b><br><br></td></tr>
<tr>
<td align=\"left\"> <font size=\"-1\"><b>Content:<br><textarea cols=\"40\" rows=\"10\" name=\"PressReleaseContent\"> ".$edit_pr_row->PressReleaseContent." </textarea></b>

    <p></td></tr>
	<tr><td align=\"center\" colspan=2><input type=\"Submit\" name=\"submit\" value=\"Update\"></td>
</tr>
</form>
";
}
else
{
echo "<font size=-1>That press release could not be located in our database.</font>";
}
}
}
}

// form submitted
// start processing it
else
{
// set up error list array
$errorList = array();
$count = 0;

// validate text input fields
if (!$PressReleaseHeadline) { $errorList[$count] = "Invalid entry: PressReleaseHeadline"; $count++; }

if (!$PressReleaseContent) { $errorList[$count] = "Invalid entry: PressReleaseContent"; $count++; }

// set default value for contact person
if (!$PressReleaseContName) { $PressReleaseContName = $Def_Contact; }

// check for errors
// if none found...
if (sizeof($errorList) == 0)
{
	// open database connection
	$connection = mysql_connect($host, $user, $pass) or die ("Unable to connect!");

	// select database
	mysql_select_db($db) or die ("Unable to select database!");

	// generate and execute query
	$qryUpdatePressRelease = "UPDATE tblPressRelease SET PressReleaseHeadline = '$PressReleaseHeadline', PressReleaseContent = '$PressReleaseContent', PressReleaseContName = '$PressReleaseContName', PressReleaseDate = NOW() WHERE PressReleaseID = '$id'";
	$rsltUpdatePressRelease = mysql_query($qryUpdatePressRelease) or die ("Error in query: $qryUpdatePressRelease. " . mysql_error());

	// print result
	echo "<font size=-1>Update successful. <a href=index.php>Go back to the main menu</a>.</font>";


}
else
{
	// errors occurred
	// print as list
	echo "<font size=-1>The following errors were encountered: <br>";
	echo "<ul>";
	for ($x=0; $x<sizeof($errorList); $x++)
	{
		echo "<li>$errorList[$x]";
	}
	echo "</ul></font>";
}

}

if ($mod == "")
{
echo ("No function selected");
}

// close connection
mysql_close($connection);
?>

[[deleted]]

It should be if (!$submit) because I'm saying if this form has not been submitted show the form with the appropriate values.

[[deleted]]

When I echo the Update query it comes up as

UPDATE tblPressRelease SET PressReleaseHeadline = 'Test Headline#4', PressReleaseContent = ' Test Content ', PressReleaseContName = 'Steve', PressReleaseDate = NOW() WHERE PressReleaseID = ''

If I change a value it is changed it the echoed query, but PressReleaseID does not appear in the echoed query.

I have line in the form that should provide the value in the URL to the form

<input type=\"hidden\" name=\"PressReleaseID\" value=\"".$id."\">

This does not seem to be working.

[wilsonodk]

Where do you define $id?
Is it being passed via GET or POST? If so that echo statement should be...

// For GET using php4 >= 4.2
echo "<input type=\"hidden\" name=\"PressReleaseID\" value=\"$_GET['id']\">";
// For POST using php4 >= 4.2
echo "<input type=\"hidden\" name=\"PressReleaseID\" value=\"$_POST['id']\">";

Notice the lack of concatenation operators. When you have a double quoted string variable will be parsed, so there isn't a need.

Also, when posting code please place it inside of the {php}...{/php} tags (where {, } are replaced with [, ]). It will help us help you.