if statements...

[anthill]

Hi peeps, I'm having a few probs with the following statement:

<?php

$to = $HTTP_POST_VARS['subject'];

if ($to == "General Query")
$to = "[e-mail]";
elseif ($to == "Suggestion")
$to = "[e-mail]";
elseif ($to == "Help")
$to = "[e-mail]";
elseif ($to == "Advertising")
$to = "[e-mail]";
elseif ($to == "Other..")
$to = "[e-mail]";

$name = $HTTP_POST_VARS['name'];
$from = $HTTP_POST_VARS['from'];

$subject = $HTTP_POST_VARS['subject'];
$info = $HTTP_POST_VARS['info'];
$body = $HTTP_POST_VARS['body'];

$email = "from: $name \n inf: $info \n email: $body";

mail($to, $subject, $email, "From: $from");

echo "Thank you for your email to $to"

?>

Therefore, if the subject contains 'Help' from the selected option, the email will be sent to [e-mail]. Not sure if this is working correctly though, because if the subject chosen is 'Other..', then echo says "Thank you for your email to Other.." rather than "Thank you for your email to [e-mail]".

So, is there a maximum number of elseif's you can have in one if statement? And, is there a better way of achieving the above?

Thanks

Anthill

[flameche]

It is clear that you have a typo somewhere so none of the conditions is your if/elseif is met. I suspect it should be in your list data.

To check that, add an else at the bottom of your last elseif and display an error message if it is the case.

[tomhath]

What flameche said is probably correct.

Part of the confusion here is your use of the $to variable to store the subject. I'd prefer doing it this way (keep the "subject" and "to" in their own variables, don't mix them):

$subject = $HTTP_POST_VARS['subject']; 

if ($subject == "General Query") 
$to = "[e-mail]"; 
elseif ($subject == "Suggestion") 
$to = "[e-mail]"; 
elseif ($subject == "Help") 
$to = "[e-mail]"; 
elseif ($subject == "Advertising") 
$to = "[e-mail]"; 
else
$to = "[e-mail]"; 

$name = $HTTP_POST_VARS['name']; 
$from = $HTTP_POST_VARS['from']; 

$info = $HTTP_POST_VARS['info']; 
$body = $HTTP_POST_VARS['body'];