mySQL and PHP problem, experienced coders help!

gabereiser

hi, i have been using php for a few years now, using MySQL for about a year. I have made a few sites that use mysql and php so I don't understand what i'm doing wrong here.

Below is a paste of 2 scripts i'm trying to get working, as of right now, when a person tried to register, NOTHING HAPPENS but... ...it tells them it's a sucess!

ok, here is "register.php"

include("db.conf.php");

$errortext = "";
if($submit)
{

if($password != $password2)
{
$errortext = "Error, your Password does not match! Please fix it!";
return;
}
else
{
if(!$username)
{
$errortext = "Error, you must create a Username!";
return;
}
if(!$email)
{
$errortext = "Error, you must supply an email address!";
return;
}
if(!$fname)
{
$errortext = "Error, you must supply a First Name!";
return;
}
if(!$lname)
{
$errortext = "Error, you must supply a Last Name!";
return;
}

  $checker = mysql_query("select * from users where username='$username'");
  $r1 = mysql_num_rows($checker);
  if($r1 >0)
  {
  $errortext = "Error, someone already has that username";
  return;
  }
  else
  {
       //$checker = "";
       $checker2 = mysql_query("select * from users where email='$email'");
       $r2 = mysql_num_rows($checker2);
       if($r2 >0)
       {
       $errortext = "Error, you can only register ONCE per email address!";
       return;
       }
   }

   $time = date("m/d/y");
   $result = MYSQL_QUERY("INSERT INTO users (username,password,email,fname,lname,datejoined) VALUES ('$username', 'md5('$password')', '$email', '$fname','$lname', '$time')");
   $errortext = "Sucessfully Joined! Please <a href=\"index.php\">click here</a> to return to the main page.";

 }

}
?>

<html>
<head>
<title>..::[GFX-Online.com - Art for the New Age!]::..</title>
<link href="main.css" rel="stylesheet" type="text/css">
</head>
<body><center>
<form method=post action="register.php">
<table cellpadding=0 cellscpaing=0 border=0>
<tr><td> <FONT SIZE=1 COLOR="FF2222"> <?php echo $errortext; php?> </FONT></td></tr><tr><td>
<table cellpadding=0 cellspacing=2 border=0>
<tr><td><FONT SIZE=1>Username:</td><td>
<INPUT style="BORDER-RIGHT: #000000 1px solid; BORDER-TOP: #000000 1px solid; BORDER-LEFT: #000000 1px solid; BORDER-BOTTOM: #000000 1px solid; FONT-SIZE: 10px; COLOR: #000000; FONT-FAMILY: Verdana; BACKGROUND-COLOR: #FFFFFF" TYPE='TEXT' NAME='username' size=9></td></tr>

<tr><td><FONT SIZE=1>Password:</td><td>
<INPUT style="BORDER-RIGHT: #000000 1px solid; BORDER-TOP: #000000 1px solid; BORDER-LEFT: #000000 1px solid; BORDER-BOTTOM: #000000 1px solid; FONT-SIZE: 10px; COLOR: #000000; FONT-FAMILY: Verdana; BACKGROUND-COLOR: #FFFFFF" TYPE='password' NAME='password' size=9></td></tr>

<tr><td><FONT SIZE=1>Password Again:</td><td>
<INPUT style="BORDER-RIGHT: #000000 1px solid; BORDER-TOP: #000000 1px solid; BORDER-LEFT: #000000 1px solid; BORDER-BOTTOM: #000000 1px solid; FONT-SIZE: 10px; COLOR: #000000; FONT-FAMILY: Verdana; BACKGROUND-COLOR: #FFFFFF" TYPE='password' NAME='password2' size=9></td></tr>

<tr><td><FONT SIZE=1>Email Address:</td><td>
<INPUT style="BORDER-RIGHT: #000000 1px solid; BORDER-TOP: #000000 1px solid; BORDER-LEFT: #000000 1px solid; BORDER-BOTTOM: #000000 1px solid; FONT-SIZE: 10px; COLOR: #000000; FONT-FAMILY: Verdana; BACKGROUND-COLOR: #FFFFFF" TYPE='TEXT' NAME='email' size=9></td></tr>

<tr><td><FONT SIZE=1>First Name:</td><td>
<INPUT style="BORDER-RIGHT: #000000 1px solid; BORDER-TOP: #000000 1px solid; BORDER-LEFT: #000000 1px solid; BORDER-BOTTOM: #000000 1px solid; FONT-SIZE: 10px; COLOR: #000000; FONT-FAMILY: Verdana; BACKGROUND-COLOR: #FFFFFF" TYPE='TEXT' NAME='fname' size=9></td></tr>

</table>
</form>
</center>
</body>
</html>

ok, and here is my login that I include into my main page:

<?
include("db.conf.php");
if ($userid && $password)
{

$newpass = md5('$password');
$result = mysql_query("select * from users where username='$userid' and password='$newpass'");
$num_rows = mysql_num_rows($result);
if ($num_rows >0 )
{
$myusername = $userid;
setcookie ("myusername", $myusername, time()+180000);
}
else
{
echo "<FONT FACE=ARIAL SIZE=1 COLOR=FF3333><B>UNABLE TO LOGIN DUE TO CONFLICTING INFORMATION, EITHER YOUR USERNAME AND/OR PASSWORD ARE INVALID</b></FONT>";
}
}
if (isset($HTTP_COOKIE_VARS["myusername"]))
{
echo "<img src=\"icons/brown_bullets.gif\" width=\"5\" height=\"15\"> <FONT SIZE=1>Logged in as <a href=\"userinfo.php?user=$myusername\">$myusername</a>    <a href=\"logout.php\">Logout</a>";
}
else
{
echo "<form method=post action=\"$php_self\">";
echo "<img valign=\"bottom\" src=\"icons/brown_bullets.gif\" width=\"5\" height=\"15\"> <font size=1>Username: </font><input style=\"BORDER-RIGHT: #000000 1px solid; BORDER-TOP: #000000 1px solid; BORDER-LEFT: #000000 1px solid; BORDER-BOTTOM: #000000 1px solid; FONT-SIZE: 10px; COLOR: #FF9933; FONT-FAMILY: Verdana; BACKGROUND-COLOR: #535353\" type='text' name='userid' size=9>  ";
echo "<font size=1>Password: </font><input style=\"BORDER-RIGHT: #000000 1px solid; BORDER-TOP: #000000 1px solid; BORDER-LEFT: #000000 1px solid; BORDER-BOTTOM: #000000 1px solid; FONT-SIZE: 10px; COLOR: #FF9933; FONT-FAMILY: Verdana; BACKGROUND-COLOR: #535353\" type='password' name='password' size=9>  <input style=\"BORDER-RIGHT: #000000 1px solid; BORDER-TOP: #000000 1px solid; BORDER-LEFT: #000000 1px solid; BORDER-BOTTOM: #000000 1px solid; FONT-SIZE: 10px; COLOR: #FFCC99; FONT-FAMILY: Verdana; BACKGROUND-COLOR: #535353\" type=submit value=\"Log In\"></form>  <a href=\"register.php\">Register Here!</a>";
}
?>

not the cleanest of code, but I don't understand y it won't input the registered user into the database. I have setup the "db.conf.php" file right, here is the db.conf.php file:

<?
mysql_connect("localhost", "root", "");
mysql_select_db("database");
?>

HELP! please for the love of god!

gabereiser

nevermind, I got it, lost track of how many elseif statements and all that, forgot that there was an OR operator " || " that would work better 😃

It works now 😃

cleromancer

I'd try trimming your inputs to get rid of excess whitespace. Might make error checking a little easier.

$name = $trim($name);

using a stylesheet should also cut down your download time by over half because you aren't repeating any information. 🙂