Problem's with UPDATE of a MySQL database...

[rheroux]

Hey folks, I'm creating a database that has existing customer information in it. All I did was dump the ODBC database, convert it to MySQL and then import it into the MySQL database. I've now played around with it so that there are 4 columns: id, user_name, pass_word and cust_name. Every column is populated except for the password column. I grabbed a random password generator script off of hotscripts, and I've tried to modify it so that it will input a random password for each customer all in one fell swoop. Here's the code:

<?php
include "config.php";
function random_char($string)
{
$length = strlen($string);
$position = mt_rand(0, $length - 1);
return($string[$position]);
}
function random_string ($charset_string, $length)
{
$return_string = random_char($charset_string);
for ($x = 1; $x < $length; $x++)
$return_string .= random_char($charset_string);
return($return_string);
} 

mt_srand((double)microtime() * 1000000);
$charset = "abcdefghijklmnopqrstuvwxyz12_34567890ABCDE_FGHIJKLMNOPQRSTWXYZ";


$dbcx = mysql_connect($dbhost,$dbuser,$dbpass);
mysql_select_db("CUSERS",$dbcx);
$sql1 = "UPDATE cusers SET pass_word = '".$password."' WHERE id = '".$count."'";
$count = 1;
while($count <= 1474)
{
$password = random_string($charset, 8);
mysql_query($sql1,$dbcx);
$count++;
}

?>

There are 1474 existing records in the database...I just don't understand why this isn't working. After I run it, the pass_word column's are all still blank.

Any help is appreciated.

[sjpatrick]

The $password and $count in your $sql1 assignment statement, that is.
Move your '$sql =' line into your while loop beneath your '$password = ' line.

That should do it.

<geek>Steve</geek>

[rheroux]

Okay, I tried what you suggested and it still isn't working. Here's the updated code (I decided to use a for loop since it makes more sense):

<?php
include "config.php";
function random_char($string)
{
$length = strlen($string);
$position = mt_rand(0, $length - 1);
return($string[$position]);
}
function random_string ($charset_string, $length)
{
$return_string = random_char($charset_string);
for ($x = 1; $x < $length; $x++)
$return_string .= random_char($charset_string);
return($return_string);
} 

mt_srand((double)microtime() * 1000000);
$charset = "abcdefghijklmnopqrstuvwxyz12_34567890ABCDE_FGHIJKLMNOPQRSTWXYZ";


$dbcx = mysql_connect($dbhost,$dbuser,$dbpass);
mysql_select_db("CUSERS",$dbcx);
for($count=0; $count <= 1474; $count++)
{
$password = random_string($charset, 8);
$sql1 = "UPDATE cusers SET pass_word = '".$password."' WHERE id = '".$count."'";
mysql_query($sql1,$dbcx);
}

?>

[skynet]

a suggestion:

maybe u could remove the ' from the where id= part...

like this:

$sql1 = "UPDATE cusers SET pass_word = '".$password."' WHERE id = ".$count;

i thinks the id column ain't varchar type is it?

bye

skynet

[rheroux]

Yeah, the id column is int(5) unsigned auto_increment primary key.

I tried the suggestion you made so that the id wouldn't be encompassed by quotes, and it's still not working. sigh, it should be so easy, yet it's not working.

[wilsonodk]

Table names are case-sensitive...

// Not...
$sql1 = "UPDATE cusers SET pass_word = '".$password."' WHERE id = ".$count;

// ...instead...
$sql1 = "UPDATE CUSERS SET pass_word = '$password' WHERE id = $count";

It should be so simple, and it is! 😃