IMG url's in database, HELP!!!

[gabereiser]

I'm having a problem getting IMG urls to load from the database into my script, when I look at the source in the browser, it shows <IMG SRC="Resource Id #3"> which means it's not extracting it from the database right, correct?

here is my php code I have:

<?
include("db.conf.php");

$getnewsshort = mysql_query("SELECT * FROM news order by id desc");
while($r = mysql_fetch_array($getnewsshort))
{
$id = $r["id"];
$title = $r["title"];
$shortdesc = $r["shortdesc"];
$poster = $r["poster"];
$approvedby = $r["approvedby"];
$comments = $r["comments"];
$date = $r["date"];
$isapproved = $r["isapproved"];
$postericon = mysql_query("SELECT icon FROM users where username='.$poster'");
//$icon = mysql_result($postericon);

if($isapproved = "Y"){
?>

<br><br>
<table width="95%" cellpadding=0 cellspacing=4 border=0><tr><td><a class="headlinetitle" href="news.php?id=<?echo $id;?>"><?echo $title;?></a></td></tr>
<tr><td><font size=1>posted by <a href="http://<?echo $poster;?>.gfx-online.com"><?echo $poster;?></a> on <?echo $date;?><span align="right">approved by <a href="http://<?echo $approvedby;?>.gfx-online.com"><?echo $approvedby;?></a>&nbsp;&nbsp;<img src="<?echo $postericon;?>"></td></tr>
<tr><td><font size=1><?echo $shortdesc;?></td></tr>
<tr><td><a href="news.php?id=<?echo $id;?>">(<?echo $comments;?>) comments on this article</a></td></tr></table>
<? }
else
{
echo "No News posts";
}
}?>

every user has an ICON field (default to "usericons/none.jpg").

it won't show up!!!

this is what it looks like in the browser source:

<table width="95%" cellpadding=0 cellspacing=4 border=0><tr><td><a class="headlinetitle" href="news.php?id=1">test</a></td></tr>
<tr><td><font size=1>posted by <a href="http://aeon.gfx-online.com">aeon</a> on 11/12/02<span align="right">approved by <a href="http://aeon.gfx-online.com">aeon</a>&nbsp;&nbsp;<img src="Resource id #3"></td></tr>
<tr><td><font size=1>test</td></tr>
<tr><td><a href="news.php?id=1">(0) comments on this article</a></td></tr></table>

any insight?

[raymie]

Two points.

1 - When inserting code into a posting you should use the code tags in order to make it readable. Without that a lot of people will just ignore your post.

2 - Unless I have missed it, the code not being in code tags makes it hard to read, you have failed to code the query correctly and have missed out several important bits.

A working example is

$result = mysql_query($cmd);
$row = mysql_fetch_array($result,MYSQL_ASSOC);

You will note in the above two things.

firstly how readable it is being highlighted 🙂
and secondly that the results need to be read into an array before you can get the values, you have $postericon being the result of the first line, this is not correct if you want a value from the database, the result of the query is the resource string used to access the query results and not the actual results themselves.

[gabereiser]

bah, i forgot about having to fetch the array afterwards 😃 it's always the little things that get ya 😃

As for highlighting the code, i'm kinda new here and didn't know that was a feature, I will do that from now on thx.

It works now, here is what I modified.

$getnewsshort = mysql_query("SELECT * FROM news order by id desc");
while($r = mysql_fetch_array($getnewsshort))
{
  $id = $r["id"]; 
  $title = $r["title"]; 
  $shortdesc = $r["shortdesc"]; 
  $poster = $r["poster"];
  $approvedby = $r["approvedby"];
  $comments = $r["comments"];
  $date = $r["date"]; 
  $isapproved = $r["isapproved"];
  $postericon = mysql_query("SELECT icon FROM users where username='$poster'");
    while($r2 = mysql_fetch_array($postericon)){$icon = $r2['icon'];}