No errors, but the databse is not updated!!! Please help!

rupertbj

Please review the following code - all seems fine (i.e. no error messages), but the database does not get updated!

Any suggestions would be much appreciated.

<?php
include("admin.inc");
if ((!ereg(".+\@.+\..+", $user)) || (!ereg("^[a-zA-Z0-9_@.-]+$", $user)))
	{
    print "
	<body bgcolor=\"#8080FF\">
	<b>Invalid Email address! Please <a href=/index.html>register</a> properly!!!</b>
	";
	exit;
	}
else
	{
	setcookie( "user", $user, "0" );
	$db = "register";
	$link = mysql_connect( "localhost:/users/rupertbj/domains/rupstar.co.uk/sql/mysql.sock", "root" );
	if ( !$link ) die( "Couldn't connect to MySQL" );
	mysql_select_db( $db, $link ) or die( "Couldn't open $db: ".mysql_error() );
	$selectUser = "SELECT * FROM userTable WHERE email = '$email' ";
	$result = mysql_query($selectUser, $link) or die( "Couldn't open $db: ".mysql_error() );
	$num_rows = mysql_num_rows($result); 
	if ($num_rows > 0) 
	{ 
	$query = "REPLACE INTO userTable VALUES ( $email, now() ) WHERE email = '$email' "; 
	mysql_query( $query, $link ); 
	} 
	else 
	{ 
	$sql = "INSERT INTO userTable VALUES ( $email, now() )"; 
	mysql_query( $sql, $link ); 
	} 
	mysql_close( $link );
	}
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN">
<html>
<head>
<meta http-equiv="Page-Enter" CONTENT="RevealTrans(Duration=2,Transition=2)">
<meta http-equiv="Page-Exit" CONTENT="RevealTrans(Duration=2,Transition=2)">
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link rel="stylesheet" href="format.css" type="text/css">
<title>This is rupstar.co.uk...</title>
</head>
<body bgcolor="#8080FF">
	<p align=center><img src="/images/rupstar.gif"></p>
	<table width=100% cellpadding=5 cellspacing=5 border=0>
	<tr>
	<td valign=top width=30% bgcolor=#88BB77 class=text>

  <table width=100% class=text>
	<tr> 
	  <td>Pick an option...</td>
	</tr>
	<tr> 
	  <td bgcolor=#666666 align=center><a href="dark.php">Photos</a></td>
	</tr>
	<tr> 
	  <td bgcolor=#CC3333 align=center><a href="gossip.php">Forum</a></td>
	</tr>
	<tr> 
	  <td bgcolor=#009900 align=center><a href="green.php">Events</a></td>
	</tr>
	<tr>
	  <td bgcolor=#FFFF33 align=center><a href="contact.php">Contact</a></td>
	</tr>
  </table>
</td>
<td valign=top width=70% bgcolor=#AA7799>
<span class=text>Welcome to the interior of the site!!!</span>
  <p><?php echo $interior ?></p>
</td>
</tr>
</table>
<p class=mini>Designed by<b> </b><a href="mailto:design@rupstar.co.uk"><b>rupstar</b></a><b> 
  &copy; 2002</b></p>
</body>
</html>

jburfield

Assuming that the 'email' column in the db is a primary key, you can get rid of the select statement and just issue a REPLACE statement, like this:

$db = "register";

$link = mysql_connect("localhost:/users/rupertbj/domains/rupstar.co.uk/sql/mysql.sock", "root" );

if ( !$link ) die( "Couldn't connect to MySQL" );

mysql_select_db( $db, $link ) or die( "Couldn't open $db: ".mysql_error() );

$query = "REPLACE INTO userTable (EMAILFIELD, DATEFIELD) VALUES ( $email, now() )"; 

mysql_query( $query, $link ); 

mysql_close( $link );

Notice that the replace statement I used is different than the one you originally had.

You need to include the PRIMARY KEY in the replace statement, so I'm going to assume that your primary key is the email column. That is how the REPLACE statement works, if the primary key already exists it just writes over it with the updated information, if it does not exist it does an insert into the db.

Try that, at least try the different replace statement, and see if you have any more luck.

-- Jason

rupertbj

Thanks Jason - its works a treat!!!